Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(entrypoint): fix external cmd args quote error #3135

Merged
merged 1 commit into from
Feb 2, 2024
Merged

bug(entrypoint): fix external cmd args quote error #3135

merged 1 commit into from
Feb 2, 2024

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added the bug 🐛 Something isn't working label Feb 2, 2024
@tianweidut tianweidut self-assigned this Feb 2, 2024
goldenxinxing
goldenxinxing approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 2d3eaac into star-whale:main Feb 2, 2024
34 checks passed
@tianweidut tianweidut deleted the fix/argument-input branch February 2, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldenxinxing goldenxinxing goldenxinxing approved these changes

Assignees

@tianweidut tianweidut

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianweidut @goldenxinxing