Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime): support runtime-uri argument for job create command #840

Merged
merged 3 commits into from
Aug 2, 2022
Merged

feat(runtime): support runtime-uri argument for job create command #840

merged 3 commits into from
Aug 2, 2022

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Aug 1, 2022 •
edited
Loading

Description

Feature Show

runtime-activate

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3 milestone Aug 1, 2022
@tianweidut tianweidut self-assigned this Aug 1, 2022
@tianweidut tianweidut changed the title WIP: feat(runtime): support runtime-uri argument for job create command in the non-docker… WIP: feat(runtime): support runtime-uri argument for job create command Aug 1, 2022
@tianweidut tianweidut mentioned this pull request Aug 1, 2022
Closed
3 tasks
@tianweidut tianweidut force-pushed the feat/activate-job branch 2 times, most recently from ff037f9 to 1ab683d Compare August 1, 2022 13:11
@tianweidut tianweidut changed the title WIP: feat(runtime): support runtime-uri argument for job create command feat(runtime): support runtime-uri argument for job create command Aug 1, 2022
@tianweidut tianweidut marked this pull request as ready for review August 1, 2022 13:37
@jialeicui
Copy link
Contributor

LGTM

@jialeicui jialeicui merged commit 86d17a4 into star-whale:main Aug 2, 2022
@tianweidut tianweidut linked an issue Aug 2, 2022 that may be closed by this pull request
tune the user experience of Starwhale rutime activating #752
Closed
3 tasks
@tianweidut tianweidut mentioned this pull request Aug 15, 2022
Merged
9 tasks
@tianweidut tianweidut deleted the feat/activate-job branch April 17, 2023 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jialeicui jialeicui jialeicui approved these changes

@goldenxinxing goldenxinxing Awaiting requested review from goldenxinxing

Assignees

@tianweidut tianweidut

Labels
client 🌈 feature ✨ new feature runtime🐌 standalone 💻
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

tune the user experience of Starwhale rutime activating
2 participants
@tianweidut @jialeicui