Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(console): use builtin icon font #855

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Fixes #812

Modules

  • UI

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added chore 🛎️ some tiny change console 🎨 console labels Aug 3, 2022
tianweidut
tianweidut previously approved these changes Aug 3, 2022
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit b0c225e into star-whale:main Aug 3, 2022
@jialeicui jialeicui deleted the replace-icons branch August 3, 2022 07:39
goldenxinxing pushed a commit to goldenxinxing/starwhale that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change console 🎨 console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change icons from react icons to our icon fonts
2 participants