Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): accessing resource with no access will redirect to the login page #866

Merged
merged 1 commit into from
Aug 4, 2022
Merged

fix(console): accessing resource with no access will redirect to the login page #866

merged 1 commit into from
Aug 4, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Fixes #823

http.code.mp4

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

waynelwz
waynelwz approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

waynelwz
waynelwz approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dreamlandliu
dreamlandliu approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dreamlandliu dreamlandliu merged commit d413183 into star-whale:main Aug 4, 2022
goldenxinxing pushed a commit to goldenxinxing/starwhale that referenced this pull request Aug 5, 2022
@jialeicui
fix(console): accessing resource with no access will redirect to the …
4417d1b 
…login page (star-whale#866)
@jialeicui jialeicui deleted the fix-bug-823 branch August 10, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynelwz waynelwz waynelwz approved these changes

@dreamlandliu dreamlandliu dreamlandliu approved these changes

Assignees
No one assigned
Labels
chore 🛎️ some tiny change console 🎨 console controller 🏘️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refresh browser page after getting a 403 result of api access will redirect to the login page
3 participants
@jialeicui @dreamlandliu @waynelwz