Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dataset): tune dataset code organization #966

Merged
merged 1 commit into from
Aug 23, 2022
Merged

refactor(dataset): tune dataset code organization #966

merged 1 commit into from
Aug 23, 2022

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added this to the v0.3 milestone Aug 23, 2022
@tianweidut tianweidut self-assigned this Aug 23, 2022
goldenxinxing
goldenxinxing approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@goldenxinxing goldenxinxing merged commit ccc3bd0 into star-whale:main Aug 23, 2022
@tianweidut tianweidut deleted the refactor/dataset-org branch April 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldenxinxing goldenxinxing goldenxinxing approved these changes

@jialeicui jialeicui Awaiting requested review from jialeicui

Assignees

@tianweidut tianweidut

Labels
dataset🐫 refactor 🐛 refactor code
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tianweidut @goldenxinxing