Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): support new job/dataset/datastore/runtime #969

Merged
merged 21 commits into from
Aug 25, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Aug 23, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing changed the title WIP: Feat/controller support new job/dataset/datastore/runtime WIP: feat(controller): support new job/dataset/datastore/runtime Aug 25, 2022
@goldenxinxing goldenxinxing marked this pull request as ready for review August 25, 2022 07:07
@goldenxinxing goldenxinxing added bug 🐛 Something isn't working feature ✨ new feature refactor 🐛 refactor code labels Aug 25, 2022
@goldenxinxing goldenxinxing changed the title WIP: feat(controller): support new job/dataset/datastore/runtime feat(controller): support new job/dataset/datastore/runtime Aug 25, 2022
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit ed5fd3c into main Aug 25, 2022
dreamlandliu pushed a commit to dreamlandliu/starwhale that referenced this pull request Aug 25, 2022
…le#969)

* tune job and task impl

* feat(controller): add job token & storage env for job  (star-whale#940)

job token env;s3 env

* add project info for task

* add env for k8s core container

* test(e2e): modify e2e deployment from docker compose to minikube (star-whale#948)

e2e test

* feat(controller): storage prefix env (star-whale#941)

swds path prefix injection

Co-authored-by: star <15031259256@163.com>

* fix(controller): fix dataset upload error (star-whale#958)

* error fix

* fix protocol un match error

Co-authored-by: star <15031259256@163.com>

* change task container entrypoint

* fix(controller): fix sql error (star-whale#977)

fix some error

* add update last step ID mapper function

* bug fix

* add new console ui resource

* tune sql script version

* fix select task sql bug

* remove job list condition at debugging

* fix  unit test error

Co-authored-by: gaoxinxing <15931259256@163.com>
Co-authored-by: renyanda <781905270@qq.com>
@goldenxinxing goldenxinxing deleted the feat/controller_support_new_job branch August 25, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants