-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(controller): support new job/dataset/datastore/runtime #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
job token env;s3 env
swds path prefix injection Co-authored-by: star <15031259256@163.com>
* error fix * fix protocol un match error Co-authored-by: star <15031259256@163.com>
fix some error
goldenxinxing
changed the title
WIP: Feat/controller support new job/dataset/datastore/runtime
WIP: feat(controller): support new job/dataset/datastore/runtime
Aug 25, 2022
goldenxinxing
added
bug 🐛
Something isn't working
feature ✨
new feature
refactor 🐛
refactor code
labels
Aug 25, 2022
goldenxinxing
changed the title
WIP: feat(controller): support new job/dataset/datastore/runtime
feat(controller): support new job/dataset/datastore/runtime
Aug 25, 2022
anda-ren
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dreamlandliu
pushed a commit
to dreamlandliu/starwhale
that referenced
this pull request
Aug 25, 2022
…le#969) * tune job and task impl * feat(controller): add job token & storage env for job (star-whale#940) job token env;s3 env * add project info for task * add env for k8s core container * test(e2e): modify e2e deployment from docker compose to minikube (star-whale#948) e2e test * feat(controller): storage prefix env (star-whale#941) swds path prefix injection Co-authored-by: star <15031259256@163.com> * fix(controller): fix dataset upload error (star-whale#958) * error fix * fix protocol un match error Co-authored-by: star <15031259256@163.com> * change task container entrypoint * fix(controller): fix sql error (star-whale#977) fix some error * add update last step ID mapper function * bug fix * add new console ui resource * tune sql script version * fix select task sql bug * remove job list condition at debugging * fix unit test error Co-authored-by: gaoxinxing <15931259256@163.com> Co-authored-by: renyanda <781905270@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something isn't working
controller 🏘️
dataset🐫
datastore 🐇
deploy 🚀
feature ✨
new feature
refactor 🐛
refactor code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modules
Checklist