Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Trino to 0.326 #315

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Bump Trino to 0.326 #315

merged 1 commit into from
Jul 3, 2023

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Jun 29, 2023

Overview

https://github.com/trinodb/trino-python-client/blob/master/CHANGES.md

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • README.md updated and added information about my change
  • I have run changie new to create a changelog entry

@findinpath findinpath requested a review from hovaesco June 30, 2023 07:49
@findinpath
Copy link
Collaborator

Maybe EXECUTE IMMEDIATE https://github.com/trinodb/trino-python-client/blob/master/CHANGES.md#release-03250 could be used on seed

@hovaesco
Copy link
Contributor

Maybe EXECUTE IMMEDIATE https://github.com/trinodb/trino-python-client/blob/master/CHANGES.md#release-03250 could be used on seed.

it should work out of the box if server supports it (>417).

@Fokko
Copy link
Contributor Author

Fokko commented Jun 30, 2023

@hovaesco @findinpath I've got the test passing locally, could we kick off the CI? Thanks! :)

@hovaesco
Copy link
Contributor

hovaesco commented Jul 3, 2023

@Fokko please squash the commits and we're good to go!

@Fokko
Copy link
Contributor Author

Fokko commented Jul 3, 2023

@hovaesco Done!

@damian3031
Copy link
Member

@Fokko please rebase onto master, as test_constraints tests are already fixed there.

@Fokko
Copy link
Contributor Author

Fokko commented Jul 3, 2023

@damian3031 Thanks for the heads-up, done!

@damian3031 damian3031 self-requested a review July 3, 2023 16:32
@hovaesco hovaesco merged commit 5db1895 into starburstdata:master Jul 3, 2023
8 checks passed
@Fokko Fokko deleted the patch-1 branch July 3, 2023 17:25
@damian3031 damian3031 mentioned this pull request Jul 5, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants