Validate no partition value is null when making partition name

Extracted-From: prestodb/presto#11376
starburstdata · Jan 29, 2019 · de589d4 · de589d4
1 parent 4220e1a
commit de589d4
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/MetastoreUtil.java b/presto-hive/src/main/java/io/prestosql/plugin/hive/metastore/MetastoreUtil.java
@@ -23,6 +23,7 @@
 
 import java.util.List;
 import java.util.Map;
+import java.util.Objects;
 import java.util.Optional;
 import java.util.Properties;
 
@@ -178,6 +179,8 @@ public static ProtectMode getProtectMode(Table table)
     public static String makePartName(List<Column> partitionColumns, List<String> values)
     {
         checkArgument(partitionColumns.size() == values.size(), "Partition value count does not match the partition column count");
+        checkArgument(values.stream().allMatch(Objects::nonNull), "partitionValue must not have null elements");
+
         List<String> partitionColumnNames = partitionColumns.stream().map(Column::getName).collect(toList());
         return FileUtils.makePartName(partitionColumnNames, values);
     }