-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add upgrade plan event #128
Conversation
let account_address = Signer::address_of(account); | ||
if (!exists<UpgradePlanEventHolder>(account_address)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里后向兼容的考虑应该是放到 submit_upgrade_plan_with_cap_v2 里面,但是这样需要 submit_upgrade_plan_with_cap_v2 接受 signer 参数。
这种兼容问题一般怎么处理?@jolestar
let package_address = cap.account_address; | ||
assert!(get_module_upgrade_strategy(package_address) == STRATEGY_TWO_PHASE, Errors::invalid_argument(ESTRATEGY_NOT_TWO_PHASE)); | ||
let tpu = borrow_global_mut<TwoPhaseUpgradeV2>(package_address); | ||
let active_after_time = Timestamp::now_milliseconds() + tpu.config.min_time_limit; | ||
tpu.plan = Option::some(UpgradePlanV2 { package_hash, active_after_time, version, enforced }); | ||
if (Option::is_some(&tpu.plan)) { | ||
let plan = Option::borrow(&tpu.plan); | ||
let event_holder = borrow_global_mut<UpgradePlanEventHolder>(package_address); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里要考虑到旧的已经升级成 TwoPhase 的账户没有 UpgradePlanEventHolder
, 需要做个兼容处理。但这里拿不到 package address 的 signer,能想到两个办法:
- 提供一个初始化 UpgradePlanEventHolder 的入口方法,旧的地址调用一下
- 通过 Account module 提供一个
friend
方法来模拟用户创建和写入UpgradePlanEventHolder
这个兼容性问题怎么测试也需要想一下.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里要考虑到旧的已经升级成 TwoPhase 的账户没有
UpgradePlanEventHolder
, 需要做个兼容处理。但这里拿不到 package address 的 signer,能想到两个办法:
- 提供一个初始化 UpgradePlanEventHolder 的入口方法,旧的地址调用一下
- 通过 Account module 提供一个
friend
方法来模拟用户创建和写入UpgradePlanEventHolder
这个兼容性问题怎么测试也需要想一下.
我感觉这里还是第二种方式比较好:
1.submit_upgrade_plan_v2(account: &signer, package_hash: vector<u8>, version:u64, enforced: bool)
一般由个人/多签账户发起,此时可以初始化UpgradePlanEventHolder
2.submit_upgrade_plan_with_cap_v2(cap: &UpgradePlanCapability, package_hash: vector<u8>, version: u64, enforced: bool)
一般由 signer
托管账户(DAO账户)调用,如果只提供单独的 初始化入口方法, DAO 账户的合约将无法升级
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
方案二 可以给任意地址新增 UpgradePlanEventHolder
资源吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
测试的话是否可以从 banard fork 状态,0x1 地址上应该已经有 TwoPhaseUpgradeV2
但是没有 UpgradePlanEventHolder
。符合测试条件。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
方案二 可以给任意地址新增
UpgradePlanEventHolder
资源吗?
用地址生成一个 signer
,“替用户执行”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
方案二 可以给任意地址新增
UpgradePlanEventHolder
资源吗?
friend
, 仅 framework 内部调用
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
方案二 可以给任意地址新增
UpgradePlanEventHolder
资源吗?用地址生成一个
signer
,“替用户执行”
参考这个函数的使用方法:
public (friend) fun get_genesis_capability():SignerCapability{
let signer_cap = SignerCapability {addr: Token::token_address<STC>() };
signer_cap
}
https://github.com/starcoinorg/starcoin-framework/blob/main/sources/Account.move#L19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
方案二会产生循环引用,PackageTxnManager use Account, Account use STC, STC use PackageTxnManager .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
方案二会产生循环引用,PackageTxnManager use Account, Account use STC, STC use PackageTxnManager .
哦,这是个问题。初始化旧版本的 DAO 的逻辑,感觉需要清理一下,那感觉可以先用方案一,现在通过 signer 托管方式实现的应该少,原来的 signer 托管后有升级合约的难题。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
清理的问题记录了一个 issue #139
sources/PackageTxnManager.move
Outdated
let package_address = cap.account_address; | ||
assert!(get_module_upgrade_strategy(package_address) == STRATEGY_TWO_PHASE, Errors::invalid_argument(ESTRATEGY_NOT_TWO_PHASE)); | ||
let tpu = borrow_global_mut<TwoPhaseUpgradeV2>(package_address); | ||
let active_after_time = Timestamp::now_milliseconds() + tpu.config.min_time_limit; | ||
tpu.plan = Option::some(UpgradePlanV2 { package_hash, active_after_time, version, enforced }); | ||
if (Option::is_some(&tpu.plan)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个IF判断感觉可以去掉?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
1d36b36
to
5762638
Compare
* Revert "fix stake plugin for compatibility (#218)" This reverts commit e618173. * Revert "add some test_functions (#216)" This reverts commit 87859a9. * Revert "Add WithdrawPlugin (#214)" This reverts commit a66f0f3. * Revert "fix StakeToSBTPlugin install event (#215)" This reverts commit 77a968a. * Revert "add install plugin proposal for TreasuryPlugin (#213)" This reverts commit a98de9e. * Revert "Fix v12 (#210)" This reverts commit bfd8fa6. * Revert "release v12 (#205)" This reverts commit 94be70e. * Revert "Fix some entry function and do some clean (#203)" This reverts commit 884f648. * Revert "prepare v12 release (#200)" This reverts commit 3bae7fd. * Revert "Refactor root cap (#198)" This reverts commit b30fdc9. * Revert "feat: add entry for plugin marketplace (#199)" This reverts commit 459ce12. * Revert "Upgrade MerkleNFTDistributor::register to v2 (#196)" This reverts commit 40178bb. * Revert "[daospace] Refactor daospace functions name (#195)" This reverts commit 0dd5c68. * Revert "Accept Offer and Accept NFT (#192)" This reverts commit 19b7d1d. * Revert "Fix sign flag for SignedInteger64 zero (#191)" This reverts commit 722a298. * Revert "fix cmp (#190)" This reverts commit fce8707. * Revert "Fix (#189)" This reverts commit 64d754d. * Revert "feat: remove sender of update_plugin (#187)" This reverts commit cb21b0a. * Revert "Custom proposal's quorum_votes for plugin (#184)" This reverts commit 45eb5ca. * Revert "[Feature] Proposal add title and introduction (#183)" This reverts commit 4ebe51b. * Revert "[DAOSpace] Plugin marketplace remove NFT (#186)" This reverts commit f186ec8. * Revert "Migrate Genesis initialize to new DAOSpace (#181)" This reverts commit 57e859e. * Revert "Update GasOracle module" This reverts commit f0270c3. * Revert "Fix prologue gas token error" This reverts commit 3c58061. * Revert "[Feature] Simple map (#182)" This reverts commit daa971f. * Revert "add some function in Compare (#180)" This reverts commit e5a3108. * Revert "fix to_bytes need store (#179)" This reverts commit 31792d4. * Revert "[Feature] Member Grant Offer (#174)" This reverts commit 0234cfc. * Revert "migrate TreasuryWithdrawDaoProposal to DAOSpace TreasuryPlugin (#175)" This reverts commit f44fd34. * Revert "refactor plugin initialize (#176)" This reverts commit e4c7bf8. * Revert "update old links in README (#173)" This reverts commit cb26bbd. * Revert "[Bugfix]Fix ERR_EXPECT_NOT_MEMBER (#172)" This reverts commit dca2274. * Revert "Fix acount.txn_epilogue_v2 incompatible (#168)" This reverts commit ad81d03. * Revert "[Feature] Add dao create test (#167)" This reverts commit dfbf3d7. * Revert "Remove proposal after executed or rejected (#145)" This reverts commit 1e17512. * Revert "EasyGas support (#92)" This reverts commit e142883. * Revert "Reformat code and decrease_member_sbt when unstake (#166)" This reverts commit 25148a4. * Revert "upgrade mpm to 1.12.5 and fix integration tests (#163)" This reverts commit 0fb8810. * Revert "[Feature] DAOSpace add join_member_with_root_cap (#164)" This reverts commit 1518644. * Revert "[Feature] Add ASCII module and TODO: ascii DAO name (#161)" This reverts commit d3eb047. * Revert "[Feature]DAOAccount Todo : add exists_upgrade_plan_cap (#160)" This reverts commit 1fb3b8a. * Revert "fix eventutil (#146)" This reverts commit d2c4f5c. * Revert "[Feature] Make StarcoinDAO inherit Dao's config (#144)" This reverts commit 8675779. * Revert "migrate script to entry function (#142)" This reverts commit 971a1a2. * Revert "[Feature] Multi Offer (#135)" This reverts commit 4ec8c2f. * Revert "add upgrade plan event (#128)" This reverts commit e82c1d3. * Revert "merge upgrade entry v12 and v12_1 (#126)" This reverts commit 47b38ad. * Revert "[Feature] NFTGallery Add Errors Assert (#138)" This reverts commit 61392b0. * Revert "Add event util (#134)" This reverts commit 545f191. * Revert "#131 Add only_new_module (#132) " This reverts commit f1363a3. * Revert "[Feature] DAO incompatible module upgrade test (#133)" This reverts commit 022ca1a. * Revert "update_module_upgrade_strategy support set min_time_limit (#127)" This reverts commit c8c9ba7. * Revert "Daospace support plugin marketplace (#116)" This reverts commit 6cccb73. * Revert "check StakeList existence (#124)" This reverts commit dee9a0b. * Revert "[ Feature ] do deposit when proposal state is DEFEATED (#122)" This reverts commit 3274821. * Revert "[daospace] Remove proposal info and add get function for proposal (#121)" This reverts commit 7b44ee7. * Revert "[integration-test] StarcoinDAO integration-test (#112)" This reverts commit 45f017a. * Revert "add assertion in stake to `StakeToSBTPlugin::stake` while the lock ti… (#117)" This reverts commit 08928d4. * Revert "Add Script function entry (#111)" This reverts commit 4c32fda. * Revert "Fix DAO Pulgin Event (#118)" This reverts commit 3cda388. * Revert "Plugin Event (#97)" This reverts commit 31b9a9c. * Revert "fix SalaryGovPlugin and migrate to test (#115)" This reverts commit 3e95aef. * Revert "[account] Retry when creating delegate account (#110)" This reverts commit 7a38b4b. * Revert "Add upgrade plugin And add StarcoinDAO (#94)" This reverts commit 85418d7. * Revert "able to update DAOExt (#108)" This reverts commit fc7ac4a. * Revert "[Feature] Public Native name_of function (#107)" This reverts commit 7263b0a. * Revert "MintProposalPlugin (#105)" This reverts commit ff2d802. * Revert "add daospace module upgrade test (#98)" This reverts commit 70429e2. * Revert "Add DAO nft image and member image (#96)" This reverts commit 2c89bbc. * Revert "Dao integration test and upgrade mpm (#95)" This reverts commit 82032cc. * Revert "add integration-test for refund_grant (#93)" This reverts commit 52fb86d. * Revert "signature.move add secp256k1_verify function (#86)" This reverts commit 9ea61ce. * Revert "check DAOAccountCap (#89)" This reverts commit 0404a53. * Revert "Add DAOSpace description (#85)" This reverts commit a981f67. * Revert "Remove decrease SBT when unstake item (#81)" This reverts commit d401c37. * Revert "[signature] Fix EVMAddress padding and crop bug (#84)" This reverts commit 41ad861. * Revert "fix dao snapshot deserialize when some option field is empty (#82)" This reverts commit b272a6f. * Revert "Complete DAOSpace (#80)" This reverts commit 98e96e6. * Revert "[dao] Implement DAOSpace (#32)" This reverts commit 0d37c89. * Revert "Update README.md (#68)" This reverts commit d3bb99f. * Revert "Update .gitattributes (#63)" This reverts commit 41ed34b. * Revert "support installing mpm from source (#56)" This reverts commit 3f46c6c. * Revert "[WIP] add Block state root (#39) (#41)" This reverts commit 67027f9. * Revert "Add multiple types of bcs skip and test (#52)" This reverts commit a5dc012. * Revert "upgrade rust toolchain 1.62.0 (#51)" This reverts commit 81c1e51. * Revert "implement Ring module (#44)" This reverts commit c9582a6. * Revert "support starcoin snapshot proof and verify (#45)" This reverts commit 63b05ec. * Revert "add bcs function , byte to basic type (#43)" This reverts commit e39dfeb. * Revert "account events (#42)" This reverts commit bfbe32c. * Revert "[scripts] fix dev_setup package manager detection and mpm version on ubuntu18.04 (#37)" This reverts commit 796fd3f. * Revert "Upgrade mpm to v1.11.11 (#36)" This reverts commit 92fb22a. * Revert "[Feature] Identifier nft add borrow function (#34)" This reverts commit 3e24ac4. * Revert "[account] Add create_delegate_account function (#31)" This reverts commit a225d41. * Revert "STRATEGY_FREEZE use invalid_argument (#29)" This reverts commit 51828cd. * Revert "remove zero Balance or empty NFTGallery (#28)" This reverts commit 0303214. * Revert "update rust 1.61 (#27)" This reverts commit 6da0321. * Revert "[ci] Upgrade mpm version to v1.11.9 (#26)" This reverts commit c2475ea. * Revert "Improve spec of several modules (#25)" This reverts commit 8f8e5a0. * Revert "Update README.md" This reverts commit 8fc83b6. * Revert "Upgrade mpm to v1.11.5-alpha and rename `spectest` to `integrationt-test` (#24)" This reverts commit a35c3f7. * Revert "Update stdlib spec, remove redundant spec funcs and improve coding style (#23)" This reverts commit 9c9922d. * Revert "[doc] Add a readme template for generate docs (#22)" This reverts commit 2c53e4f. * Revert "[test] Add a signature test for verify message signature from starcoin cli. (#17)" This reverts commit f88c277. * Revert "Add a script to generate docs and commit docs to git (#21)" This reverts commit 60c8002. * Revert "#13 [Feature Request] Account::deposit(address, token) auto create a… (#14)" This reverts commit 88061e9. * Revert "[ci] fix spectest (#15)" This reverts commit 0b866e1. * Revert "config Move highlighting (#12)" This reverts commit 01c8419. * Revert "simplify dev setup scripts (#2)" This reverts commit d2a2fc9. * Revert "[ci & doc] Add more document and setup ci github action workflow. (#1)" This reverts commit 9fd1e52. * add Cargo.lock
* Revert "fix stake plugin for compatibility (#218)" This reverts commit e618173. * Revert "add some test_functions (#216)" This reverts commit 87859a9. * Revert "Add WithdrawPlugin (#214)" This reverts commit a66f0f3. * Revert "fix StakeToSBTPlugin install event (#215)" This reverts commit 77a968a. * Revert "add install plugin proposal for TreasuryPlugin (#213)" This reverts commit a98de9e. * Revert "Fix v12 (#210)" This reverts commit bfd8fa6. * Revert "release v12 (#205)" This reverts commit 94be70e. * Revert "Fix some entry function and do some clean (#203)" This reverts commit 884f648. * Revert "prepare v12 release (#200)" This reverts commit 3bae7fd. * Revert "Refactor root cap (#198)" This reverts commit b30fdc9. * Revert "feat: add entry for plugin marketplace (#199)" This reverts commit 459ce12. * Revert "Upgrade MerkleNFTDistributor::register to v2 (#196)" This reverts commit 40178bb. * Revert "[daospace] Refactor daospace functions name (#195)" This reverts commit 0dd5c68. * Revert "Accept Offer and Accept NFT (#192)" This reverts commit 19b7d1d. * Revert "Fix sign flag for SignedInteger64 zero (#191)" This reverts commit 722a298. * Revert "fix cmp (#190)" This reverts commit fce8707. * Revert "Fix (#189)" This reverts commit 64d754d. * Revert "feat: remove sender of update_plugin (#187)" This reverts commit cb21b0a. * Revert "Custom proposal's quorum_votes for plugin (#184)" This reverts commit 45eb5ca. * Revert "[Feature] Proposal add title and introduction (#183)" This reverts commit 4ebe51b. * Revert "[DAOSpace] Plugin marketplace remove NFT (#186)" This reverts commit f186ec8. * Revert "Migrate Genesis initialize to new DAOSpace (#181)" This reverts commit 57e859e. * Revert "Update GasOracle module" This reverts commit f0270c3. * Revert "Fix prologue gas token error" This reverts commit 3c58061. * Revert "[Feature] Simple map (#182)" This reverts commit daa971f. * Revert "add some function in Compare (#180)" This reverts commit e5a3108. * Revert "fix to_bytes need store (#179)" This reverts commit 31792d4. * Revert "[Feature] Member Grant Offer (#174)" This reverts commit 0234cfc. * Revert "migrate TreasuryWithdrawDaoProposal to DAOSpace TreasuryPlugin (#175)" This reverts commit f44fd34. * Revert "refactor plugin initialize (#176)" This reverts commit e4c7bf8. * Revert "update old links in README (#173)" This reverts commit cb26bbd. * Revert "[Bugfix]Fix ERR_EXPECT_NOT_MEMBER (#172)" This reverts commit dca2274. * Revert "Fix acount.txn_epilogue_v2 incompatible (#168)" This reverts commit ad81d03. * Revert "[Feature] Add dao create test (#167)" This reverts commit dfbf3d7. * Revert "Remove proposal after executed or rejected (#145)" This reverts commit 1e17512. * Revert "EasyGas support (#92)" This reverts commit e142883. * Revert "Reformat code and decrease_member_sbt when unstake (#166)" This reverts commit 25148a4. * Revert "upgrade mpm to 1.12.5 and fix integration tests (#163)" This reverts commit 0fb8810. * Revert "[Feature] DAOSpace add join_member_with_root_cap (#164)" This reverts commit 1518644. * Revert "[Feature] Add ASCII module and TODO: ascii DAO name (#161)" This reverts commit d3eb047. * Revert "[Feature]DAOAccount Todo : add exists_upgrade_plan_cap (#160)" This reverts commit 1fb3b8a. * Revert "fix eventutil (#146)" This reverts commit d2c4f5c. * Revert "[Feature] Make StarcoinDAO inherit Dao's config (#144)" This reverts commit 8675779. * Revert "migrate script to entry function (#142)" This reverts commit 971a1a2. * Revert "[Feature] Multi Offer (#135)" This reverts commit 4ec8c2f. * Revert "add upgrade plan event (#128)" This reverts commit e82c1d3. * Revert "merge upgrade entry v12 and v12_1 (#126)" This reverts commit 47b38ad. * Revert "[Feature] NFTGallery Add Errors Assert (#138)" This reverts commit 61392b0. * Revert "Add event util (#134)" This reverts commit 545f191. * Revert "#131 Add only_new_module (#132) " This reverts commit f1363a3. * Revert "[Feature] DAO incompatible module upgrade test (#133)" This reverts commit 022ca1a. * Revert "update_module_upgrade_strategy support set min_time_limit (#127)" This reverts commit c8c9ba7. * Revert "Daospace support plugin marketplace (#116)" This reverts commit 6cccb73. * Revert "check StakeList existence (#124)" This reverts commit dee9a0b. * Revert "[ Feature ] do deposit when proposal state is DEFEATED (#122)" This reverts commit 3274821. * Revert "[daospace] Remove proposal info and add get function for proposal (#121)" This reverts commit 7b44ee7. * Revert "[integration-test] StarcoinDAO integration-test (#112)" This reverts commit 45f017a. * Revert "add assertion in stake to `StakeToSBTPlugin::stake` while the lock ti… (#117)" This reverts commit 08928d4. * Revert "Add Script function entry (#111)" This reverts commit 4c32fda. * Revert "Fix DAO Pulgin Event (#118)" This reverts commit 3cda388. * Revert "Plugin Event (#97)" This reverts commit 31b9a9c. * Revert "fix SalaryGovPlugin and migrate to test (#115)" This reverts commit 3e95aef. * Revert "[account] Retry when creating delegate account (#110)" This reverts commit 7a38b4b. * Revert "Add upgrade plugin And add StarcoinDAO (#94)" This reverts commit 85418d7. * Revert "able to update DAOExt (#108)" This reverts commit fc7ac4a. * Revert "[Feature] Public Native name_of function (#107)" This reverts commit 7263b0a. * Revert "MintProposalPlugin (#105)" This reverts commit ff2d802. * Revert "add daospace module upgrade test (#98)" This reverts commit 70429e2. * Revert "Add DAO nft image and member image (#96)" This reverts commit 2c89bbc. * Revert "Dao integration test and upgrade mpm (#95)" This reverts commit 82032cc. * Revert "add integration-test for refund_grant (#93)" This reverts commit 52fb86d. * Revert "signature.move add secp256k1_verify function (#86)" This reverts commit 9ea61ce. * Revert "check DAOAccountCap (#89)" This reverts commit 0404a53. * Revert "Add DAOSpace description (#85)" This reverts commit a981f67. * Revert "Remove decrease SBT when unstake item (#81)" This reverts commit d401c37. * Revert "[signature] Fix EVMAddress padding and crop bug (#84)" This reverts commit 41ad861. * Revert "fix dao snapshot deserialize when some option field is empty (#82)" This reverts commit b272a6f. * Revert "Complete DAOSpace (#80)" This reverts commit 98e96e6. * Revert "[dao] Implement DAOSpace (#32)" This reverts commit 0d37c89. * Revert "Update README.md (#68)" This reverts commit d3bb99f. * Revert "Update .gitattributes (#63)" This reverts commit 41ed34b. * Revert "support installing mpm from source (#56)" This reverts commit 3f46c6c. * Revert "[WIP] add Block state root (#39) (#41)" This reverts commit 67027f9. * Revert "Add multiple types of bcs skip and test (#52)" This reverts commit a5dc012. * Revert "upgrade rust toolchain 1.62.0 (#51)" This reverts commit 81c1e51. * Revert "implement Ring module (#44)" This reverts commit c9582a6. * Revert "support starcoin snapshot proof and verify (#45)" This reverts commit 63b05ec. * Revert "add bcs function , byte to basic type (#43)" This reverts commit e39dfeb.
fix Revert daospace (#226) commit msg * Revert "fix stake plugin for compatibility (#218)" This reverts commit e618173. * Revert "add some test_functions (#216)" This reverts commit 87859a9. * Revert "Add WithdrawPlugin (#214)" This reverts commit a66f0f3. * Revert "fix StakeToSBTPlugin install event (#215)" This reverts commit 77a968a. * Revert "add install plugin proposal for TreasuryPlugin (#213)" This reverts commit a98de9e. * Revert "Fix v12 (#210)" This reverts commit bfd8fa6. * Revert "release v12 (#205)" This reverts commit 94be70e. * Revert "Fix some entry function and do some clean (#203)" This reverts commit 884f648. * Revert "prepare v12 release (#200)" This reverts commit 3bae7fd. * Revert "Refactor root cap (#198)" This reverts commit b30fdc9. * Revert "feat: add entry for plugin marketplace (#199)" This reverts commit 459ce12. * Revert "Upgrade MerkleNFTDistributor::register to v2 (#196)" This reverts commit 40178bb. * Revert "[daospace] Refactor daospace functions name (#195)" This reverts commit 0dd5c68. * Revert "Accept Offer and Accept NFT (#192)" This reverts commit 19b7d1d. * Revert "Fix sign flag for SignedInteger64 zero (#191)" This reverts commit 722a298. * Revert "fix cmp (#190)" This reverts commit fce8707. * Revert "Fix (#189)" This reverts commit 64d754d. * Revert "feat: remove sender of update_plugin (#187)" This reverts commit cb21b0a. * Revert "Custom proposal's quorum_votes for plugin (#184)" This reverts commit 45eb5ca. * Revert "[Feature] Proposal add title and introduction (#183)" This reverts commit 4ebe51b. * Revert "[DAOSpace] Plugin marketplace remove NFT (#186)" This reverts commit f186ec8. * Revert "Migrate Genesis initialize to new DAOSpace (#181)" This reverts commit 57e859e. * Revert "Update GasOracle module" This reverts commit f0270c3. * Revert "Fix prologue gas token error" This reverts commit 3c58061. * Revert "[Feature] Simple map (#182)" This reverts commit daa971f. * Revert "add some function in Compare (#180)" This reverts commit e5a3108. * Revert "fix to_bytes need store (#179)" This reverts commit 31792d4. * Revert "[Feature] Member Grant Offer (#174)" This reverts commit 0234cfc. * Revert "migrate TreasuryWithdrawDaoProposal to DAOSpace TreasuryPlugin (#175)" This reverts commit f44fd34. * Revert "refactor plugin initialize (#176)" This reverts commit e4c7bf8. * Revert "update old links in README (#173)" This reverts commit cb26bbd. * Revert "[Bugfix]Fix ERR_EXPECT_NOT_MEMBER (#172)" This reverts commit dca2274. * Revert "Fix acount.txn_epilogue_v2 incompatible (#168)" This reverts commit ad81d03. * Revert "[Feature] Add dao create test (#167)" This reverts commit dfbf3d7. * Revert "Remove proposal after executed or rejected (#145)" This reverts commit 1e17512. * Revert "EasyGas support (#92)" This reverts commit e142883. * Revert "Reformat code and decrease_member_sbt when unstake (#166)" This reverts commit 25148a4. * Revert "upgrade mpm to 1.12.5 and fix integration tests (#163)" This reverts commit 0fb8810. * Revert "[Feature] DAOSpace add join_member_with_root_cap (#164)" This reverts commit 1518644. * Revert "[Feature] Add ASCII module and TODO: ascii DAO name (#161)" This reverts commit d3eb047. * Revert "[Feature]DAOAccount Todo : add exists_upgrade_plan_cap (#160)" This reverts commit 1fb3b8a. * Revert "fix eventutil (#146)" This reverts commit d2c4f5c. * Revert "[Feature] Make StarcoinDAO inherit Dao's config (#144)" This reverts commit 8675779. * Revert "migrate script to entry function (#142)" This reverts commit 971a1a2. * Revert "[Feature] Multi Offer (#135)" This reverts commit 4ec8c2f. * Revert "add upgrade plan event (#128)" This reverts commit e82c1d3. * Revert "merge upgrade entry v12 and v12_1 (#126)" This reverts commit 47b38ad. * Revert "[Feature] NFTGallery Add Errors Assert (#138)" This reverts commit 61392b0. * Revert "Add event util (#134)" This reverts commit 545f191. * Revert "#131 Add only_new_module (#132) " This reverts commit f1363a3. * Revert "[Feature] DAO incompatible module upgrade test (#133)" This reverts commit 022ca1a. * Revert "update_module_upgrade_strategy support set min_time_limit (#127)" This reverts commit c8c9ba7. * Revert "Daospace support plugin marketplace (#116)" This reverts commit 6cccb73. * Revert "check StakeList existence (#124)" This reverts commit dee9a0b. * Revert "[ Feature ] do deposit when proposal state is DEFEATED (#122)" This reverts commit 3274821. * Revert "[daospace] Remove proposal info and add get function for proposal (#121)" This reverts commit 7b44ee7. * Revert "[integration-test] StarcoinDAO integration-test (#112)" This reverts commit 45f017a. * Revert "add assertion in stake to `StakeToSBTPlugin::stake` while the lock ti… (#117)" This reverts commit 08928d4. * Revert "Add Script function entry (#111)" This reverts commit 4c32fda. * Revert "Fix DAO Pulgin Event (#118)" This reverts commit 3cda388. * Revert "Plugin Event (#97)" This reverts commit 31b9a9c. * Revert "fix SalaryGovPlugin and migrate to test (#115)" This reverts commit 3e95aef. * Revert "[account] Retry when creating delegate account (#110)" This reverts commit 7a38b4b. * Revert "Add upgrade plugin And add StarcoinDAO (#94)" This reverts commit 85418d7. * Revert "able to update DAOExt (#108)" This reverts commit fc7ac4a. * Revert "[Feature] Public Native name_of function (#107)" This reverts commit 7263b0a. * Revert "MintProposalPlugin (#105)" This reverts commit ff2d802. * Revert "add daospace module upgrade test (#98)" This reverts commit 70429e2. * Revert "Add DAO nft image and member image (#96)" This reverts commit 2c89bbc. * Revert "Dao integration test and upgrade mpm (#95)" This reverts commit 82032cc. * Revert "add integration-test for refund_grant (#93)" This reverts commit 52fb86d. * Revert "signature.move add secp256k1_verify function (#86)" This reverts commit 9ea61ce. * Revert "check DAOAccountCap (#89)" This reverts commit 0404a53. * Revert "Add DAOSpace description (#85)" This reverts commit a981f67. * Revert "Remove decrease SBT when unstake item (#81)" This reverts commit d401c37. * Revert "[signature] Fix EVMAddress padding and crop bug (#84)" This reverts commit 41ad861. * Revert "fix dao snapshot deserialize when some option field is empty (#82)" This reverts commit b272a6f. * Revert "Complete DAOSpace (#80)" This reverts commit 98e96e6. * Revert "[dao] Implement DAOSpace (#32)" This reverts commit 0d37c89. * Revert "Update README.md (#68)" This reverts commit d3bb99f. * Revert "Update .gitattributes (#63)" This reverts commit 41ed34b. * Revert "support installing mpm from source (#56)" This reverts commit 3f46c6c. * Revert "[WIP] add Block state root (#39) (#41)" This reverts commit 67027f9. * Revert "Add multiple types of bcs skip and test (#52)" This reverts commit a5dc012. * Revert "upgrade rust toolchain 1.62.0 (#51)" This reverts commit 81c1e51. * Revert "implement Ring module (#44)" This reverts commit c9582a6. * Revert "support starcoin snapshot proof and verify (#45)" This reverts commit 63b05ec. * Revert "add bcs function , byte to basic type (#43)" This reverts commit e39dfeb.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolve #11
What is the new behavior?
Other information