Fix the problem that some unstake methods in the plugin `stake_to_sbt… #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` do not check the identity of the caller
jolestar
reviewed
Nov 11, 2022
| } | ||
|
|
||
| /// Called by script | ||
| public(script) fun unstake_item_entry<DAOT: store, TokenT: store>(_member: address, _id: u64) { |
There was a problem hiding this comment.
v12 版本没有 release，可以直接改，不用考虑兼容性。
There was a problem hiding this comment.
不过用 unstake_item_by_id_entry 可能更合适一些
|
|
||
| /// Unstake all staking items from member address, | ||
| /// No care whether the user is member or not | ||
| public fun unstake_all<DAOT: store, TokenT: store>(_member: address) { |
| /// Unstake from staking | ||
| public fun unstake_by_id<DAOT: store, TokenT: store>(member: address, id: u64) acquires StakeList { | ||
| fun unstake_item_by_id<DAOT: store, TokenT: store>(member: address, id: u64) acquires StakeList { |
There was a problem hiding this comment.
是不是把 unstake_item_by_id 的 member address 改成 &signer, 还是保留 public, 这样可以方便别的 module 调用。
7 tasks
|
include in #203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…` do not check the identity of the caller
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information