[signature] Fix EVMAddress padding and crop bug

build/StarcoinFramework/BuildInfo.yaml

@@ -300,7 +300,7 @@ compiled_package_info:
     ? address: "0x00000000000000000000000000000001"
       name: YieldFarmingV2
     : StarcoinFramework
-  source_digest: 909CE74C85980EFA85EC499713FA015307F578F64A8BB1B25942B9F63440DBA4
+  source_digest: 6F307AEE1142B5C572B5235CABAE88249D55900EC0E687DD762DF015D0591BB1
   build_flags:
     dev_mode: false
     test_mode: false

sources/Signature.move

@@ -26,6 +26,14 @@ module Signature {
     spec module {
         pragma intrinsic = true;
     }
+
+    #[test]
+    fun test_ecrecover_invalid(){
+        let h = b"00";
+        let s = b"00";
+        let addr = ecrecover(h, s);
+        assert!(Option::is_none(&addr), 1001);
+    }
 }
 
 module EVMAddress{
@@ -52,6 +60,7 @@ module EVMAddress{
             let i = 0;
             while (i < EVM_ADDR_LENGTH) {
                 Vector::push_back(&mut new_bytes, *Vector::borrow(&bytes, i));
+                i = i + 1;
             };
             new_bytes
         }else if (len == EVM_ADDR_LENGTH){
@@ -62,6 +71,7 @@ module EVMAddress{
             while (i < EVM_ADDR_LENGTH - len) {
                 // pad zero to address
                 Vector::push_back(&mut new_bytes, 0);
+                i = i + 1;
             };
             Vector::append(&mut new_bytes, bytes);
             new_bytes
@@ -96,5 +106,19 @@ module EVMAddress{
         pragma verify = false;
         //TODO
     }
+
+    #[test]
+    fun test_evm_address_padding(){
+        let addr1 = new(x"00");
+        let addr2 = new(x"0000");
+        assert!(&addr1.bytes == &addr2.bytes, 1001);
+    }
+
+    #[test]
+    fun test_evm_address_crop(){
+        let addr1 = new(x"01234567890123456789012345678901234567891111");
+        let addr2 = new(x"01234567890123456789012345678901234567892222");
+        assert!(&addr1.bytes == &addr2.bytes, 1001);
+    }
 }
 }