Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev]Refactoring and following the rust coding guidelines #3336

Open
jolestar opened this issue Apr 12, 2022 · 0 comments
Open

[Dev]Refactoring and following the rust coding guidelines #3336

jolestar opened this issue Apr 12, 2022 · 0 comments
Labels
enhancement Enhancement good first issue Good for newcomers help wanted Extra attention is needed

Comments

@jolestar
Copy link
Member

jolestar commented Apr 12, 2022 •
edited
Loading

Refactoring and following the rust coding guidelines

If you find something in the starcoin code that doesn't follow the coding guidelines, you can just submit a PR to fix it, but be careful to maintain compatibility.

It's a long-term task and we can't expect to complete it all at once. So feel free to break it down into smaller PR to complete.

ref: Rust-Coding-Guidelines/rust-coding-guidelines-zh#107
@jolestar jolestar added enhancement Enhancement good first issue Good for newcomers help wanted Extra attention is needed labels Apr 12, 2022
@liby liby mentioned this issue Apr 12, 2022
Merged
7 tasks
jolestar pushed a commit that referenced this issue Apr 13, 2022
@liby
[refactor] Add prefix G_ to global static variables (#3336) (#3338)
5e34b4e
@liby liby mentioned this issue Apr 13, 2022
Merged
7 tasks
jolestar pushed a commit that referenced this issue Apr 15, 2022
@liby
[refactor] Improve variable naming convention (#3342)
7fc2db0 
* [refactor] Remove `bytes` from variable naming (#3336)

* [refactor] Remove `str` from variable naming (#3336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jolestar