Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd] unify module upgrade v1 and v2 command and update document #2511

Merged
merged 3 commits into from
May 21, 2021

Conversation

guangyuz
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #2511 (0e6edf1) into master (249834e) will decrease coverage by 0.05%.
The diff coverage is 23.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2511      +/-   ##
==========================================
- Coverage   33.27%   33.23%   -0.04%     
==========================================
  Files         498      498              
  Lines       43195    43199       +4     
  Branches    19566    19564       -2     
==========================================
- Hits        14368    14351      -17     
- Misses      14081    14129      +48     
+ Partials    14746    14719      -27     
Flag Coverage Δ
unittests 33.23% <23.26%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/lib.rs 100.00% <ø> (ø)
config/src/lib.rs 26.34% <0.00%> (-0.72%) ⬇️
vm/stdlib/src/compat.rs 0.00% <ø> (ø)
vm/types/src/on_chain_config/version.rs 9.10% <ø> (ø)
vm/transaction-builder/src/lib.rs 21.52% <22.23%> (+0.84%) ⬆️
vm/types/src/genesis_config.rs 51.00% <33.34%> (-1.04%) ⬇️
cmd/starcoin/src/dev/tests.rs 12.88% <50.00%> (-3.65%) ⬇️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.84%) ⬇️
vm/types/src/transaction/error.rs 3.93% <0.00%> (-15.68%) ⬇️
cmd/starcoin/src/cli_state.rs 47.37% <0.00%> (-5.26%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 249834e...0e6edf1. Read the comment docs.

@github-actions
Copy link

Benchmark for 3a7cb1c

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.7±0.18ms 2.7±0.18ms 0.00%
block_apply/block_apply_10 497.3±11.22ms 502.0±5.29ms -0.94%
block_apply/block_apply_1000 51.2±0.71s 50.8±0.84s +0.79%
get_with_proof/db_store 38.2±0.38µs 38.2±0.33µs 0.00%
get_with_proof/mem_store 31.4±0.21µs 31.5±0.21µs -0.32%
put_and_commit/db_store/1 1812.8±167.49µs 1768.9±176.82µs +2.48%
put_and_commit/db_store/10 2.8±0.70ms 2.8±0.56ms 0.00%
put_and_commit/db_store/100 10.0±1.76ms 10.1±1.80ms -0.99%
put_and_commit/db_store/5 2.2±0.25ms 2.2±0.21ms 0.00%
put_and_commit/db_store/50 6.2±1.17ms 6.1±1.10ms +1.64%
put_and_commit/mem_store/1 63.1±5.58µs 63.0±5.52µs +0.16%
put_and_commit/mem_store/10 583.9±47.89µs 586.6±48.28µs -0.46%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.82ms 0.00%
put_and_commit/mem_store/5 296.1±24.52µs 295.5±24.40µs +0.20%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.07ms 3.0±0.05ms -3.33%
query_block/query_block_in(10)_times(1000) 29.3±0.86ms 29.7±0.39ms -1.35%
query_block/query_block_in(10)_times(10000) 289.9±6.75ms 292.5±2.70ms -0.89%
query_block/query_block_in(1000)_times(100) 911.3±7.15µs 928.3±4.56µs -1.83%
query_block/query_block_in(1000)_times(1000) 9.0±0.06ms 9.1±0.04ms -1.10%
query_block/query_block_in(1000)_times(10000) 91.8±0.53ms 90.9±0.51ms +0.99%
storage_transaction 67.6±4.80ms 65.1±4.80ms +3.84%
vm/transaction_execution/1 332.6±1.19ms 334.5±5.07ms -0.57%
vm/transaction_execution/10 111.6±0.63ms 112.2±0.33ms -0.53%
vm/transaction_execution/20 105.8±1.85ms 105.3±0.38ms +0.47%
vm/transaction_execution/5 133.6±0.45ms 135.6±3.49ms -1.47%
vm/transaction_execution/50 121.0±1.38ms 120.6±0.49ms +0.33%

@guangyuz guangyuz marked this pull request as draft May 17, 2021 06:14
@guangyuz guangyuz marked this pull request as ready for review May 19, 2021 07:16
@github-actions
Copy link

Benchmark for b9be042

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.4±0.36ms 2.4±0.42ms 0.00%
block_apply/block_apply_10 470.2±17.25ms 459.5±13.40ms +2.33%
block_apply/block_apply_1000 46.6±0.40s 46.2±0.50s +0.87%
get_with_proof/db_store 38.6±0.51µs 38.3±0.29µs +0.78%
get_with_proof/mem_store 31.8±0.23µs 31.8±0.50µs 0.00%
put_and_commit/db_store/1 1469.4±118.48µs 1478.8±95.27µs -0.64%
put_and_commit/db_store/10 2.5±0.52ms 2.5±0.43ms 0.00%
put_and_commit/db_store/100 9.6±1.05ms 9.7±1.11ms -1.03%
put_and_commit/db_store/5 2.1±0.22ms 2.2±0.50ms -4.55%
put_and_commit/db_store/50 5.8±0.94ms 5.8±0.97ms 0.00%
put_and_commit/mem_store/1 63.0±5.55µs 62.7±5.61µs +0.48%
put_and_commit/mem_store/10 588.1±47.68µs 585.6±46.69µs +0.43%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.81ms 0.00%
put_and_commit/mem_store/5 297.7±24.98µs 297.8±25.51µs -0.03%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.09ms 2.9±0.07ms 0.00%
query_block/query_block_in(10)_times(1000) 29.3±0.56ms 29.7±0.57ms -1.35%
query_block/query_block_in(10)_times(10000) 293.9±4.80ms 294.0±7.25ms -0.03%
query_block/query_block_in(1000)_times(100) 914.7±4.95µs 909.1±6.94µs +0.62%
query_block/query_block_in(1000)_times(1000) 9.2±0.07ms 9.0±0.03ms +2.22%
query_block/query_block_in(1000)_times(10000) 92.0±2.05ms 90.9±0.36ms +1.21%
storage_transaction 55.3±5.75ms 54.5±4.91ms +1.47%
vm/transaction_execution/1 337.8±5.37ms 334.4±1.26ms +1.02%
vm/transaction_execution/10 112.6±0.67ms 111.9±0.38ms +0.63%
vm/transaction_execution/20 105.8±0.39ms 105.4±0.74ms +0.38%
vm/transaction_execution/5 135.9±1.59ms 134.1±0.86ms +1.34%
vm/transaction_execution/50 121.5±0.60ms 121.1±1.59ms +0.33%

@guangyuz guangyuz merged commit 614ea16 into master May 21, 2021
@guangyuz guangyuz deleted the upgrade_cmd branch May 21, 2021 08:22
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
…rcoinorg#2511)


* [cmd] unify module upgrade v1 and v2 command

* [doc] update cli document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants