-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account cli receipt_identifier improvement #2521
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jolestar
commented
May 20, 2021
•
edited
Loading
edited
- Move dev derive-account-address cmd to account derive-account-address.
- Account transfer command's argument receiver accepts both address and receipt_identifier format.
- Add command to encode or decode receipt_identifier
- Add more documents for receipt_identifier
Codecov Report
@@ Coverage Diff @@
## master #2521 +/- ##
==========================================
+ Coverage 33.09% 33.11% +0.03%
==========================================
Files 498 498
Lines 43202 43222 +20
Branches 19567 19577 +10
==========================================
+ Hits 14293 14309 +16
Misses 14235 14235
- Partials 14674 14678 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Benchmark for baf273bClick to view benchmark
|
Benchmark for 14b2684Click to view benchmark
|
Benchmark for 28773cdClick to view benchmark
|
Benchmark for 5a8bf8dClick to view benchmark
|
nanne007
approved these changes
May 21, 2021
Benchmark for cbf5bbcClick to view benchmark
|
…ess and receipt_identifier format.
…eceipt_identifier.
Benchmark for 66547d6Click to view benchmark
|
naughtyvenom
pushed a commit
to naughtyvenom/starcoin
that referenced
this pull request
Jul 19, 2021
* [cli] Move dev derive-account-address cmd to account derive-account-address * [cli] Account transfer command's argument `receiver` accept both address and receipt_identifier format. * [cli] Add account receipt-identifier command for encode or decode receipt_identifier * [document] Use receipt_identifier in document, and add document for receipt_identifier. * [cli] account show support receipt_identifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.