Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account cli receipt_identifier improvement #2521

Merged
merged 5 commits into from
May 21, 2021
Merged

Account cli receipt_identifier improvement #2521

merged 5 commits into from
May 21, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented May 20, 2021 •
edited
Loading

  1. Move dev derive-account-address cmd to account derive-account-address.
  2. Account transfer command's argument receiver accepts both address and receipt_identifier format.
  3. Add command to encode or decode receipt_identifier
  4. Add more documents for receipt_identifier

@jolestar jolestar requested review from ssyuan and nanne007 May 20, 2021 08:39
@codecov
Copy link

codecov bot commented May 20, 2021 •
edited
Loading

Codecov Report

Merging #2521 (c939e00) into master (d483f55) will increase coverage by 0.03%.
The diff coverage is 33.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2521      +/-   ##
==========================================
+ Coverage   33.09%   33.11%   +0.03%     
==========================================
  Files         498      498              
  Lines       43202    43222      +20     
  Branches    19567    19577      +10     
==========================================
+ Hits        14293    14309      +16     
  Misses      14235    14235              
- Partials    14674    14678       +4
Flag Coverage Δ
unittests 33.11% <33.34%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/lib.rs 100.00% <ø> (ø)
types/src/receipt_identifier.rs 34.93% <23.53%> (-1.07%) ⬇️
account/src/account_manager.rs 41.88% <33.34%> (-0.89%) ⬇️
account/api/src/types.rs 70.00% <57.15%> (+15.84%) ⬆️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.84%) ⬇️
vm/types/src/transaction/error.rs 3.93% <0.00%> (-15.68%) ⬇️
sync/src/block_connector/test_write_block_chain.rs 17.65% <0.00%> (-7.56%) ⬇️
cmd/starcoin/src/cli_state.rs 47.37% <0.00%> (-5.26%) ⬇️
cmd/starcoin/src/dev/tests.rs 11.93% <0.00%> (-4.61%) ⬇️
rpc/api/src/types.rs 15.58% <0.00%> (-1.01%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d483f55...c939e00. Read the comment docs.

@github-actions
Copy link

Benchmark for baf273b

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 3.1±0.25ms 2.9±0.14ms +6.90%
block_apply/block_apply_10 533.6±13.22ms 531.6±17.82ms +0.38%
block_apply/block_apply_1000 54.4±0.60s 53.9±0.38s +0.93%
get_with_proof/db_store 38.8±0.34µs 38.1±0.32µs +1.84%
get_with_proof/mem_store 31.9±0.25µs 31.6±0.26µs +0.95%
put_and_commit/db_store/1 2.2±0.24ms 2.0±0.22ms +10.00%
put_and_commit/db_store/10 3.1±0.46ms 3.1±0.59ms 0.00%
put_and_commit/db_store/100 10.1±1.10ms 10.0±1.05ms +1.00%
put_and_commit/db_store/5 2.6±0.21ms 2.5±0.19ms +4.00%
put_and_commit/db_store/50 6.3±0.84ms 6.3±0.66ms 0.00%
put_and_commit/mem_store/1 63.1±5.56µs 63.1±5.53µs 0.00%
put_and_commit/mem_store/10 584.7±46.08µs 590.6±45.27µs -1.00%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.81ms 0.00%
put_and_commit/mem_store/5 296.5±23.79µs 296.4±23.80µs +0.03%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.05ms 2.9±0.07ms 0.00%
query_block/query_block_in(10)_times(1000) 29.4±0.60ms 29.8±0.55ms -1.34%
query_block/query_block_in(10)_times(10000) 293.8±3.99ms 292.7±5.17ms +0.38%
query_block/query_block_in(1000)_times(100) 954.1±10.45µs 910.9±3.12µs +4.74%
query_block/query_block_in(1000)_times(1000) 9.5±0.04ms 9.1±0.06ms +4.40%
query_block/query_block_in(1000)_times(10000) 92.7±0.59ms 90.6±0.38ms +2.32%
storage_transaction 79.2±6.92ms 72.7±3.79ms +8.94%
vm/transaction_execution/1 335.3±3.48ms 333.3±1.02ms +0.60%
vm/transaction_execution/10 112.3±0.52ms 112.1±0.74ms +0.18%
vm/transaction_execution/20 105.7±0.42ms 105.9±1.84ms -0.19%
vm/transaction_execution/5 134.3±0.31ms 134.3±1.48ms 0.00%
vm/transaction_execution/50 121.6±1.19ms 121.5±2.08ms +0.08%

@github-actions
Copy link

Benchmark for 14b2684

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 3.1±0.18ms 2.9±0.36ms +6.90%
block_apply/block_apply_10 514.5±7.46ms 562.1±23.63ms -8.47%
block_apply/block_apply_1000 52.9±0.57s 54.3±0.65s -2.58%
get_with_proof/db_store 38.3±0.30µs 38.8±0.35µs -1.29%
get_with_proof/mem_store 31.6±0.24µs 31.9±0.24µs -0.94%
put_and_commit/db_store/1 1989.2±137.88µs 1930.8±121.48µs +3.02%
put_and_commit/db_store/10 3.1±0.54ms 3.0±0.22ms +3.33%
put_and_commit/db_store/100 10.5±2.37ms 10.3±1.63ms +1.94%
put_and_commit/db_store/5 2.5±0.21ms 2.5±0.27ms 0.00%
put_and_commit/db_store/50 6.6±1.35ms 6.3±1.00ms +4.76%
put_and_commit/mem_store/1 63.4±5.50µs 62.7±5.48µs +1.12%
put_and_commit/mem_store/10 587.7±46.17µs 581.4±45.81µs +1.08%
put_and_commit/mem_store/100 5.7±0.82ms 5.7±0.81ms 0.00%
put_and_commit/mem_store/5 296.3±24.13µs 296.4±23.95µs -0.03%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.0±0.07ms 2.9±0.08ms +3.45%
query_block/query_block_in(10)_times(1000) 28.9±0.83ms 29.5±0.52ms -2.03%
query_block/query_block_in(10)_times(10000) 295.7±3.36ms 292.3±4.33ms +1.16%
query_block/query_block_in(1000)_times(100) 938.4±22.27µs 923.2±4.85µs +1.65%
query_block/query_block_in(1000)_times(1000) 9.3±0.06ms 9.2±0.05ms +1.09%
query_block/query_block_in(1000)_times(10000) 93.3±0.50ms 91.4±0.35ms +2.08%
storage_transaction 79.4±5.58ms 74.8±6.40ms +6.15%
vm/transaction_execution/1 334.1±2.55ms 332.3±0.87ms +0.54%
vm/transaction_execution/10 111.6±0.34ms 111.7±0.71ms -0.09%
vm/transaction_execution/20 104.9±0.46ms 105.0±0.20ms -0.10%
vm/transaction_execution/5 133.5±0.38ms 134.4±1.36ms -0.67%
vm/transaction_execution/50 120.7±0.44ms 120.7±0.29ms 0.00%

@github-actions
Copy link

Benchmark for 28773cd

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.5±0.11ms 2.5±0.22ms 0.00%
block_apply/block_apply_10 461.2±6.74ms 461.1±12.69ms +0.02%
block_apply/block_apply_1000 47.5±0.52s 47.3±0.36s +0.42%
get_with_proof/db_store 38.1±0.35µs 38.6±0.36µs -1.30%
get_with_proof/mem_store 32.1±0.70µs 31.5±0.27µs +1.90%
put_and_commit/db_store/1 1544.8±110.89µs 1586.3±143.56µs -2.62%
put_and_commit/db_store/10 2.6±0.47ms 2.6±0.45ms 0.00%
put_and_commit/db_store/100 9.7±1.30ms 9.8±1.14ms -1.02%
put_and_commit/db_store/5 2.0±0.20ms 2.1±0.20ms -4.76%
put_and_commit/db_store/50 5.9±0.83ms 6.0±0.93ms -1.67%
put_and_commit/mem_store/1 63.4±5.48µs 62.9±5.52µs +0.79%
put_and_commit/mem_store/10 588.5±46.39µs 583.7±45.76µs +0.82%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.80ms 0.00%
put_and_commit/mem_store/5 298.7±24.89µs 297.8±25.18µs +0.30%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.07ms 2.9±0.07ms 0.00%
query_block/query_block_in(10)_times(1000) 29.6±1.16ms 29.1±0.45ms +1.72%
query_block/query_block_in(10)_times(10000) 292.2±5.60ms 293.0±7.48ms -0.27%
query_block/query_block_in(1000)_times(100) 922.5±4.15µs 917.2±2.89µs +0.58%
query_block/query_block_in(1000)_times(1000) 9.2±0.04ms 9.1±0.04ms +1.10%
query_block/query_block_in(1000)_times(10000) 91.6±0.50ms 91.0±0.35ms +0.66%
storage_transaction 58.5±4.33ms 62.5±6.23ms -6.40%
vm/transaction_execution/1 334.7±0.78ms 331.9±1.16ms +0.84%
vm/transaction_execution/10 112.0±0.26ms 111.8±1.33ms +0.18%
vm/transaction_execution/20 105.8±1.21ms 104.9±0.66ms +0.86%
vm/transaction_execution/5 134.5±0.55ms 134.0±0.83ms +0.37%
vm/transaction_execution/50 121.0±0.45ms 120.5±0.32ms +0.41%

@github-actions
Copy link

Benchmark for 5a8bf8d

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.8±0.12ms 2.8±0.16ms 0.00%
block_apply/block_apply_10 481.7±9.65ms 503.1±10.19ms -4.25%
block_apply/block_apply_1000 49.8±1.05s 49.6±0.79s +0.40%
get_with_proof/db_store 38.0±0.60µs 38.1±0.44µs -0.26%
get_with_proof/mem_store 31.4±0.24µs 31.4±0.59µs 0.00%
put_and_commit/db_store/1 1689.1±116.59µs 1643.9±155.85µs +2.75%
put_and_commit/db_store/10 2.9±0.39ms 2.8±0.37ms +3.57%
put_and_commit/db_store/100 9.9±0.95ms 10.0±1.03ms -1.00%
put_and_commit/db_store/5 2.2±0.12ms 2.3±0.17ms -4.35%
put_and_commit/db_store/50 6.1±0.83ms 6.1±0.75ms 0.00%
put_and_commit/mem_store/1 62.8±5.58µs 62.9±5.55µs -0.16%
put_and_commit/mem_store/10 584.5±45.81µs 587.4±49.06µs -0.49%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.80ms 0.00%
put_and_commit/mem_store/5 294.7±23.73µs 295.3±24.01µs -0.20%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.0±0.04ms 2.9±0.04ms +3.45%
query_block/query_block_in(10)_times(1000) 29.5±0.37ms 29.4±0.40ms +0.34%
query_block/query_block_in(10)_times(10000) 291.7±5.72ms 293.2±5.90ms -0.51%
query_block/query_block_in(1000)_times(100) 904.0±6.55µs 905.8±4.47µs -0.20%
query_block/query_block_in(1000)_times(1000) 9.2±0.04ms 9.1±0.07ms +1.10%
query_block/query_block_in(1000)_times(10000) 90.6±0.69ms 91.0±0.59ms -0.44%
storage_transaction 67.3±5.37ms 69.4±5.15ms -3.03%
vm/transaction_execution/1 334.8±2.05ms 335.3±4.08ms -0.15%
vm/transaction_execution/10 112.0±0.37ms 112.4±0.19ms -0.36%
vm/transaction_execution/20 105.6±0.76ms 105.8±1.31ms -0.19%
vm/transaction_execution/5 134.4±0.95ms 134.5±0.46ms -0.07%
vm/transaction_execution/50 121.0±0.68ms 121.2±0.39ms -0.17%

@github-actions
Copy link

Benchmark for cbf5bbc

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.9±0.59ms 2.8±0.14ms +3.57%
block_apply/block_apply_10 549.4±15.59ms 527.3±11.33ms +4.19%
block_apply/block_apply_1000 54.2±1.07s 54.1±1.01s +0.18%
get_with_proof/db_store 38.1±0.34µs 38.3±0.54µs -0.52%
get_with_proof/mem_store 31.6±0.39µs 31.5±0.87µs +0.32%
put_and_commit/db_store/1 1951.9±102.26µs 1964.2±61.30µs -0.63%
put_and_commit/db_store/10 3.1±0.39ms 2.9±0.34ms +6.90%
put_and_commit/db_store/100 10.0±0.90ms 10.0±0.89ms 0.00%
put_and_commit/db_store/5 2.6±0.16ms 2.7±0.21ms -3.70%
put_and_commit/db_store/50 6.1±0.69ms 6.2±0.73ms -1.61%
put_and_commit/mem_store/1 63.5±5.78µs 63.0±5.75µs +0.79%
put_and_commit/mem_store/10 587.3±47.72µs 587.8±47.76µs -0.09%
put_and_commit/mem_store/100 5.7±0.84ms 5.8±0.84ms -1.72%
put_and_commit/mem_store/5 295.5±25.44µs 297.2±24.90µs -0.57%
put_and_commit/mem_store/50 2.9±0.19ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.05ms 2.9±0.06ms 0.00%
query_block/query_block_in(10)_times(1000) 29.5±0.50ms 29.5±0.60ms 0.00%
query_block/query_block_in(10)_times(10000) 292.9±8.56ms 289.4±5.61ms +1.21%
query_block/query_block_in(1000)_times(100) 914.6±6.66µs 923.5±6.70µs -0.96%
query_block/query_block_in(1000)_times(1000) 9.2±0.08ms 9.2±0.05ms 0.00%
query_block/query_block_in(1000)_times(10000) 91.2±0.35ms 92.2±0.87ms -1.08%
storage_transaction 69.5±4.75ms 68.5±4.48ms +1.46%
vm/transaction_execution/1 332.9±1.32ms 332.9±2.22ms 0.00%
vm/transaction_execution/10 111.6±0.78ms 112.0±0.61ms -0.36%
vm/transaction_execution/20 105.1±0.67ms 104.7±0.17ms +0.38%
vm/transaction_execution/5 133.8±0.91ms 133.9±1.10ms -0.07%
vm/transaction_execution/50 120.6±0.97ms 120.4±0.61ms +0.17%

@github-actions
Copy link

Benchmark for 66547d6

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.3±0.27ms 2.3±0.29ms 0.00%
block_apply/block_apply_10 423.7±5.45ms 431.4±8.31ms -1.78%
block_apply/block_apply_1000 43.5±0.30s 43.5±0.36s 0.00%
get_with_proof/db_store 38.2±0.23µs 38.4±0.35µs -0.52%
get_with_proof/mem_store 31.4±0.29µs 31.4±0.28µs 0.00%
put_and_commit/db_store/1 1279.8±119.28µs 1269.3±60.24µs +0.83%
put_and_commit/db_store/10 2.4±0.34ms 2.4±0.37ms 0.00%
put_and_commit/db_store/100 9.3±0.59ms 9.3±0.56ms 0.00%
put_and_commit/db_store/5 1912.6±141.31µs 1934.6±148.26µs -1.14%
put_and_commit/db_store/50 5.6±0.63ms 5.5±0.57ms +1.82%
put_and_commit/mem_store/1 63.2±5.58µs 63.0±5.61µs +0.32%
put_and_commit/mem_store/10 582.1±47.83µs 585.0±45.92µs -0.50%
put_and_commit/mem_store/100 5.7±0.82ms 5.7±0.89ms 0.00%
put_and_commit/mem_store/5 295.7±24.54µs 296.3±26.68µs -0.20%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.06ms 2.9±0.03ms 0.00%
query_block/query_block_in(10)_times(1000) 29.3±0.89ms 29.5±0.54ms -0.68%
query_block/query_block_in(10)_times(10000) 293.4±6.49ms 289.6±4.19ms +1.31%
query_block/query_block_in(1000)_times(100) 913.9±3.78µs 925.6±6.14µs -1.26%
query_block/query_block_in(1000)_times(1000) 9.1±0.08ms 9.2±0.04ms -1.09%
query_block/query_block_in(1000)_times(10000) 91.1±0.40ms 92.7±0.53ms -1.73%
storage_transaction 50.9±3.95ms 49.2±3.93ms +3.46%
vm/transaction_execution/1 331.8±0.71ms 331.9±1.05ms -0.03%
vm/transaction_execution/10 111.6±0.39ms 111.7±0.95ms -0.09%
vm/transaction_execution/20 104.9±0.39ms 105.1±0.81ms -0.19%
vm/transaction_execution/5 133.5±0.35ms 133.8±1.09ms -0.22%
vm/transaction_execution/50 120.3±0.34ms 120.3±0.23ms 0.00%

@jolestar jolestar requested a review from timyangnet May 21, 2021 05:40
@jolestar jolestar merged commit 0594029 into master May 21, 2021
@jolestar jolestar deleted the account_cli branch May 21, 2021 05:41
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
@jolestar @naughtyvenom
Account cli receipt_identifier improvement (starcoinorg#2521)
3ae0163 
* [cli] Move dev derive-account-address cmd to account derive-account-address

* [cli] Account transfer command's argument `receiver` accept both address and receipt_identifier format.

* [cli] Add account receipt-identifier command for encode or decode receipt_identifier

* [document] Use receipt_identifier in document, and add document for receipt_identifier.

* [cli] account show support receipt_identifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanne007 nanne007 nanne007 approved these changes

@ssyuan ssyuan Awaiting requested review from ssyuan

@tiangong3624749 tiangong3624749 Awaiting requested review from tiangong3624749

@timyangnet timyangnet Awaiting requested review from timyangnet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jolestar @nanne007