Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer: handle vm status #2526

Merged
merged 3 commits into from
May 25, 2021
Merged

indexer: handle vm status #2526

merged 3 commits into from
May 25, 2021

Conversation

nanne007
Copy link
Member

No description provided.

@nanne007 nanne007 requested a review from ssyuan May 22, 2021 00:59
@codecov
Copy link

codecov bot commented May 22, 2021

Codecov Report

Merging #2526 (8a8f58c) into master (614ea16) will increase coverage by 0.30%.
The diff coverage is 51.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2526      +/-   ##
==========================================
+ Coverage   32.93%   33.23%   +0.30%     
==========================================
  Files         498      498              
  Lines       43219    43250      +31     
  Branches    19574    19582       +8     
==========================================
+ Hits        14230    14369     +139     
+ Misses      14383    14150     -233     
- Partials    14606    14731     +125     
Flag Coverage Δ
unittests 33.23% <51.62%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/indexer/src/es_sinker.rs 0.00% <ø> (ø)
cmd/indexer/src/lib.rs 53.13% <51.62%> (-46.87%) ⬇️
commons/timeout-join-handler/src/lib.rs 40.43% <0.00%> (-2.12%) ⬇️
sync/src/block_connector/test_illegal_block.rs 13.72% <0.00%> (-1.91%) ⬇️
network-p2p/src/request_responses.rs 30.96% <0.00%> (-1.91%) ⬇️
network/src/service_ref.rs 37.34% <0.00%> (-1.33%) ⬇️
...ync/src/block_connector/block_connector_service.rs 32.19% <0.00%> (-1.14%) ⬇️
block-relayer/src/block_relayer.rs 25.61% <0.00%> (-0.60%) ⬇️
commons/service-registry/src/service_registry.rs 42.06% <0.00%> (-0.58%) ⬇️
network-p2p/src/service.rs 28.58% <0.00%> (-0.44%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 614ea16...8a8f58c. Read the comment docs.

@github-actions
Copy link

Benchmark for 086dcee

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.7±0.19ms 2.6±0.61ms +3.85%
block_apply/block_apply_10 459.0±4.21ms 483.2±11.66ms -5.01%
block_apply/block_apply_1000 47.6±0.78s 48.8±1.02s -2.46%
get_with_proof/db_store 38.1±0.33µs 38.2±0.48µs -0.26%
get_with_proof/mem_store 31.8±0.29µs 31.3±0.29µs +1.60%
put_and_commit/db_store/1 1502.0±61.40µs 1714.4±112.88µs -12.39%
put_and_commit/db_store/10 2.6±0.30ms 2.6±0.11ms 0.00%
put_and_commit/db_store/100 9.7±1.11ms 9.6±0.94ms +1.04%
put_and_commit/db_store/5 2.1±0.17ms 2.1±0.20ms 0.00%
put_and_commit/db_store/50 5.9±0.71ms 5.9±0.68ms 0.00%
put_and_commit/mem_store/1 62.8±5.61µs 62.6±5.63µs +0.32%
put_and_commit/mem_store/10 582.5±46.38µs 586.0±47.99µs -0.60%
put_and_commit/mem_store/100 5.7±0.83ms 5.7±0.81ms 0.00%
put_and_commit/mem_store/5 295.8±24.04µs 294.6±23.81µs +0.41%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.06ms 2.9±0.06ms 0.00%
query_block/query_block_in(10)_times(1000) 29.7±0.61ms 29.3±0.84ms +1.37%
query_block/query_block_in(10)_times(10000) 295.3±5.85ms 295.0±6.41ms +0.10%
query_block/query_block_in(1000)_times(100) 924.9±4.07µs 935.2±5.10µs -1.10%
query_block/query_block_in(1000)_times(1000) 9.3±0.06ms 9.2±0.06ms +1.09%
query_block/query_block_in(1000)_times(10000) 93.4±0.58ms 93.4±0.47ms 0.00%
storage_transaction 64.5±4.71ms 63.7±4.95ms +1.26%
vm/transaction_execution/1 332.6±0.79ms 332.7±0.81ms -0.03%
vm/transaction_execution/10 111.5±0.35ms 112.6±0.99ms -0.98%
vm/transaction_execution/20 105.2±0.97ms 105.2±0.32ms 0.00%
vm/transaction_execution/5 134.4±2.28ms 134.3±0.97ms +0.07%
vm/transaction_execution/50 121.4±1.46ms 121.0±0.41ms +0.33%

@github-actions
Copy link

Benchmark for e0e66f7

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.3±0.17ms 2.3±0.15ms 0.00%
block_apply/block_apply_10 447.4±17.15ms 432.0±10.09ms +3.56%
block_apply/block_apply_1000 44.1±0.52s 43.7±0.35s +0.92%
get_with_proof/db_store 39.4±0.38µs 38.3±0.43µs +2.87%
get_with_proof/mem_store 31.9±0.22µs 31.4±0.30µs +1.59%
put_and_commit/db_store/1 1343.9±189.97µs 1277.2±92.21µs +5.22%
put_and_commit/db_store/10 2.4±0.43ms 2.4±0.40ms 0.00%
put_and_commit/db_store/100 9.5±0.76ms 9.4±0.73ms +1.06%
put_and_commit/db_store/5 1961.2±189.76µs 1973.3±228.14µs -0.61%
put_and_commit/db_store/50 5.7±0.72ms 5.7±0.76ms 0.00%
put_and_commit/mem_store/1 63.2±5.55µs 62.8±5.51µs +0.64%
put_and_commit/mem_store/10 587.2±46.13µs 583.8±46.01µs +0.58%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.80ms 0.00%
put_and_commit/mem_store/5 297.3±24.09µs 294.8±23.89µs +0.85%
put_and_commit/mem_store/50 2.9±0.19ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.06ms 3.0±0.10ms -3.33%
query_block/query_block_in(10)_times(1000) 29.6±0.56ms 29.4±0.73ms +0.68%
query_block/query_block_in(10)_times(10000) 291.1±6.20ms 293.5±5.49ms -0.82%
query_block/query_block_in(1000)_times(100) 915.0±5.86µs 925.9±4.05µs -1.18%
query_block/query_block_in(1000)_times(1000) 9.2±0.05ms 9.1±0.06ms +1.10%
query_block/query_block_in(1000)_times(10000) 91.8±0.42ms 92.6±0.31ms -0.86%
storage_transaction 51.0±7.36ms 51.1±5.44ms -0.20%
vm/transaction_execution/1 331.9±1.98ms 335.7±1.37ms -1.13%
vm/transaction_execution/10 111.5±0.41ms 112.7±0.90ms -1.06%
vm/transaction_execution/20 105.0±0.23ms 106.1±0.91ms -1.04%
vm/transaction_execution/5 133.6±0.31ms 134.8±0.49ms -0.89%
vm/transaction_execution/50 120.5±0.28ms 121.6±0.60ms -0.90%

@jolestar jolestar merged commit 512e31f into master May 25, 2021
@jolestar jolestar deleted the indexer/vm-status-handling branch May 25, 2021 02:02
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
* handle vm status

* [indexer] update mapping of txn_info

* indexer: repair es data

Co-authored-by: chengsuoyuan <suoyuan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants