Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move-cli: support run on a snapshot of remote chain state #2560

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

nanne007
Copy link
Member

@nanne007 nanne007 commented Jun 1, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #2560 (9f95f37) into master (ded1804) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2560      +/-   ##
==========================================
- Coverage   32.89%   32.80%   -0.08%     
==========================================
  Files         503      503              
  Lines       43998    43998              
  Branches    19951    19951              
==========================================
- Hits        14468    14431      -37     
- Misses      14718    14809      +91     
+ Partials    14812    14758      -54     
Flag Coverage Δ
unittests 32.80% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/move-cli/src/lib.rs 100.00% <ø> (ø)
vm/move-cli/src/package.rs 0.00% <ø> (ø)
sync/src/block_connector/test_write_block_chain.rs 17.65% <0.00%> (-10.92%) ⬇️
sync/src/block_connector/write_block_chain.rs 27.61% <0.00%> (-6.77%) ⬇️
chain/src/chain.rs 35.00% <0.00%> (-3.25%) ⬇️
network-p2p/src/peer_info.rs 44.45% <0.00%> (-2.77%) ⬇️
...ons/forkable-jellyfish-merkle/src/node_type/mod.rs 65.30% <0.00%> (-1.03%) ⬇️
network-p2p/src/protocol.rs 41.26% <0.00%> (ø)
chain/src/verifier/mod.rs 31.90% <0.00%> (+0.87%) ⬆️
sync/src/block_connector/test_illegal_block.rs 14.84% <0.00%> (+0.96%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ded1804...9f95f37. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Benchmark for 04d8394

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.6±0.31ms 2.6±0.14ms 0.00%
block_apply/block_apply_10 468.4±8.23ms 476.0±13.54ms -1.60%
block_apply/block_apply_1000 47.8±1.40s 47.7±0.53s +0.21%
get_with_proof/db_store 38.1±0.48µs 38.2±0.29µs -0.26%
get_with_proof/mem_store 31.7±0.34µs 31.5±0.22µs +0.63%
put_and_commit/db_store/1 1531.4±94.22µs 1607.6±302.20µs -4.74%
put_and_commit/db_store/10 2.7±0.49ms 2.7±0.48ms 0.00%
put_and_commit/db_store/100 11.1±6.70ms 9.7±1.43ms +14.43%
put_and_commit/db_store/5 2.1±0.26ms 2.1±0.26ms 0.00%
put_and_commit/db_store/50 6.0±0.96ms 5.9±0.87ms +1.69%
put_and_commit/mem_store/1 62.8±5.56µs 62.6±5.56µs +0.32%
put_and_commit/mem_store/10 585.7±48.46µs 584.8±46.65µs +0.15%
put_and_commit/mem_store/100 5.7±0.82ms 5.7±0.84ms 0.00%
put_and_commit/mem_store/5 294.6±24.36µs 294.1±24.13µs +0.17%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.0±0.06ms 2.9±0.05ms +3.45%
query_block/query_block_in(10)_times(1000) 29.6±0.45ms 29.5±0.92ms +0.34%
query_block/query_block_in(10)_times(10000) 295.7±5.63ms 292.8±4.20ms +0.99%
query_block/query_block_in(1000)_times(100) 920.0±6.03µs 914.9±4.46µs +0.56%
query_block/query_block_in(1000)_times(1000) 9.2±0.12ms 9.5±0.08ms -3.16%
query_block/query_block_in(1000)_times(10000) 92.4±0.48ms 94.7±0.48ms -2.43%
storage_transaction 60.8±4.16ms 62.7±4.49ms -3.03%
vm/transaction_execution/1 334.0±1.75ms 334.3±3.87ms -0.09%
vm/transaction_execution/10 112.0±0.51ms 111.8±0.34ms +0.18%
vm/transaction_execution/20 105.5±0.43ms 105.6±1.27ms -0.09%
vm/transaction_execution/5 134.3±0.97ms 134.0±0.89ms +0.22%
vm/transaction_execution/50 121.8±1.37ms 120.9±0.46ms +0.74%

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jolestar jolestar merged commit ceaffb5 into master Jun 2, 2021
@jolestar jolestar deleted the move-cli/run-on-remote-state branch June 2, 2021 02:09
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants