-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Unify and refactor dev subcommands #2606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jolestar
commented
Jun 17, 2021
•
edited
Loading
edited
- 重构了 dev 下和 module upgrade 相关的命令,用 - 代替 _ , -m 用来表示 module,-i 用来表是 proposal id
- 清理了 chain 下的一些统计相关,需要遍历数据的命令,以后 cli 不再支持统计命令,降低维护成本,统计相关的任务通过外部索引数据库实现。
Codecov Report
@@ Coverage Diff @@
## master #2606 +/- ##
==========================================
+ Coverage 32.49% 32.49% +0.01%
==========================================
Files 501 501
Lines 43229 43229
Branches 19320 19320
==========================================
+ Hits 14042 14045 +3
- Misses 15398 15417 +19
+ Partials 13789 13767 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Benchmark for e9e01a9Click to view benchmark
|
nanne007
approved these changes
Jun 17, 2021
naughtyvenom
pushed a commit
to naughtyvenom/starcoin
that referenced
this pull request
Jul 19, 2021
* [scmd] Support set about info for command. * [cli] Unify and refactor dev subcommands. * [cli] Clean chain's stat,uncle,verify subcommand, to simplify the cli.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.