Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[address] Merge AccountAddress and ReceiptIdentifier, now, AccountAddress == ReceiptIdentifier #2627

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

jolestar
Copy link
Member

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #2627 (256cdd6) into master (4ce761b) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2627      +/-   ##
==========================================
- Coverage   32.65%   32.41%   -0.24%     
==========================================
  Files         501      500       -1     
  Lines       43140    43078      -62     
  Branches    19270    19245      -25     
==========================================
- Hits        14085    13958     -127     
- Misses      15221    15408     +187     
+ Partials    13834    13712     -122     
Flag Coverage Δ
unittests 32.41% <0.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
account/api/src/types.rs 51.52% <0.00%> (-6.06%) ⬇️
types/src/lib.rs 100.00% <ø> (ø)
vm/types/src/lib.rs 33.34% <ø> (ø)
vm/types/src/transaction/authenticator.rs 45.78% <ø> (+0.64%) ⬆️
rpc/server/src/module/mod.rs 0.00% <0.00%> (-16.84%) ⬇️
vm/types/src/transaction/error.rs 3.93% <0.00%> (-15.68%) ⬇️
sync/src/block_connector/write_block_chain.rs 27.61% <0.00%> (-6.77%) ⬇️
cmd/starcoin/src/cli_state.rs 47.37% <0.00%> (-5.26%) ⬇️
cmd/starcoin/src/dev/tests.rs 14.88% <0.00%> (-4.15%) ⬇️
chain/src/chain.rs 31.22% <0.00%> (-3.25%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce761b...256cdd6. Read the comment docs.

@jolestar jolestar merged commit 8d5b7e7 into master Jun 25, 2021
@jolestar jolestar deleted the address_bech32 branch June 25, 2021 00:51
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
…ress == ReceiptIdentifier (starcoinorg#2627)

* [address] Merge AccountAddress and ReceiptIdentifier, now, AccountAddress == ReceiptIdentifier

* [document] Update document about address and receipt identifier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants