Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix build on windows #2630

Merged
merged 7 commits into from
Jun 25, 2021
Merged

[ci] Fix build on windows #2630

merged 7 commits into from
Jun 25, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Jun 25, 2021

  1. 从 artifacts 里清理掉了一些不常用的二进制,减少压缩包大小。
  2. 升级 llvm 版本尝试修复 windows build 失败的问题

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #2630 (d8c193a) into master (483aa53) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2630      +/-   ##
==========================================
- Coverage   32.49%   32.45%   -0.04%     
==========================================
  Files         500      500              
  Lines       43079    43079              
  Branches    19246    19246              
==========================================
- Hits        13995    13975      -20     
- Misses      15331    15360      +29     
+ Partials    13753    13744       -9     
Flag Coverage Δ
unittests 32.45% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consensus/src/consensus.rs 43.75% <0.00%> (-15.62%) ⬇️
network-rpc/core/src/lib.rs 23.53% <0.00%> (-5.88%) ⬇️
sync/src/tasks/mock.rs 44.76% <0.00%> (-1.65%) ⬇️
sync/src/block_connector/test_illegal_block.rs 15.95% <0.00%> (-1.59%) ⬇️
network-p2p/src/request_responses.rs 30.96% <0.00%> (-1.56%) ⬇️
network/src/service_ref.rs 37.34% <0.00%> (-1.33%) ⬇️
types/src/peer_info.rs 51.56% <0.00%> (-1.24%) ⬇️
network/api/src/peer_provider.rs 29.53% <0.00%> (-1.18%) ⬇️
...ync/src/block_connector/block_connector_service.rs 32.19% <0.00%> (-1.14%) ⬇️
chain/src/verifier/mod.rs 31.04% <0.00%> (-0.86%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483aa53...d8c193a. Read the comment docs.

@github-actions
Copy link

Benchmark for 7f934da

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.1±0.11ms 2.1±0.12ms 0.00%
block_apply/block_apply_10 405.7±2.69ms 415.1±10.37ms -2.26%
block_apply/block_apply_1000 43.2±1.62s 42.5±0.80s +1.65%
get_with_proof/db_store 38.6±0.39µs 38.6±0.36µs 0.00%
get_with_proof/mem_store 32.1±0.39µs 31.9±0.40µs +0.63%
put_and_commit/db_store/1 1193.9±73.10µs 1194.9±58.59µs -0.08%
put_and_commit/db_store/10 2.3±0.40ms 2.3±0.40ms 0.00%
put_and_commit/db_store/100 9.3±0.71ms 9.4±0.89ms -1.06%
put_and_commit/db_store/5 1879.1±176.54µs 1849.7±163.99µs +1.59%
put_and_commit/db_store/50 5.6±0.73ms 5.5±0.59ms +1.82%
put_and_commit/mem_store/1 63.9±5.56µs 63.7±5.62µs +0.31%
put_and_commit/mem_store/10 586.0±47.48µs 587.6±48.49µs -0.27%
put_and_commit/mem_store/100 5.7±0.82ms 5.7±0.81ms 0.00%
put_and_commit/mem_store/5 297.4±24.41µs 298.1±24.43µs -0.23%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.05ms 2.9±0.07ms 0.00%
query_block/query_block_in(10)_times(1000) 29.4±0.47ms 29.2±0.78ms +0.68%
query_block/query_block_in(10)_times(10000) 293.6±5.10ms 296.3±5.34ms -0.91%
query_block/query_block_in(1000)_times(100) 909.6±4.56µs 937.3±6.44µs -2.96%
query_block/query_block_in(1000)_times(1000) 9.1±0.07ms 9.4±0.06ms -3.19%
query_block/query_block_in(1000)_times(10000) 91.5±0.68ms 93.7±0.34ms -2.35%
storage_transaction 46.7±5.64ms 45.1±3.16ms +3.55%
vm/transaction_execution/1 327.2±1.02ms 325.8±1.06ms +0.43%
vm/transaction_execution/10 106.9±0.79ms 106.2±0.91ms +0.66%
vm/transaction_execution/20 100.1±1.95ms 99.3±0.48ms +0.81%
vm/transaction_execution/5 129.9±2.46ms 128.4±0.89ms +1.17%
vm/transaction_execution/50 113.9±1.02ms 113.5±0.42ms +0.35%

@jolestar jolestar merged commit 34f48e3 into master Jun 25, 2021
@jolestar jolestar deleted the fix_ci_windows branch June 25, 2021 06:12
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
* [ci]  Install LLVM and Clang on windows for fix build on windows failed.

* [release] remove some binary from artifacts and add move cli to docker image.

* [ci] Support upload artifact asset on action page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants