Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nested token code #2631

Merged
merged 1 commit into from
Jun 25, 2021
Merged

fix nested token code #2631

merged 1 commit into from
Jun 25, 2021

Conversation

nanne007
Copy link
Member

close #2628

@nanne007 nanne007 requested a review from jolestar June 25, 2021 02:44
@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #2631 (606fd5c) into master (483aa53) will decrease coverage by 0.04%.
The diff coverage is 25.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2631      +/-   ##
==========================================
- Coverage   32.49%   32.46%   -0.03%     
==========================================
  Files         500      500              
  Lines       43079    43090      +11     
  Branches    19246    19250       +4     
==========================================
- Hits        13995    13984      -11     
- Misses      15331    15457     +126     
+ Partials    13753    13649     -104     
Flag Coverage Δ
unittests 32.46% <25.87%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
state/api/src/chain_state.rs 48.71% <0.00%> (-0.64%) ⬇️
vm/transaction-builder/src/lib.rs 17.99% <0.00%> (ø)
vm/types/src/on_chain_resource/dao/mod.rs 0.00% <0.00%> (ø)
vm/types/src/on_chain_resource/treasury.rs 0.00% <0.00%> (ø)
vm/types/src/token/token_info.rs 0.00% <0.00%> (ø)
vm/types/src/token/token_code.rs 42.23% <33.34%> (+9.73%) ⬆️
vm/types/src/account_config/resources/balance.rs 36.37% <66.67%> (-7.63%) ⬇️
vm/vm-runtime/src/starcoin_vm.rs 29.57% <66.67%> (+0.40%) ⬆️
executor/src/account.rs 40.55% <100.00%> (+0.19%) ⬆️
executor/src/script_function_test.rs 11.63% <0.00%> (-6.97%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483aa53...606fd5c. Read the comment docs.

@github-actions
Copy link

Benchmark for e4724d5

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.7±0.29ms 2.6±0.15ms +3.85%
block_apply/block_apply_10 509.5±13.42ms 497.1±8.10ms +2.49%
block_apply/block_apply_1000 51.3±0.71s 50.7±0.45s +1.18%
get_with_proof/db_store 38.7±0.60µs 38.2±0.25µs +1.31%
get_with_proof/mem_store 31.8±0.37µs 31.5±0.29µs +0.95%
put_and_commit/db_store/1 1864.7±111.38µs 1884.0±143.70µs -1.02%
put_and_commit/db_store/10 2.8±0.50ms 2.8±0.49ms 0.00%
put_and_commit/db_store/100 9.7±0.98ms 9.9±1.42ms -2.02%
put_and_commit/db_store/5 2.4±0.17ms 2.4±0.20ms 0.00%
put_and_commit/db_store/50 5.9±0.97ms 6.0±0.97ms -1.67%
put_and_commit/mem_store/1 63.3±5.84µs 64.6±6.68µs -2.01%
put_and_commit/mem_store/10 588.0±50.41µs 595.4±48.60µs -1.24%
put_and_commit/mem_store/100 5.8±0.84ms 5.8±0.84ms 0.00%
put_and_commit/mem_store/5 296.1±24.96µs 301.2±25.13µs -1.69%
put_and_commit/mem_store/50 2.9±0.20ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.05ms 3.0±0.05ms -3.33%
query_block/query_block_in(10)_times(1000) 29.4±0.56ms 29.4±0.29ms 0.00%
query_block/query_block_in(10)_times(10000) 292.1±6.25ms 291.9±3.22ms +0.07%
query_block/query_block_in(1000)_times(100) 916.8±7.86µs 913.4±4.36µs +0.37%
query_block/query_block_in(1000)_times(1000) 9.1±0.05ms 9.1±0.09ms 0.00%
query_block/query_block_in(1000)_times(10000) 91.5±0.39ms 91.8±0.51ms -0.33%
storage_transaction 61.6±4.08ms 61.2±3.80ms +0.65%
vm/transaction_execution/1 327.6±1.80ms 326.1±0.72ms +0.46%
vm/transaction_execution/10 107.5±1.53ms 106.3±0.71ms +1.13%
vm/transaction_execution/20 100.4±1.03ms 99.6±0.77ms +0.80%
vm/transaction_execution/5 129.4±1.80ms 128.5±0.43ms +0.70%
vm/transaction_execution/50 115.4±1.59ms 113.6±0.78ms +1.58%

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jolestar jolestar merged commit 1543671 into master Jun 25, 2021
@jolestar jolestar deleted the fix/token-code branch June 25, 2021 05:10
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashing on dev mode while published token which including two generic type parameters.
2 participants