-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explain vm status #2647
explain vm status #2647
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2647 +/- ##
==========================================
+ Coverage 32.36% 32.43% +0.08%
==========================================
Files 503 503
Lines 43378 43378
Branches 19387 19387
==========================================
+ Hits 14033 14065 +32
+ Misses 15544 15492 -52
- Partials 13801 13821 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Benchmark for 54e82aaClick to view benchmark
|
f1ab68c
to
50304fc
Compare
Benchmark for fad40cfClick to view benchmark
|
50304fc
to
599594d
Compare
599594d
to
3ff500a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Benchmark for 6a094bdClick to view benchmark
|
下一步是不是可以考虑把 VMStatusExplainView 直接在 rpc 接口返回值中输出。感觉至少 dry run 的接口需要,现在 starmask dry run 报错后需要提示给用户。 |
可以。dry run 先加上。 |
Benchmark for 261b686Click to view benchmark
|
* explain vm status * output status code to string
No description provided.