explain vm status #2647

nanne007 · 2021-06-28T12:08:16Z

No description provided.

codecov · 2021-06-28T12:40:46Z

Codecov Report

Merging #2647 (112f5d9) into master (9ab82d8) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2647      +/-   ##
==========================================
+ Coverage   32.36%   32.43%   +0.08%     
==========================================
  Files         503      503              
  Lines       43378    43378              
  Branches    19387    19387              
==========================================
+ Hits        14033    14065      +32     
+ Misses      15544    15492      -52     
- Partials    13801    13821      +20

Flag	Coverage Δ
unittests	`32.43% <ø> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/starcoin/src/cli_state.rs	`52.64% <ø> (ø)`
cmd/starcoin/src/lib.rs	`100.00% <ø> (ø)`
commons/service-registry/src/service_ref.rs	`65.34% <0.00%> (-4.00%)`	⬇️
commons/service-registry/src/service_actor.rs	`38.71% <0.00%> (-3.22%)`	⬇️
network-rpc/api/src/lib.rs	`18.10% <0.00%> (-2.85%)`	⬇️
vm/types/src/on_chain_resource/epoch.rs	`19.38% <0.00%> (-2.32%)`	⬇️
network-rpc/src/rpc.rs	`16.03% <0.00%> (-1.92%)`	⬇️
sync/src/announcement/mod.rs	`17.05% <0.00%> (-1.13%)`	⬇️
sync/src/block_connector/test_illegal_block.rs	`12.92% <0.00%> (-1.11%)`	⬇️
chain/src/verifier/mod.rs	`31.04% <0.00%> (-0.86%)`	⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab82d8...112f5d9. Read the comment docs.

github-actions · 2021-06-28T12:44:20Z

Benchmark for `54e82aa`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	2.5±0.13ms	2.5±0.16ms	0.00%
block_apply/block_apply_10	471.0±7.68ms	471.0±6.13ms	0.00%
block_apply/block_apply_1000	47.9±0.20s	47.6±0.37s	+0.63%
get_with_proof/db_store	38.1±0.45µs	38.6±0.24µs	-1.30%
get_with_proof/mem_store	31.6±0.30µs	31.8±0.34µs	-0.63%
put_and_commit/db_store/1	1562.8±102.75µs	1537.6±71.54µs	+1.64%
put_and_commit/db_store/10	2.6±0.37ms	2.7±0.52ms	-3.70%
put_and_commit/db_store/100	9.7±1.42ms	9.7±1.40ms	0.00%
put_and_commit/db_store/5	2.1±0.22ms	2.1±0.16ms	0.00%
put_and_commit/db_store/50	5.9±0.84ms	5.9±0.95ms	0.00%
put_and_commit/mem_store/1	63.4±5.65µs	63.1±5.62µs	+0.48%
put_and_commit/mem_store/10	588.3±48.42µs	586.2±47.10µs	+0.36%
put_and_commit/mem_store/100	5.7±0.84ms	5.7±0.82ms	0.00%
put_and_commit/mem_store/5	296.4±24.73µs	295.6±24.69µs	+0.27%
put_and_commit/mem_store/50	2.9±0.19ms	2.9±0.19ms	0.00%
query_block/query_block_in(10)_times(100)	3.0±0.06ms	2.9±0.06ms	+3.45%
query_block/query_block_in(10)_times(1000)	29.8±1.42ms	29.4±0.45ms	+1.36%
query_block/query_block_in(10)_times(10000)	295.3±4.26ms	295.3±5.63ms	0.00%
query_block/query_block_in(1000)_times(100)	910.5±4.76µs	914.5±5.96µs	-0.44%
query_block/query_block_in(1000)_times(1000)	9.1±0.06ms	9.1±0.04ms	0.00%
query_block/query_block_in(1000)_times(10000)	91.6±0.89ms	91.6±0.52ms	0.00%
storage_transaction	58.4±3.16ms	59.0±4.28ms	-1.02%
vm/transaction_execution/1	327.4±0.85ms	327.0±0.53ms	+0.12%
vm/transaction_execution/10	107.0±0.25ms	107.2±0.83ms	-0.19%
vm/transaction_execution/20	100.3±0.50ms	99.9±0.50ms	+0.40%
vm/transaction_execution/5	129.4±0.36ms	128.7±0.22ms	+0.54%
vm/transaction_execution/50	114.6±0.26ms	114.6±0.68ms	0.00%

github-actions · 2021-06-28T13:27:20Z

Benchmark for `fad40cf`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	2.6±0.16ms	2.6±0.47ms	0.00%
block_apply/block_apply_10	486.5±6.62ms	481.1±8.22ms	+1.12%
block_apply/block_apply_1000	49.4±0.69s	49.0±0.46s	+0.82%
get_with_proof/db_store	38.9±0.36µs	38.5±0.31µs	+1.04%
get_with_proof/mem_store	31.5±0.21µs	31.7±0.54µs	-0.63%
put_and_commit/db_store/1	1618.4±95.45µs	1637.0±114.08µs	-1.14%
put_and_commit/db_store/10	2.7±0.55ms	2.7±0.32ms	0.00%
put_and_commit/db_store/100	9.9±1.41ms	9.7±1.64ms	+2.06%
put_and_commit/db_store/5	2.2±0.21ms	2.2±0.26ms	0.00%
put_and_commit/db_store/50	6.0±0.93ms	5.9±0.80ms	+1.69%
put_and_commit/mem_store/1	62.8±5.55µs	63.7±5.67µs	-1.41%
put_and_commit/mem_store/10	586.3±48.28µs	589.4±51.46µs	-0.53%
put_and_commit/mem_store/100	5.7±0.82ms	5.7±0.84ms	0.00%
put_and_commit/mem_store/5	296.1±24.42µs	299.2±25.27µs	-1.04%
put_and_commit/mem_store/50	2.9±0.18ms	2.9±0.18ms	0.00%
query_block/query_block_in(10)_times(100)	2.9±0.06ms	2.9±0.05ms	0.00%
query_block/query_block_in(10)_times(1000)	29.5±0.68ms	29.5±0.36ms	0.00%
query_block/query_block_in(10)_times(10000)	295.7±3.94ms	295.1±3.53ms	+0.20%
query_block/query_block_in(1000)_times(100)	918.4±6.59µs	939.1±35.95µs	-2.20%
query_block/query_block_in(1000)_times(1000)	9.2±0.05ms	9.2±0.04ms	0.00%
query_block/query_block_in(1000)_times(10000)	91.2±0.78ms	92.7±0.49ms	-1.62%
storage_transaction	62.6±5.15ms	60.9±3.42ms	+2.79%
vm/transaction_execution/1	327.9±0.60ms	331.7±2.97ms	-1.15%
vm/transaction_execution/10	107.2±0.61ms	107.6±0.61ms	-0.37%
vm/transaction_execution/20	100.1±0.22ms	101.0±1.02ms	-0.89%
vm/transaction_execution/5	129.3±0.23ms	129.7±0.34ms	-0.31%
vm/transaction_execution/50	114.6±0.28ms	115.2±0.52ms	-0.52%

cmd/starcoin/src/view.rs

jolestar

LGTM

github-actions · 2021-06-29T01:08:05Z

Benchmark for `6a094bd`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	2.5±0.17ms	2.5±0.13ms	0.00%
block_apply/block_apply_10	470.9±8.39ms	482.1±12.80ms	-2.32%
block_apply/block_apply_1000	47.0±0.84s	47.8±1.11s	-1.67%
get_with_proof/db_store	39.1±0.35µs	38.7±0.40µs	+1.03%
get_with_proof/mem_store	31.7±0.66µs	31.7±0.25µs	0.00%
put_and_commit/db_store/1	1615.1±102.83µs	1545.4±93.24µs	+4.51%
put_and_commit/db_store/10	2.7±0.41ms	2.6±0.27ms	+3.85%
put_and_commit/db_store/100	9.5±0.84ms	9.8±0.92ms	-3.06%
put_and_commit/db_store/5	2.2±0.16ms	2.1±0.17ms	+4.76%
put_and_commit/db_store/50	5.8±0.67ms	5.9±0.71ms	-1.69%
put_and_commit/mem_store/1	62.9±5.62µs	63.4±5.62µs	-0.79%
put_and_commit/mem_store/10	588.2±48.45µs	587.0±45.68µs	+0.20%
put_and_commit/mem_store/100	5.7±0.82ms	5.7±0.80ms	0.00%
put_and_commit/mem_store/5	296.4±24.00µs	296.7±24.31µs	-0.10%
put_and_commit/mem_store/50	2.9±0.18ms	2.9±0.18ms	0.00%
query_block/query_block_in(10)_times(100)	2.9±0.07ms	2.9±0.07ms	0.00%
query_block/query_block_in(10)_times(1000)	29.5±1.03ms	29.6±1.08ms	-0.34%
query_block/query_block_in(10)_times(10000)	293.2±4.74ms	293.6±5.03ms	-0.14%
query_block/query_block_in(1000)_times(100)	907.9±3.48µs	932.8±5.78µs	-2.67%
query_block/query_block_in(1000)_times(1000)	9.1±0.03ms	9.3±0.05ms	-2.15%
query_block/query_block_in(1000)_times(10000)	90.6±0.85ms	93.0±0.44ms	-2.58%
storage_transaction	55.5±3.47ms	65.5±3.82ms	-15.27%
vm/transaction_execution/1	327.2±3.33ms	329.5±7.53ms	-0.70%
vm/transaction_execution/10	106.5±0.79ms	106.8±0.60ms	-0.28%
vm/transaction_execution/20	99.6±0.79ms	100.0±0.73ms	-0.40%
vm/transaction_execution/5	128.5±0.40ms	129.2±0.62ms	-0.54%
vm/transaction_execution/50	114.1±0.77ms	114.5±0.93ms	-0.35%

jolestar · 2021-06-29T01:11:55Z

下一步是不是可以考虑把 VMStatusExplainView 直接在 rpc 接口返回值中输出。感觉至少 dry run 的接口需要，现在 starmask dry run 报错后需要提示给用户。

nanne007 · 2021-06-29T01:20:46Z

下一步是不是可以考虑把 VMStatusExplainView 直接在 rpc 接口返回值中输出。感觉至少 dry run 的接口需要，现在 starmask dry run 报错后需要提示给用户。

可以。dry run 先加上。

github-actions · 2021-06-29T01:56:26Z

Benchmark for `261b686`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	2.4±0.11ms	2.4±0.12ms	0.00%
block_apply/block_apply_10	470.5±8.55ms	457.1±4.71ms	+2.93%
block_apply/block_apply_1000	48.1±0.90s	48.3±1.18s	-0.41%
get_with_proof/db_store	38.8±0.41µs	38.5±0.37µs	+0.78%
get_with_proof/mem_store	32.3±0.35µs	31.7±0.28µs	+1.89%
put_and_commit/db_store/1	1572.0±95.65µs	1503.7±89.20µs	+4.54%
put_and_commit/db_store/10	2.5±0.38ms	2.6±0.38ms	-3.85%
put_and_commit/db_store/100	9.7±0.90ms	9.7±0.86ms	0.00%
put_and_commit/db_store/5	2.2±0.19ms	2.1±0.19ms	+4.76%
put_and_commit/db_store/50	6.1±0.71ms	7.3±4.02ms	-16.44%
put_and_commit/mem_store/1	62.9±5.63µs	63.3±5.60µs	-0.63%
put_and_commit/mem_store/10	592.0±46.33µs	588.3±46.72µs	+0.63%
put_and_commit/mem_store/100	5.7±0.81ms	5.8±0.84ms	-1.72%
put_and_commit/mem_store/5	295.1±24.78µs	296.6±24.11µs	-0.51%
put_and_commit/mem_store/50	2.9±0.18ms	2.9±0.18ms	0.00%
query_block/query_block_in(10)_times(100)	2.9±0.07ms	2.9±0.12ms	0.00%
query_block/query_block_in(10)_times(1000)	29.1±0.64ms	29.6±0.49ms	-1.69%
query_block/query_block_in(10)_times(10000)	293.6±4.42ms	290.4±3.26ms	+1.10%
query_block/query_block_in(1000)_times(100)	908.6±2.85µs	927.2±6.36µs	-2.01%
query_block/query_block_in(1000)_times(1000)	9.4±0.07ms	9.2±0.07ms	+2.17%
query_block/query_block_in(1000)_times(10000)	92.5±2.64ms	92.1±0.68ms	+0.43%
storage_transaction	58.5±4.13ms	62.8±3.68ms	-6.85%
vm/transaction_execution/1	326.6±0.75ms	326.6±0.85ms	0.00%
vm/transaction_execution/10	106.4±0.21ms	107.1±1.36ms	-0.65%
vm/transaction_execution/20	100.4±1.95ms	99.8±0.45ms	+0.60%
vm/transaction_execution/5	130.2±4.20ms	129.0±0.38ms	+0.93%
vm/transaction_execution/50	114.2±0.60ms	114.4±0.85ms	-0.17%

* explain vm status * output status code to string

nanne007 force-pushed the explain-vm-status branch from f1ab68c to 50304fc Compare June 28, 2021 12:49

nanne007 force-pushed the explain-vm-status branch from 50304fc to 599594d Compare June 29, 2021 00:19

nanne007 requested a review from jolestar June 29, 2021 00:23

explain vm status

3ff500a

nanne007 force-pushed the explain-vm-status branch from 599594d to 3ff500a Compare June 29, 2021 00:23

jolestar reviewed Jun 29, 2021

View reviewed changes

cmd/starcoin/src/view.rs Outdated Show resolved Hide resolved

jolestar approved these changes Jun 29, 2021

View reviewed changes

nanne007 added 2 commits June 29, 2021 09:12

fix clippy

3b17233

output status code to string

112f5d9

jolestar merged commit 0f76c09 into master Jun 29, 2021

jolestar deleted the explain-vm-status branch June 29, 2021 03:09

naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021

explain vm status (starcoinorg#2647)

d4a410e

* explain vm status * output status code to string

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

explain vm status #2647

explain vm status #2647

nanne007 commented Jun 28, 2021

codecov bot commented Jun 28, 2021 •

edited

Loading

github-actions bot commented Jun 28, 2021

github-actions bot commented Jun 28, 2021

jolestar left a comment

github-actions bot commented Jun 29, 2021

jolestar commented Jun 29, 2021

nanne007 commented Jun 29, 2021

github-actions bot commented Jun 29, 2021

explain vm status #2647

explain vm status #2647

Conversation

nanne007 commented Jun 28, 2021

codecov bot commented Jun 28, 2021 • edited Loading

Codecov Report

github-actions bot commented Jun 28, 2021

Benchmark for 54e82aa

github-actions bot commented Jun 28, 2021

Benchmark for fad40cf

jolestar left a comment

Choose a reason for hiding this comment

github-actions bot commented Jun 29, 2021

Benchmark for 6a094bd

jolestar commented Jun 29, 2021

nanne007 commented Jun 29, 2021

github-actions bot commented Jun 29, 2021

Benchmark for 261b686

codecov bot commented Jun 28, 2021 •

edited

Loading

Benchmark for `54e82aa`

Benchmark for `fad40cf`

Benchmark for `6a094bd`

Benchmark for `261b686`