Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account show balance by list resource api, and output full token code as balance name. #2658

Merged
merged 2 commits into from
Jul 4, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Jul 2, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #2658 (0bf7af5) into master (413861e) will increase coverage by 0.12%.
The diff coverage is 9.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2658      +/-   ##
==========================================
+ Coverage   32.30%   32.42%   +0.12%     
==========================================
  Files         503      503              
  Lines       43378    43391      +13     
  Branches    19387    19394       +7     
==========================================
+ Hits        14008    14064      +56     
+ Misses      15631    15465     -166     
- Partials    13739    13862     +123     
Flag Coverage Δ
unittests 32.42% <9.53%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/types/src/account_config/resources/balance.rs 25.81% <0.00%> (-10.55%) ⬇️
vm/types/src/token/token_code.rs 36.74% <16.67%> (-5.48%) ⬇️
commons/service-registry/src/service_actor.rs 38.71% <0.00%> (-4.30%) ⬇️
commons/service-registry/src/service_ref.rs 65.34% <0.00%> (-4.00%) ⬇️
network-rpc/api/src/lib.rs 18.10% <0.00%> (-2.85%) ⬇️
network-rpc/src/rpc.rs 16.03% <0.00%> (-1.92%) ⬇️
sync/src/announcement/mod.rs 17.05% <0.00%> (-1.13%) ⬇️
network/src/service.rs 32.68% <0.00%> (-0.74%) ⬇️
txpool/src/tx_pool_service_impl.rs 43.68% <0.00%> (-0.57%) ⬇️
sync/src/verified_rpc_client.rs 17.83% <0.00%> (-0.49%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413861e...0bf7af5. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

Benchmark for ddf36f0

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.4±0.20ms 2.5±0.22ms -4.00%
block_apply/block_apply_10 478.7±16.04ms 475.2±7.44ms +0.74%
block_apply/block_apply_1000 49.0±0.61s 49.1±0.56s -0.20%
get_with_proof/db_store 38.2±0.37µs 39.0±0.36µs -2.05%
get_with_proof/mem_store 31.7±0.43µs 32.2±0.43µs -1.55%
put_and_commit/db_store/1 1773.3±191.52µs 1650.5±118.78µs +7.44%
put_and_commit/db_store/10 2.6±0.40ms 2.6±0.48ms 0.00%
put_and_commit/db_store/100 9.6±1.00ms 9.6±0.85ms 0.00%
put_and_commit/db_store/5 2.1±0.22ms 2.1±0.23ms 0.00%
put_and_commit/db_store/50 5.9±0.90ms 5.8±0.82ms +1.72%
put_and_commit/mem_store/1 63.5±6.30µs 63.7±5.96µs -0.31%
put_and_commit/mem_store/10 588.8±59.36µs 593.2±47.97µs -0.74%
put_and_commit/mem_store/100 5.7±0.84ms 5.8±0.84ms -1.72%
put_and_commit/mem_store/5 297.3±26.72µs 298.4±25.23µs -0.37%
put_and_commit/mem_store/50 2.9±0.20ms 2.9±0.20ms 0.00%
query_block/query_block_in(10)_times(100) 3.0±0.03ms 2.9±0.07ms +3.45%
query_block/query_block_in(10)_times(1000) 29.9±0.50ms 29.8±0.61ms +0.34%
query_block/query_block_in(10)_times(10000) 299.8±3.37ms 292.6±7.03ms +2.46%
query_block/query_block_in(1000)_times(100) 915.2±10.41µs 922.5±3.37µs -0.79%
query_block/query_block_in(1000)_times(1000) 9.1±0.05ms 9.2±0.04ms -1.09%
query_block/query_block_in(1000)_times(10000) 91.4±0.72ms 92.6±0.50ms -1.30%
storage_transaction 53.8±4.60ms 53.1±3.73ms +1.32%
vm/transaction_execution/1 327.6±0.79ms 326.3±0.96ms +0.40%
vm/transaction_execution/10 108.0±4.84ms 106.3±0.20ms +1.60%
vm/transaction_execution/20 99.7±0.43ms 100.4±2.00ms -0.70%
vm/transaction_execution/5 129.0±1.04ms 128.8±0.58ms +0.16%
vm/transaction_execution/50 114.3±0.55ms 114.3±1.56ms 0.00%

@nanne007 nanne007 merged commit e8fa28d into master Jul 4, 2021
@nanne007 nanne007 deleted the account_show_balances branch July 4, 2021 05:26
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
… as balance name. (starcoinorg#2658)

* [cli] Account show balance by list resource api, and output full token code as balance name.

* [cli] Fix dev deploy command transaction sender's bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants