Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd] enhancement faucet, support default account and limit max amount #2669

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Jul 6, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #2669 (4e8521c) into master (d881811) will decrease coverage by 0.06%.
The diff coverage is 16.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2669      +/-   ##
==========================================
- Coverage   32.43%   32.37%   -0.05%     
==========================================
  Files         505      505              
  Lines       43857    43860       +3     
  Branches    19545    19545              
==========================================
- Hits        14222    14197      -25     
- Misses      15667    15711      +44     
+ Partials    13968    13952      -16     
Flag Coverage Δ
unittests 32.37% <16.67%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/types/src/token/stc.rs 64.52% <0.00%> (-3.28%) ⬇️
vm/types/src/token/token_value.rs 54.06% <0.00%> (ø)
cmd/faucet/src/lib.rs 100.00% <100.00%> (ø)
sync/src/block_connector/test_write_block_chain.rs 15.97% <0.00%> (-9.24%) ⬇️
sync/src/block_connector/write_block_chain.rs 27.61% <0.00%> (-6.77%) ⬇️
chain/src/chain.rs 32.94% <0.00%> (-3.25%) ⬇️
...ons/forkable-jellyfish-merkle/src/node_type/mod.rs 65.30% <0.00%> (-1.03%) ⬇️
chain/src/verifier/mod.rs 31.90% <0.00%> (ø)
network-p2p/src/protocol.rs 41.26% <0.00%> (ø)
sync/src/tasks/block_sync_task.rs 40.35% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d881811...4e8521c. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 6, 2021

Benchmark for bc949a3

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.8±0.26ms 2.8±0.14ms 0.00%
block_apply/block_apply_10 493.5±19.23ms 498.9±13.24ms -1.08%
block_apply/block_apply_1000 50.8±1.23s 50.8±1.19s 0.00%
get_with_proof/db_store 38.9±0.27µs 38.7±0.28µs +0.52%
get_with_proof/mem_store 31.7±0.37µs 31.7±0.26µs 0.00%
put_and_commit/db_store/1 1762.7±155.40µs 1851.9±162.79µs -4.82%
put_and_commit/db_store/10 2.8±0.40ms 3.0±0.36ms -6.67%
put_and_commit/db_store/100 10.7±3.63ms 10.1±1.00ms +5.94%
put_and_commit/db_store/5 2.5±0.20ms 2.2±0.18ms +13.64%
put_and_commit/db_store/50 6.1±0.67ms 6.3±0.76ms -3.17%
put_and_commit/mem_store/1 62.8±5.51µs 63.7±5.61µs -1.41%
put_and_commit/mem_store/10 586.2±48.27µs 591.5±48.29µs -0.90%
put_and_commit/mem_store/100 5.7±0.81ms 5.8±0.82ms -1.72%
put_and_commit/mem_store/5 298.1±25.07µs 297.8±23.89µs +0.10%
put_and_commit/mem_store/50 2.9±0.19ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.05ms 3.0±0.08ms -3.33%
query_block/query_block_in(10)_times(1000) 29.5±0.60ms 29.4±0.36ms +0.34%
query_block/query_block_in(10)_times(10000) 293.4±7.06ms 294.7±3.78ms -0.44%
query_block/query_block_in(1000)_times(100) 913.8±1.83µs 913.3±3.71µs +0.05%
query_block/query_block_in(1000)_times(1000) 9.1±0.04ms 9.2±0.05ms -1.09%
query_block/query_block_in(1000)_times(10000) 91.7±0.67ms 92.6±0.53ms -0.97%
storage_transaction 67.4±5.36ms 67.5±4.88ms -0.15%
vm/transaction_execution/1 327.9±1.39ms 328.2±1.28ms -0.09%
vm/transaction_execution/10 107.0±0.30ms 107.8±2.02ms -0.74%
vm/transaction_execution/20 100.3±0.87ms 100.2±0.32ms +0.10%
vm/transaction_execution/5 129.5±0.42ms 129.4±0.40ms +0.08%
vm/transaction_execution/50 114.5±0.35ms 114.6±0.60ms -0.09%

@ssyuan ssyuan merged commit dd2b097 into master Jul 6, 2021
@ssyuan ssyuan deleted the faucet_improve branch July 6, 2021 07:55
@jolestar jolestar linked an issue Jul 15, 2021 that may be closed by this pull request
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
…nt (starcoinorg#2669)

* [types] Parse stc unit ignore ascii case.

* [cmd] enhancement faucet, support default account and limit max amount.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

barnard faucet
3 participants