Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: event filter now support filter by address or typetag #2682

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

nanne007
Copy link
Member

@nanne007 nanne007 commented Jul 8, 2021

No description provided.

@nanne007
Copy link
Member Author

nanne007 commented Jul 8, 2021

close #2655

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #2682 (228cffa) into master (007f210) will decrease coverage by 1.84%.
The diff coverage is 31.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2682      +/-   ##
==========================================
- Coverage   33.95%   32.11%   -1.83%     
==========================================
  Files         483      506      +23     
  Lines       40688    44138    +3450     
  Branches    17990    19644    +1654     
==========================================
+ Hits        13810    14170     +360     
- Misses      13386    16029    +2643     
- Partials    13492    13939     +447     
Flag Coverage Δ
unittests 32.11% <31.54%> (-1.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
account/api/src/error.rs 0.00% <0.00%> (ø)
account/api/src/message.rs 0.00% <0.00%> (ø)
account/service/src/lib.rs 100.00% <ø> (ø)
account/src/lib.rs 100.00% <ø> (ø)
chain/api/src/errors.rs 39.14% <ø> (ø)
chain/api/src/message.rs 0.00% <ø> (ø)
chain/open-block/src/lib.rs 30.35% <ø> (ø)
chain/service/src/lib.rs 100.00% <ø> (ø)
chain/src/lib.rs 100.00% <ø> (ø)
cmd/generator/src/lib.rs 100.00% <ø> (ø)
... and 357 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e8392...228cffa. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 8, 2021

Benchmark for 6d64435

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.3±0.45ms 2.2±0.14ms +4.55%
block_apply/block_apply_10 425.4±7.56ms 431.7±9.96ms -1.46%
block_apply/block_apply_1000 43.7±0.64s 43.8±1.24s -0.23%
get_with_proof/db_store 38.2±0.24µs 38.3±0.35µs -0.26%
get_with_proof/mem_store 31.7±0.31µs 31.8±0.25µs -0.31%
put_and_commit/db_store/1 1368.9±89.18µs 1219.4±63.35µs +12.26%
put_and_commit/db_store/10 2.3±0.41ms 2.3±0.37ms 0.00%
put_and_commit/db_store/100 9.4±0.60ms 9.3±0.74ms +1.08%
put_and_commit/db_store/5 1900.0±196.67µs 1875.4±161.60µs +1.31%
put_and_commit/db_store/50 5.6±0.70ms 5.5±0.66ms +1.82%
put_and_commit/mem_store/1 62.9±5.57µs 63.2±5.57µs -0.47%
put_and_commit/mem_store/10 582.8±45.84µs 584.7±46.39µs -0.32%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.81ms 0.00%
put_and_commit/mem_store/5 295.3±24.36µs 298.1±24.13µs -0.94%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.09ms 2.9±0.08ms 0.00%
query_block/query_block_in(10)_times(1000) 29.2±0.39ms 29.2±0.43ms 0.00%
query_block/query_block_in(10)_times(10000) 298.4±5.64ms 294.2±3.92ms +1.43%
query_block/query_block_in(1000)_times(100) 914.9±4.51µs 914.5±4.56µs +0.04%
query_block/query_block_in(1000)_times(1000) 9.2±0.04ms 9.2±0.06ms 0.00%
query_block/query_block_in(1000)_times(10000) 92.2±0.33ms 91.4±0.36ms +0.88%
storage_transaction 48.8±4.00ms 45.3±3.58ms +7.73%
vm/transaction_execution/1 325.8±0.90ms 327.4±0.60ms -0.49%
vm/transaction_execution/10 106.2±0.21ms 107.3±0.32ms -1.03%
vm/transaction_execution/20 100.4±1.64ms 99.9±0.33ms +0.50%
vm/transaction_execution/5 128.6±1.08ms 129.1±0.69ms -0.39%
vm/transaction_execution/50 114.5±2.24ms 114.1±0.23ms +0.35%

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jolestar jolestar merged commit 737635c into master Jul 9, 2021
@jolestar jolestar deleted the rpc/event-filter branch July 9, 2021 01:04
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants