Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types] Do auth key final cleanup #2687

Merged
merged 1 commit into from
Jul 12, 2021
Merged

[types] Do auth key final cleanup #2687

merged 1 commit into from
Jul 12, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Jul 9, 2021

stdlibv5 升级后,block_metadata 中的 auth_key 不再起作用,这次 pr 做最后的清理,miner service 不再判断 miner account 是否在链上存在。

注: BlockHeader 中的该字段未直接删除是因为需要兼容历史 Block 数据,该字段以后不再使用。

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #2687 (f812468) into master (007f210) will decrease coverage by 1.76%.
The diff coverage is 31.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
- Coverage   33.95%   32.19%   -1.75%     
==========================================
  Files         483      506      +23     
  Lines       40688    44039    +3351     
  Branches    17990    19583    +1593     
==========================================
+ Hits        13810    14173     +363     
- Misses      13386    15911    +2525     
- Partials    13492    13955     +463     
Flag Coverage Δ
unittests 32.19% <31.75%> (-1.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
account/api/src/error.rs 0.00% <0.00%> (ø)
account/api/src/message.rs 0.00% <0.00%> (ø)
account/service/src/lib.rs 100.00% <ø> (ø)
account/src/lib.rs 100.00% <ø> (ø)
chain/api/src/errors.rs 39.14% <ø> (ø)
chain/api/src/message.rs 0.00% <ø> (ø)
chain/service/src/lib.rs 100.00% <ø> (ø)
chain/src/chain.rs 30.99% <ø> (-7.26%) ⬇️
chain/src/lib.rs 100.00% <ø> (ø)
cmd/generator/src/lib.rs 100.00% <ø> (ø)
... and 366 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 737635c...f812468. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 9, 2021

Benchmark for 64dc998

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.9±0.14ms 3.0±0.10ms -3.33%
block_apply/block_apply_10 546.0±11.00ms 530.2±13.24ms +2.98%
block_apply/block_apply_1000 56.0±0.76s 55.6±1.32s +0.72%
get_with_proof/db_store 38.7±0.75µs 38.6±0.35µs +0.26%
get_with_proof/mem_store 31.5±0.33µs 31.6±0.20µs -0.32%
put_and_commit/db_store/1 1973.9±85.39µs 2.0±0.11ms -1.30%
put_and_commit/db_store/10 3.0±0.24ms 3.1±0.20ms -3.23%
put_and_commit/db_store/100 10.1±0.99ms 10.2±0.97ms -0.98%
put_and_commit/db_store/5 4.2±2.82ms 2.6±0.14ms +61.54%
put_and_commit/db_store/50 6.3±0.71ms 6.2±0.73ms +1.61%
put_and_commit/mem_store/1 63.0±5.54µs 63.4±5.50µs -0.63%
put_and_commit/mem_store/10 585.5±46.20µs 585.9±45.23µs -0.07%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.95ms 0.00%
put_and_commit/mem_store/5 295.9±24.48µs 298.0±27.91µs -0.70%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.06ms 2.9±0.07ms 0.00%
query_block/query_block_in(10)_times(1000) 29.3±0.58ms 29.3±0.80ms 0.00%
query_block/query_block_in(10)_times(10000) 293.3±3.81ms 292.9±4.86ms +0.14%
query_block/query_block_in(1000)_times(100) 912.0±5.08µs 927.7±5.28µs -1.69%
query_block/query_block_in(1000)_times(1000) 9.1±0.05ms 9.3±0.04ms -2.15%
query_block/query_block_in(1000)_times(10000) 91.5±0.33ms 93.6±0.59ms -2.24%
storage_transaction 74.3±3.56ms 80.6±4.89ms -7.82%
vm/transaction_execution/1 326.7±0.61ms 326.0±0.98ms +0.21%
vm/transaction_execution/10 106.4±0.26ms 106.2±0.32ms +0.19%
vm/transaction_execution/20 99.5±0.29ms 100.7±3.25ms -1.19%
vm/transaction_execution/5 128.4±0.23ms 128.4±0.36ms 0.00%
vm/transaction_execution/50 114.3±0.30ms 114.4±1.48ms -0.09%

@sanlee42 sanlee42 merged commit 63624e5 into master Jul 12, 2021
@sanlee42 sanlee42 deleted the cleanup_auth_key branch July 12, 2021 01:23
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants