Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accumulator] Fix bug for get txn info from chain #2689

Merged
merged 1 commit into from
Jul 9, 2021
Merged

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Jul 9, 2021

resolve #2686

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #2689 (3f0d908) into master (7e74431) will increase coverage by 0.23%.
The diff coverage is 11.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
+ Coverage   31.92%   32.14%   +0.23%     
==========================================
  Files         506      506              
  Lines       44171    44171              
  Branches    19656    19654       -2     
==========================================
+ Hits        14098    14196      +98     
+ Misses      16220    15973     -247     
- Partials    13853    14002     +149     
Flag Coverage Δ
unittests 32.14% <11.77%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commons/accumulator/src/accumulator_test.rs 25.36% <0.00%> (ø)
commons/accumulator/src/lib.rs 57.61% <ø> (-0.28%) ⬇️
chain/src/chain.rs 35.84% <10.00%> (+4.62%) ⬆️
commons/accumulator/src/tree.rs 46.35% <100.00%> (ø)
sync/src/announcement/mod.rs 10.23% <0.00%> (-7.95%) ⬇️
network-rpc/api/src/lib.rs 17.15% <0.00%> (-3.80%) ⬇️
sync/src/verified_rpc_client.rs 14.86% <0.00%> (-3.46%) ⬇️
txpool/src/tx_pool_service_impl.rs 41.96% <0.00%> (-2.29%) ⬇️
commons/timeout-join-handler/src/lib.rs 40.43% <0.00%> (-2.12%) ⬇️
network-rpc/src/rpc.rs 16.03% <0.00%> (-1.92%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e74431...3f0d908. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 9, 2021

Benchmark for 3e011bb

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.2±0.11ms 2.1±0.11ms +4.76%
block_apply/block_apply_10 416.8±3.08ms 407.0±4.53ms +2.41%
block_apply/block_apply_1000 41.9±0.25s 42.0±0.22s -0.24%
get_with_proof/db_store 38.4±0.25µs 38.3±0.36µs +0.26%
get_with_proof/mem_store 31.9±0.40µs 31.5±0.24µs +1.27%
put_and_commit/db_store/1 1179.6±58.20µs 1204.1±64.31µs -2.03%
put_and_commit/db_store/10 2.3±0.35ms 2.3±0.38ms 0.00%
put_and_commit/db_store/100 9.3±0.64ms 9.3±0.66ms 0.00%
put_and_commit/db_store/5 1838.8±181.63µs 1866.8±165.55µs -1.50%
put_and_commit/db_store/50 5.5±0.64ms 5.5±0.70ms 0.00%
put_and_commit/mem_store/1 63.4±5.56µs 63.6±5.57µs -0.31%
put_and_commit/mem_store/10 591.6±45.13µs 588.2±45.92µs +0.58%
put_and_commit/mem_store/100 5.8±0.83ms 5.8±0.83ms 0.00%
put_and_commit/mem_store/5 299.4±25.09µs 298.6±24.20µs +0.27%
put_and_commit/mem_store/50 2.9±0.19ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.0±0.12ms 2.9±0.06ms +3.45%
query_block/query_block_in(10)_times(1000) 29.5±0.67ms 28.9±0.49ms +2.08%
query_block/query_block_in(10)_times(10000) 290.6±3.84ms 293.0±4.26ms -0.82%
query_block/query_block_in(1000)_times(100) 909.8±4.23µs 916.5±3.60µs -0.73%
query_block/query_block_in(1000)_times(1000) 9.1±0.12ms 9.2±0.08ms -1.09%
query_block/query_block_in(1000)_times(10000) 93.2±0.64ms 91.3±0.43ms +2.08%
storage_transaction 44.5±2.72ms 44.5±2.64ms 0.00%
vm/transaction_execution/1 326.1±1.58ms 327.4±3.12ms -0.40%
vm/transaction_execution/10 106.3±0.15ms 106.4±0.26ms -0.09%
vm/transaction_execution/20 100.1±2.32ms 99.9±0.99ms +0.20%
vm/transaction_execution/5 128.6±0.54ms 128.8±0.76ms -0.16%
vm/transaction_execution/50 114.0±0.85ms 114.9±2.28ms -0.78%

@jolestar jolestar merged commit 8021ba3 into master Jul 9, 2021
@jolestar jolestar deleted the fix_get_txn_info branch July 9, 2021 14:46
jolestar added a commit that referenced this pull request Jul 9, 2021
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_transaction_info 返回block_hash为叔块hash
2 participants