Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix move functional-test command #2691

Merged
merged 1 commit into from
Jul 10, 2021
Merged

fix move functional-test command #2691

merged 1 commit into from
Jul 10, 2021

Conversation

nanne007
Copy link
Member

@nanne007 nanne007 commented Jul 9, 2021

No description provided.

@nanne007 nanne007 requested a review from jolestar July 9, 2021 14:33
FunctionalTest {
/// A filter string to determine which tests to run, default to all move test
#[structopt(name = "filter", short = "f", long = "filter")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter 不作为一个 struct opt 了?

@github-actions
Copy link

github-actions bot commented Jul 9, 2021

Benchmark for ba4cc22

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.3±0.14ms 2.2±0.10ms +4.55%
block_apply/block_apply_10 424.6±5.12ms 424.6±12.42ms 0.00%
block_apply/block_apply_1000 43.2±0.56s 43.1±0.71s +0.23%
get_with_proof/db_store 38.6±0.38µs 38.3±0.37µs +0.78%
get_with_proof/mem_store 31.6±0.31µs 31.5±0.36µs +0.32%
put_and_commit/db_store/1 1276.8±70.06µs 1244.6±47.79µs +2.59%
put_and_commit/db_store/10 2.4±0.49ms 2.3±0.50ms +4.35%
put_and_commit/db_store/100 9.6±1.24ms 9.5±0.91ms +1.05%
put_and_commit/db_store/5 1903.7±218.13µs 1959.0±215.80µs -2.82%
put_and_commit/db_store/50 5.7±0.91ms 5.6±0.92ms +1.79%
put_and_commit/mem_store/1 63.1±5.60µs 63.5±5.58µs -0.63%
put_and_commit/mem_store/10 583.7±46.46µs 589.9±48.89µs -1.05%
put_and_commit/mem_store/100 5.8±0.81ms 5.7±0.81ms +1.75%
put_and_commit/mem_store/5 295.7±24.40µs 299.6±25.31µs -1.30%
put_and_commit/mem_store/50 2.9±0.19ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.06ms 2.9±0.07ms 0.00%
query_block/query_block_in(10)_times(1000) 29.2±0.88ms 29.5±0.50ms -1.02%
query_block/query_block_in(10)_times(10000) 294.2±5.60ms 292.6±6.33ms +0.55%
query_block/query_block_in(1000)_times(100) 937.9±5.80µs 949.3±7.22µs -1.20%
query_block/query_block_in(1000)_times(1000) 9.2±0.07ms 9.3±0.05ms -1.08%
query_block/query_block_in(1000)_times(10000) 92.0±0.54ms 93.6±0.47ms -1.71%
storage_transaction 49.5±2.98ms 47.5±3.45ms +4.21%
vm/transaction_execution/1 325.9±2.17ms 326.3±0.72ms -0.12%
vm/transaction_execution/10 106.2±0.74ms 106.5±0.57ms -0.28%
vm/transaction_execution/20 99.3±0.56ms 100.0±1.34ms -0.70%
vm/transaction_execution/5 128.2±0.41ms 128.6±0.35ms -0.31%
vm/transaction_execution/50 113.9±0.71ms 113.9±0.35ms 0.00%

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #2691 (7a25111) into master (7e74431) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2691      +/-   ##
==========================================
+ Coverage   31.92%   32.08%   +0.16%     
==========================================
  Files         506      506              
  Lines       44171    44171              
  Branches    19656    19656              
==========================================
+ Hits        14098    14167      +69     
+ Misses      16220    16089     -131     
- Partials    13853    13915      +62     
Flag Coverage Δ
unittests 32.08% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/functional-tests/src/evaluator.rs 5.63% <ø> (ø)
vm/functional-tests/src/testsuite.rs 0.00% <ø> (ø)
network-rpc/api/src/lib.rs 18.10% <0.00%> (-2.85%) ⬇️
chain/src/verifier/mod.rs 29.32% <0.00%> (-2.58%) ⬇️
network-rpc/src/rpc.rs 16.03% <0.00%> (-1.92%) ⬇️
sync/src/announcement/mod.rs 17.05% <0.00%> (-1.13%) ⬇️
txpool/src/tx_pool_service_impl.rs 43.68% <0.00%> (-0.57%) ⬇️
sync/src/verified_rpc_client.rs 17.83% <0.00%> (-0.49%) ⬇️
network/src/service.rs 32.68% <0.00%> (ø)
network-p2p/types/src/lib.rs 34.41% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e74431...7a25111. Read the comment docs.

@jolestar jolestar merged commit 9c75d76 into master Jul 10, 2021
@jolestar jolestar deleted the move-cli/fix branch July 10, 2021 03:42
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants