Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ExecuteResultView, output more detail info about transaction #2715

Merged
merged 4 commits into from
Jul 15, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Jul 15, 2021

  1. ExecuteResultView 默认会 raw transaction 以及 txn hex,dry run 的 Output, --blocking 模式下,同时输出交易执行后的 transaction info 以及 events。
  2. account sumit-multisig-txn 重命名为 account submit-txn,并支持通过 hex 方式传递参数。
  3. dev package 命令支持 --hex flag,可以输出 package 的 hex string。

@jolestar jolestar linked an issue Jul 15, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #2715 (290c755) into master (5059ceb) will increase coverage by 0.17%.
The diff coverage is 3.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2715      +/-   ##
==========================================
+ Coverage   31.72%   31.89%   +0.17%     
==========================================
  Files         508      508              
  Lines       44509    44544      +35     
  Branches    19797    19807      +10     
==========================================
+ Hits        14117    14202      +85     
+ Misses      16566    16426     -140     
- Partials    13826    13916      +90     
Flag Coverage Δ
unittests 31.89% <3.71%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/indexer/src/lib.rs 62.30% <ø> (ø)
cmd/starcoin/src/cli_state.rs 47.37% <ø> (ø)
cmd/starcoin/src/lib.rs 100.00% <ø> (ø)
rpc/api/src/types.rs 14.10% <0.00%> (+0.17%) ⬆️
rpc/server/src/module/contract_rpc.rs 10.38% <0.00%> (+1.68%) ⬆️
vm/types/src/transaction/mod.rs 53.10% <0.00%> (-1.17%) ⬇️
vm/vm-status-translator/src/lib.rs 1.24% <0.00%> (-1.03%) ⬇️
vm/types/src/sign_message.rs 47.89% <50.00%> (+0.07%) ⬆️
network-rpc/api/src/lib.rs 18.10% <0.00%> (-2.85%) ⬇️
network-rpc/src/rpc.rs 16.03% <0.00%> (-1.92%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5059ceb...290c755. Read the comment docs.

@github-actions
Copy link

Benchmark for b2d2ce2

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.1±0.09ms 2.3±0.12ms -8.70%
block_apply/block_apply_10 412.5±5.73ms 411.1±4.99ms +0.34%
block_apply/block_apply_1000 42.3±0.34s 42.2±0.27s +0.24%
get_with_proof/db_store 38.9±0.32µs 38.2±0.35µs +1.83%
get_with_proof/mem_store 32.2±0.26µs 31.8±0.24µs +1.26%
put_and_commit/db_store/1 1212.1±45.02µs 1210.4±34.45µs +0.14%
put_and_commit/db_store/10 2.3±0.37ms 2.3±0.40ms 0.00%
put_and_commit/db_store/100 9.3±0.66ms 9.4±0.65ms -1.06%
put_and_commit/db_store/5 1908.7±232.85µs 1891.0±166.41µs +0.94%
put_and_commit/db_store/50 5.5±0.63ms 5.6±0.71ms -1.79%
put_and_commit/mem_store/1 63.0±5.59µs 63.3±5.59µs -0.47%
put_and_commit/mem_store/10 588.9±48.60µs 587.8±47.12µs +0.19%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.81ms 0.00%
put_and_commit/mem_store/5 300.9±25.63µs 296.7±24.13µs +1.42%
put_and_commit/mem_store/50 2.9±0.19ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.03ms 3.0±0.06ms -3.33%
query_block/query_block_in(10)_times(1000) 29.4±0.54ms 29.6±0.79ms -0.68%
query_block/query_block_in(10)_times(10000) 295.7±6.08ms 295.9±5.94ms -0.07%
query_block/query_block_in(1000)_times(100) 915.4±4.01µs 933.6±4.87µs -1.95%
query_block/query_block_in(1000)_times(1000) 9.0±0.07ms 9.1±0.06ms -1.10%
query_block/query_block_in(1000)_times(10000) 91.7±0.70ms 92.8±1.19ms -1.19%
storage_transaction 44.8±3.24ms 50.2±4.21ms -10.76%
vm/transaction_execution/1 327.2±1.10ms 327.4±0.93ms -0.06%
vm/transaction_execution/10 106.4±0.17ms 107.0±0.61ms -0.56%
vm/transaction_execution/20 101.3±4.14ms 100.3±0.87ms +1.00%
vm/transaction_execution/5 129.4±1.83ms 129.7±1.49ms -0.23%
vm/transaction_execution/50 115.3±3.35ms 114.6±0.60ms +0.61%

@nanne007 nanne007 merged commit 277e41c into master Jul 15, 2021
@nanne007 nanne007 deleted the cli_txn_view branch July 15, 2021 13:58
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
…starcoinorg#2715)

* [cli] Rename `account submit-multisig-txn` command to `account submit-txn`

* [cli] Refactor ExecuteResultView, output more detail info about transaction.

* fixup

* [cli] `dev package` support output hex string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants