-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pubsub/event decode #2717
Pubsub/event decode #2717
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2717 +/- ##
==========================================
- Coverage 31.92% 31.82% -0.09%
==========================================
Files 508 508
Lines 44572 44650 +78
Branches 19820 19863 +43
==========================================
- Hits 14223 14207 -16
- Misses 16412 16627 +215
+ Partials 13937 13816 -121
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Benchmark for a9c2311Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmd/starcoin/src/dev/subscribe_cmd.rs 命令不受这个改动影响么?另外新增的 EventFilter 过滤条件是不是可以加到 subscribe_cmd 命令的 option 里。
Benchmark for a2681d9Click to view benchmark
|
8e6f4c9
to
0f9be8b
Compare
Benchmark for d8369bdClick to view benchmark
|
Benchmark for 8de13e6Click to view benchmark
|
* support decode event data when subscribing * call contract return json * update on txn event * subscribe cmd * fix short alias
support decode event when subscribe event.
contract call will verify args againist abi, and return json value.