Pubsub/event decode #2717

nanne007 · 2021-07-16T04:06:12Z

support decode event when subscribe event.
contract call will verify args againist abi, and return json value.

codecov · 2021-07-16T04:37:30Z

Codecov Report

Merging #2717 (d1203ef) into master (d0de6cd) will decrease coverage by 0.10%.
The diff coverage is 33.97%.

@@            Coverage Diff             @@
##           master    #2717      +/-   ##
==========================================
- Coverage   31.92%   31.82%   -0.09%     
==========================================
  Files         508      508              
  Lines       44572    44650      +78     
  Branches    19820    19863      +43     
==========================================
- Hits        14223    14207      -16     
- Misses      16412    16627     +215     
+ Partials    13937    13816     -121

Flag	Coverage Δ
unittests	`31.82% <33.97%> (-0.09%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
account/service/src/account_events.rs	`39.03% <0.00%> (ø)`
chain/chain-notify/src/lib.rs	`46.94% <0.00%> (ø)`
chain/chain-notify/src/message.rs	`57.15% <ø> (ø)`
cmd/starcoin/src/dev/tests.rs	`18.78% <0.00%> (+4.05%)`	⬆️
rpc/api/src/chain/mod.rs	`6.25% <ø> (+0.99%)`	⬆️
rpc/api/src/types.rs	`14.44% <0.00%> (+0.34%)`	⬆️
rpc/client/src/pubsub_client.rs	`23.69% <0.00%> (-0.64%)`	⬇️
rpc/server/src/module/chain_rpc.rs	`3.48% <0.00%> (ø)`
rpc/server/src/module/contract_rpc.rs	`7.83% <18.19%> (-2.54%)`	⬇️
rpc/api/src/types/pubsub.rs	`21.43% <20.00%> (-1.21%)`	⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0de6cd...d1203ef. Read the comment docs.

github-actions · 2021-07-16T04:40:49Z

Benchmark for `a9c2311`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	2.3±0.45ms	2.2±0.12ms	+4.55%
block_apply/block_apply_10	411.8±4.40ms	434.0±11.34ms	-5.12%
block_apply/block_apply_1000	42.8±0.70s	44.3±0.56s	-3.39%
get_with_proof/db_store	38.2±0.22µs	38.5±0.38µs	-0.78%
get_with_proof/mem_store	31.4±0.26µs	32.3±0.25µs	-2.79%
put_and_commit/db_store/1	1373.1±101.29µs	1292.6±84.87µs	+6.23%
put_and_commit/db_store/10	2.4±0.37ms	2.3±0.34ms	+4.35%
put_and_commit/db_store/100	9.4±0.90ms	9.4±0.63ms	0.00%
put_and_commit/db_store/5	1983.6±172.78µs	1970.8±164.11µs	+0.65%
put_and_commit/db_store/50	5.7±0.73ms	5.6±0.69ms	+1.79%
put_and_commit/mem_store/1	63.2±5.58µs	63.1±5.56µs	+0.16%
put_and_commit/mem_store/10	583.7±46.39µs	587.3±46.55µs	-0.61%
put_and_commit/mem_store/100	5.7±0.89ms	5.7±0.82ms	0.00%
put_and_commit/mem_store/5	296.7±26.26µs	295.8±24.30µs	+0.30%
put_and_commit/mem_store/50	2.9±0.18ms	2.9±0.19ms	0.00%
query_block/query_block_in(10)_times(100)	2.9±0.09ms	2.9±0.05ms	0.00%
query_block/query_block_in(10)_times(1000)	29.1±0.48ms	29.3±0.40ms	-0.68%
query_block/query_block_in(10)_times(10000)	293.6±5.04ms	293.2±5.40ms	+0.14%
query_block/query_block_in(1000)_times(100)	901.8±7.37µs	897.9±9.06µs	+0.43%
query_block/query_block_in(1000)_times(1000)	9.0±0.05ms	9.0±0.02ms	0.00%
query_block/query_block_in(1000)_times(10000)	89.6±0.43ms	91.6±0.51ms	-2.18%
storage_transaction	50.5±4.43ms	46.9±3.95ms	+7.68%
vm/transaction_execution/1	326.4±1.16ms	327.4±4.06ms	-0.31%
vm/transaction_execution/10	106.3±0.27ms	106.6±0.55ms	-0.28%
vm/transaction_execution/20	100.1±0.88ms	99.7±0.20ms	+0.40%
vm/transaction_execution/5	128.5±0.34ms	128.7±0.27ms	-0.16%
vm/transaction_execution/50	114.5±0.66ms	116.1±6.03ms	-1.38%

rpc/api/src/types.rs

jolestar

LGTM

jolestar

cmd/starcoin/src/dev/subscribe_cmd.rs 命令不受这个改动影响么？另外新增的 EventFilter 过滤条件是不是可以加到 subscribe_cmd 命令的 option 里。

github-actions · 2021-07-16T06:31:26Z

Benchmark for `a2681d9`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	2.1±0.11ms	2.2±0.59ms	-4.55%
block_apply/block_apply_10	415.7±7.78ms	412.7±15.50ms	+0.73%
block_apply/block_apply_1000	42.1±0.14s	41.9±0.13s	+0.48%
get_with_proof/db_store	38.1±0.30µs	38.2±0.43µs	-0.26%
get_with_proof/mem_store	31.6±0.25µs	31.7±0.19µs	-0.32%
put_and_commit/db_store/1	1210.2±66.34µs	1195.7±55.23µs	+1.21%
put_and_commit/db_store/10	2.3±0.35ms	2.2±0.38ms	+4.55%
put_and_commit/db_store/100	9.3±0.66ms	9.3±0.54ms	0.00%
put_and_commit/db_store/5	1879.9±160.81µs	1857.6±165.71µs	+1.20%
put_and_commit/db_store/50	5.6±0.72ms	5.6±0.67ms	0.00%
put_and_commit/mem_store/1	62.9±5.64µs	63.1±5.58µs	-0.32%
put_and_commit/mem_store/10	584.7±45.84µs	590.6±46.42µs	-1.00%
put_and_commit/mem_store/100	5.7±0.80ms	5.8±0.80ms	-1.72%
put_and_commit/mem_store/5	295.2±24.11µs	299.0±23.85µs	-1.27%
put_and_commit/mem_store/50	2.9±0.18ms	2.9±0.19ms	0.00%
query_block/query_block_in(10)_times(100)	2.9±0.10ms	3.0±0.06ms	-3.33%
query_block/query_block_in(10)_times(1000)	29.5±0.46ms	29.6±0.55ms	-0.34%
query_block/query_block_in(10)_times(10000)	297.2±7.15ms	294.3±4.21ms	+0.99%
query_block/query_block_in(1000)_times(100)	922.6±5.79µs	905.5±4.56µs	+1.89%
query_block/query_block_in(1000)_times(1000)	9.2±0.06ms	9.1±0.13ms	+1.10%
query_block/query_block_in(1000)_times(10000)	93.5±0.57ms	90.8±0.29ms	+2.97%
storage_transaction	44.4±3.01ms	44.5±3.11ms	-0.22%
vm/transaction_execution/1	326.3±0.86ms	327.4±1.44ms	-0.34%
vm/transaction_execution/10	106.9±0.75ms	107.1±1.03ms	-0.19%
vm/transaction_execution/20	99.8±0.26ms	100.1±0.35ms	-0.30%
vm/transaction_execution/5	128.9±1.19ms	128.9±0.35ms	0.00%
vm/transaction_execution/50	114.6±0.91ms	114.9±1.02ms	-0.26%

github-actions · 2021-07-16T08:15:03Z

Benchmark for `d8369bd`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	2.3±0.17ms	2.3±0.13ms	0.00%
block_apply/block_apply_10	432.8±6.70ms	437.4±18.20ms	-1.05%
block_apply/block_apply_1000	44.3±0.20s	48.3±1.56s	-8.28%
get_with_proof/db_store	37.9±0.39µs	38.4±0.74µs	-1.30%
get_with_proof/mem_store	31.5±0.29µs	31.5±0.36µs	0.00%
put_and_commit/db_store/1	1332.3±88.93µs	1445.9±150.34µs	-7.86%
put_and_commit/db_store/10	2.4±0.39ms	2.6±0.43ms	-7.69%
put_and_commit/db_store/100	9.5±0.63ms	9.5±0.64ms	0.00%
put_and_commit/db_store/5	1981.9±191.02µs	2.1±0.19ms	-5.62%
put_and_commit/db_store/50	5.6±0.71ms	5.8±0.68ms	-3.45%
put_and_commit/mem_store/1	63.5±5.58µs	63.3±5.52µs	+0.32%
put_and_commit/mem_store/10	590.7±48.31µs	586.1±48.70µs	+0.78%
put_and_commit/mem_store/100	5.7±0.80ms	5.7±0.81ms	0.00%
put_and_commit/mem_store/5	298.4±25.30µs	295.5±24.13µs	+0.98%
put_and_commit/mem_store/50	2.9±0.19ms	2.9±0.18ms	0.00%
query_block/query_block_in(10)_times(100)	2.9±0.06ms	3.0±0.06ms	-3.33%
query_block/query_block_in(10)_times(1000)	29.4±0.32ms	29.6±0.70ms	-0.68%
query_block/query_block_in(10)_times(10000)	292.0±4.51ms	296.8±1.95ms	-1.62%
query_block/query_block_in(1000)_times(100)	910.2±3.45µs	961.3±3.47µs	-5.32%
query_block/query_block_in(1000)_times(1000)	9.1±0.03ms	9.5±0.04ms	-4.21%
query_block/query_block_in(1000)_times(10000)	91.0±0.22ms	93.1±0.65ms	-2.26%
storage_transaction	50.3±5.40ms	55.6±5.31ms	-9.53%
vm/transaction_execution/1	329.0±1.68ms	326.2±1.04ms	+0.86%
vm/transaction_execution/10	107.3±0.97ms	109.2±7.53ms	-1.74%
vm/transaction_execution/20	100.6±1.50ms	100.8±2.90ms	-0.20%
vm/transaction_execution/5	129.4±0.97ms	128.7±0.58ms	+0.54%
vm/transaction_execution/50	114.5±0.37ms	114.7±1.82ms	-0.17%

github-actions · 2021-07-16T09:24:27Z

Benchmark for `8de13e6`

Click to view benchmark

Test	PR Benchmark	Master Benchmark	%
accumulator_append	2.3±0.09ms	2.4±0.30ms	-4.17%
block_apply/block_apply_10	444.1±8.85ms	431.6±3.71ms	+2.90%
block_apply/block_apply_1000	45.2±1.03s	44.8±1.19s	+0.89%
get_with_proof/db_store	38.1±0.30µs	38.0±0.35µs	+0.26%
get_with_proof/mem_store	31.8±0.28µs	31.6±0.35µs	+0.63%
put_and_commit/db_store/1	1305.3±36.98µs	1337.7±39.67µs	-2.42%
put_and_commit/db_store/10	2.4±0.36ms	2.4±0.36ms	0.00%
put_and_commit/db_store/100	9.4±0.64ms	9.6±0.85ms	-2.08%
put_and_commit/db_store/5	1942.1±184.15µs	2.0±0.26ms	-2.90%
put_and_commit/db_store/50	5.6±0.68ms	5.7±0.66ms	-1.75%
put_and_commit/mem_store/1	63.7±5.61µs	63.4±5.57µs	+0.47%
put_and_commit/mem_store/10	599.2±44.94µs	586.8±46.56µs	+2.11%
put_and_commit/mem_store/100	5.7±0.81ms	5.7±0.82ms	0.00%
put_and_commit/mem_store/5	298.4±24.47µs	296.5±24.29µs	+0.64%
put_and_commit/mem_store/50	2.9±0.19ms	2.9±0.18ms	0.00%
query_block/query_block_in(10)_times(100)	2.9±0.06ms	2.9±0.08ms	0.00%
query_block/query_block_in(10)_times(1000)	29.1±0.53ms	29.5±0.33ms	-1.36%
query_block/query_block_in(10)_times(10000)	290.0±6.00ms	293.5±6.33ms	-1.19%
query_block/query_block_in(1000)_times(100)	907.9±4.49µs	921.8±3.68µs	-1.51%
query_block/query_block_in(1000)_times(1000)	9.1±0.04ms	9.1±0.03ms	0.00%
query_block/query_block_in(1000)_times(10000)	90.5±0.70ms	90.5±0.28ms	0.00%
storage_transaction	48.1±2.84ms	50.5±4.34ms	-4.75%
vm/transaction_execution/1	326.0±1.16ms	326.0±1.32ms	0.00%
vm/transaction_execution/10	106.6±1.20ms	106.6±0.97ms	0.00%
vm/transaction_execution/20	99.5±0.36ms	99.5±0.24ms	0.00%
vm/transaction_execution/5	128.7±0.86ms	128.7±0.43ms	0.00%
vm/transaction_execution/50	113.9±0.37ms	114.8±1.61ms	-0.78%

* support decode event data when subscribing * call contract return json * update on txn event * subscribe cmd * fix short alias

nanne007 requested a review from jolestar July 16, 2021 04:06

jolestar reviewed Jul 16, 2021

View reviewed changes

rpc/api/src/types.rs Outdated Show resolved Hide resolved

This was linked to issues Jul 16, 2021

[rpc] contract.call_v2 #2703

Closed

Transaction argument and event display for human #2556

Closed

jolestar approved these changes Jul 16, 2021

View reviewed changes

jolestar reviewed Jul 16, 2021

View reviewed changes

nanne007 added 4 commits July 16, 2021 15:19

support decode event data when subscribing

a2d0616

call contract return json

2f6bc62

update on txn event

aa57b43

subscribe cmd

0f9be8b

nanne007 force-pushed the pubsub/event-decode branch from 8e6f4c9 to 0f9be8b Compare July 16, 2021 07:31

fix short alias

d1203ef

jolestar merged commit b1d4ba8 into master Jul 16, 2021

jolestar deleted the pubsub/event-decode branch July 16, 2021 10:11

naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021

Pubsub/event decode (starcoinorg#2717)

7906802

* support decode event data when subscribing * call contract return json * update on txn event * subscribe cmd * fix short alias

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pubsub/event decode #2717

Pubsub/event decode #2717

nanne007 commented Jul 16, 2021

codecov bot commented Jul 16, 2021 •

edited

Loading

github-actions bot commented Jul 16, 2021

jolestar left a comment

jolestar left a comment

github-actions bot commented Jul 16, 2021

github-actions bot commented Jul 16, 2021

github-actions bot commented Jul 16, 2021

Pubsub/event decode #2717

Pubsub/event decode #2717

Conversation

nanne007 commented Jul 16, 2021

codecov bot commented Jul 16, 2021 • edited Loading

Codecov Report

github-actions bot commented Jul 16, 2021

Benchmark for a9c2311

jolestar left a comment

Choose a reason for hiding this comment

jolestar left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 16, 2021

Benchmark for a2681d9

github-actions bot commented Jul 16, 2021

Benchmark for d8369bd

github-actions bot commented Jul 16, 2021

Benchmark for 8de13e6

codecov bot commented Jul 16, 2021 •

edited

Loading

Benchmark for `a9c2311`

Benchmark for `a2681d9`

Benchmark for `d8369bd`

Benchmark for `8de13e6`