Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[abi] Fix resolve new module by code self dependency bug. #2726

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Jul 19, 2021

修复一个 resolve 链上不存在的 module 时的 bug,该 module 需要预先放入 module cache,否则 module 中的类型引用当前 module 的其他类型时,resolve 会报错。

@jolestar jolestar requested a review from nanne007 July 19, 2021 08:24
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #2726 (3018b46) into master (9c605f7) will increase coverage by 0.05%.
The diff coverage is 28.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2726      +/-   ##
==========================================
+ Coverage   31.77%   31.81%   +0.05%     
==========================================
  Files         508      508              
  Lines       44755    44769      +14     
  Branches    19901    19911      +10     
==========================================
+ Hits        14215    14238      +23     
+ Misses      16632    16567      -65     
- Partials    13908    13964      +56     
Flag Coverage Δ
unittests 31.81% <28.58%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
abi/resolver/src/lib.rs 32.21% <27.28%> (+0.65%) ⬆️
vm/resource-viewer/src/resolver.rs 12.80% <33.34%> (+0.51%) ⬆️
sync/src/block_connector/test_write_block_chain.rs 17.76% <0.00%> (-5.60%) ⬇️
network-rpc/api/src/lib.rs 18.10% <0.00%> (-2.85%) ⬇️
commons/timeout-join-handler/src/lib.rs 42.56% <0.00%> (-2.12%) ⬇️
network-rpc/src/rpc.rs 16.03% <0.00%> (-1.92%) ⬇️
network/src/service.rs 31.94% <0.00%> (-1.48%) ⬇️
executor/src/script_function_test.rs 17.45% <0.00%> (-1.16%) ⬇️
sync/src/announcement/mod.rs 17.05% <0.00%> (-1.13%) ⬇️
...ons/forkable-jellyfish-merkle/src/node_type/mod.rs 65.30% <0.00%> (-1.03%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c605f7...3018b46. Read the comment docs.

@github-actions
Copy link

Benchmark for 21832de

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.1±0.12ms 2.3±0.14ms -8.70%
block_apply/block_apply_10 437.3±10.64ms 409.3±11.18ms +6.84%
block_apply/block_apply_1000 43.9±0.73s 41.3±0.22s +6.30%
get_with_proof/db_store 38.6±0.34µs 38.3±0.39µs +0.78%
get_with_proof/mem_store 32.5±0.24µs 31.6±0.59µs +2.85%
put_and_commit/db_store/1 1187.3±59.74µs 1246.7±50.59µs -4.76%
put_and_commit/db_store/10 2.2±0.48ms 2.3±0.47ms -4.35%
put_and_commit/db_store/100 9.4±0.94ms 9.6±1.55ms -2.08%
put_and_commit/db_store/5 1859.9±197.38µs 1864.1±244.13µs -0.23%
put_and_commit/db_store/50 5.6±0.89ms 5.8±1.07ms -3.45%
put_and_commit/mem_store/1 62.5±5.55µs 63.2±5.69µs -1.11%
put_and_commit/mem_store/10 586.3±46.68µs 584.9±45.58µs +0.24%
put_and_commit/mem_store/100 5.7±0.81ms 5.8±0.80ms -1.72%
put_and_commit/mem_store/5 297.5±24.42µs 297.2±23.95µs +0.10%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 2.9±0.09ms 2.9±0.07ms 0.00%
query_block/query_block_in(10)_times(1000) 28.9±0.65ms 29.4±0.42ms -1.70%
query_block/query_block_in(10)_times(10000) 293.1±5.80ms 293.2±2.88ms -0.03%
query_block/query_block_in(1000)_times(100) 910.4±6.83µs 911.4±4.63µs -0.11%
query_block/query_block_in(1000)_times(1000) 9.1±0.05ms 9.0±0.04ms +1.11%
query_block/query_block_in(1000)_times(10000) 90.4±0.24ms 89.8±0.32ms +0.67%
storage_transaction 41.4±2.47ms 50.2±4.93ms -17.53%
vm/transaction_execution/1 328.2±0.82ms 328.2±1.28ms 0.00%
vm/transaction_execution/10 107.1±1.65ms 107.0±1.13ms +0.09%
vm/transaction_execution/20 100.1±0.85ms 100.3±0.94ms -0.20%
vm/transaction_execution/5 129.4±1.74ms 129.0±0.55ms +0.31%
vm/transaction_execution/50 115.2±2.74ms 114.4±0.71ms +0.70%

@nanne007 nanne007 merged commit deabdbc into master Jul 19, 2021
@nanne007 nanne007 deleted the fix_dry_run branch July 19, 2021 10:08
naughtyvenom pushed a commit to naughtyvenom/starcoin that referenced this pull request Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants