Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] change type tag serialize to string in jsonrpc #2737

Merged
merged 2 commits into from
Jul 24, 2021

Conversation

nanne007
Copy link
Member

change type tag serialize to string in jsonrpc.
this will break existing api call.

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #2737 (2b021ca) into master (ea89a33) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2737      +/-   ##
==========================================
- Coverage   31.88%   31.87%   -0.00%     
==========================================
  Files         508      508              
  Lines       44769    44768       -1     
  Branches    19911    19913       +2     
==========================================
- Hits        14270    14267       -3     
+ Misses      16591    16476     -115     
- Partials    13908    14025     +117     
Flag Coverage Δ
unittests 31.87% <25.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rpc/api/src/types.rs 14.29% <0.00%> (ø)
rpc/server/src/module/chain_rpc.rs 3.48% <0.00%> (ø)
cmd/indexer/src/lib.rs 65.00% <100.00%> (+2.71%) ⬆️
network-rpc/core/src/lib.rs 23.53% <0.00%> (-5.88%) ⬇️
commons/service-registry/src/service_actor.rs 38.71% <0.00%> (-4.30%) ⬇️
commons/service-registry/src/service_ref.rs 65.34% <0.00%> (-4.00%) ⬇️
chain/src/verifier/mod.rs 29.32% <0.00%> (-2.58%) ⬇️
commons/accumulator/src/inmemory/mod.rs 62.14% <0.00%> (-1.94%) ⬇️
chain/src/chain.rs 30.66% <0.00%> (-1.71%) ⬇️
sync/src/tasks/mock.rs 44.76% <0.00%> (-1.65%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea89a33...2b021ca. Read the comment docs.

@github-actions
Copy link

Benchmark for d9207e9

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.8±0.19ms 2.7±0.14ms +3.70%
block_apply/block_apply_10 514.6±7.91ms 495.1±15.84ms +3.94%
block_apply/block_apply_1000 51.6±0.83s 50.1±0.43s +2.99%
get_with_proof/db_store 38.7±0.29µs 39.4±0.67µs -1.78%
get_with_proof/mem_store 32.2±0.24µs 32.1±0.24µs +0.31%
put_and_commit/db_store/1 1803.7±146.05µs 1639.5±81.62µs +10.02%
put_and_commit/db_store/10 2.9±0.47ms 2.9±0.44ms 0.00%
put_and_commit/db_store/100 10.1±1.25ms 9.9±1.11ms +2.02%
put_and_commit/db_store/5 2.3±0.18ms 2.2±0.13ms +4.55%
put_and_commit/db_store/50 6.2±0.90ms 6.0±0.87ms +3.33%
put_and_commit/mem_store/1 62.7±5.59µs 63.3±5.48µs -0.95%
put_and_commit/mem_store/10 580.8±45.50µs 587.0±49.31µs -1.06%
put_and_commit/mem_store/100 5.7±0.81ms 5.7±0.81ms 0.00%
put_and_commit/mem_store/5 294.5±23.73µs 296.2±24.59µs -0.57%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.0±0.05ms 2.9±0.05ms +3.45%
query_block/query_block_in(10)_times(1000) 29.1±0.34ms 29.4±0.51ms -1.02%
query_block/query_block_in(10)_times(10000) 293.3±5.46ms 294.9±6.69ms -0.54%
query_block/query_block_in(1000)_times(100) 931.9±3.56µs 911.4±6.47µs +2.25%
query_block/query_block_in(1000)_times(1000) 9.2±0.04ms 9.0±0.05ms +2.22%
query_block/query_block_in(1000)_times(10000) 90.7±0.40ms 89.9±0.40ms +0.89%
storage_transaction 66.6±4.40ms 64.4±3.85ms +3.42%
vm/transaction_execution/1 326.4±2.05ms 325.6±0.92ms +0.25%
vm/transaction_execution/10 106.8±0.94ms 106.7±1.11ms +0.09%
vm/transaction_execution/20 99.5±0.25ms 100.0±0.63ms -0.50%
vm/transaction_execution/5 128.7±0.34ms 128.7±0.73ms 0.00%
vm/transaction_execution/50 114.4±0.93ms 114.2±0.43ms +0.18%

@github-actions
Copy link

Benchmark for 1fa5cab

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.8±0.16ms 2.6±0.11ms +7.69%
block_apply/block_apply_10 488.0±5.39ms 546.4±33.33ms -10.69%
block_apply/block_apply_1000 49.7±0.35s 51.0±1.95s -2.55%
get_with_proof/db_store 38.7±0.50µs 39.2±0.31µs -1.28%
get_with_proof/mem_store 31.9±0.35µs 32.2±0.22µs -0.93%
put_and_commit/db_store/1 1686.2±85.47µs 1704.6±107.05µs -1.08%
put_and_commit/db_store/10 2.8±0.41ms 2.7±0.32ms +3.70%
put_and_commit/db_store/100 9.8±1.01ms 10.1±1.16ms -2.97%
put_and_commit/db_store/5 2.2±0.15ms 2.4±0.34ms -8.33%
put_and_commit/db_store/50 6.1±0.96ms 6.4±0.78ms -4.69%
put_and_commit/mem_store/1 63.1±5.52µs 62.8±5.59µs +0.48%
put_and_commit/mem_store/10 583.6±46.19µs 583.7±46.51µs -0.02%
put_and_commit/mem_store/100 5.7±0.82ms 5.7±0.80ms 0.00%
put_and_commit/mem_store/5 296.9±24.27µs 295.1±23.72µs +0.61%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.0±0.07ms 3.0±0.09ms 0.00%
query_block/query_block_in(10)_times(1000) 29.6±0.57ms 29.1±0.58ms +1.72%
query_block/query_block_in(10)_times(10000) 292.5±2.78ms 294.4±3.97ms -0.65%
query_block/query_block_in(1000)_times(100) 903.0±6.23µs 911.8±6.03µs -0.97%
query_block/query_block_in(1000)_times(1000) 9.2±0.08ms 9.1±0.04ms +1.10%
query_block/query_block_in(1000)_times(10000) 92.7±0.70ms 91.0±0.35ms +1.87%
storage_transaction 65.6±3.59ms 64.2±3.71ms +2.18%
vm/transaction_execution/1 325.8±0.93ms 326.3±1.51ms -0.15%
vm/transaction_execution/10 106.4±0.41ms 106.8±1.17ms -0.37%
vm/transaction_execution/20 99.9±0.38ms 99.8±0.66ms +0.10%
vm/transaction_execution/5 128.9±0.57ms 130.0±4.77ms -0.85%
vm/transaction_execution/50 115.6±2.99ms 114.4±0.57ms +1.05%

@jolestar jolestar merged commit ab93e43 into master Jul 24, 2021
@jolestar jolestar deleted the unify-type-tag-in-rpc branch July 24, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants