Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlib: auto accept token #2746

Merged
merged 2 commits into from
Jul 28, 2021
Merged

stdlib: auto accept token #2746

merged 2 commits into from
Jul 28, 2021

Conversation

nanne007
Copy link
Member

@nanne007 nanne007 commented Jul 27, 2021

It depends on #2745 . the PR is to make the changes clear.

@nanne007
Copy link
Member Author

close #2741

@nanne007 nanne007 requested a review from jolestar July 27, 2021 13:41
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #2746 (47ecde2) into stdlib/small-fix (248228e) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           stdlib/small-fix    #2746      +/-   ##
====================================================
- Coverage             31.89%   31.87%   -0.02%     
====================================================
  Files                   508      508              
  Lines                 44774    44774              
  Branches              19930    19930              
====================================================
- Hits                  14276    14267       -9     
- Misses                16511    16541      +30     
+ Partials              13987    13966      -21     
Flag Coverage Δ
unittests 31.87% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
consensus/src/consensus.rs 43.75% <0.00%> (-15.62%) ⬇️
executor/src/script_function_test.rs 11.63% <0.00%> (-6.97%) ⬇️
types/src/block.rs 54.43% <0.00%> (-0.32%) ⬇️
sync/src/block_connector/test_illegal_block.rs 15.39% <0.00%> (-0.17%) ⬇️
miner/src/create_block_template/mod.rs 42.39% <0.00%> (ø)
network/src/service.rs 32.18% <0.00%> (+0.25%) ⬆️
...etwork-p2p/src/protocol/generic_proto/behaviour.rs 20.74% <0.00%> (+0.27%) ⬆️
chain/src/verifier/mod.rs 31.90% <0.00%> (+0.87%) ⬆️
network-p2p/src/peer_info.rs 47.23% <0.00%> (+2.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 248228e...47ecde2. Read the comment docs.

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

需要补充:

set_auto_accept_token 需要提供一个 Script。原来 Account 相关的 Script 没有抽取一个单独的 AccountScripts,导致 Account 内部 public fun 的方法名和 Script冲突,看要不要抽取出一个单独的 AccountScripts。

@jolestar jolestar linked an issue Jul 28, 2021 that may be closed by this pull request
@nanne007 nanne007 merged commit 47ecde2 into stdlib/small-fix Jul 28, 2021
@nanne007 nanne007 deleted the auto-accept-token branch July 28, 2021 02:13
@nanne007
Copy link
Member Author

代码我放到 #2745 了。这个close 掉。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[stdlib] Support auto accept token
2 participants