Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Math.mul_div bugfix #2775

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Conversation

xfhxfh1212
Copy link
Contributor

fix wrong caculation

@jolestar
Copy link
Member

jolestar commented Aug 10, 2021

@xfhxfh1212 thanks!

修改后需要在 vm/stdlib 和 genesis 目录下运行 cargo run,编译 stdlib 和生成 genesis, 然后把生成的文件也提交上来。

@jolestar jolestar requested a review from nanne007 August 10, 2021 01:42
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #2775 (e3b23c3) into master (913cc81) will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2775      +/-   ##
==========================================
+ Coverage   31.58%   31.81%   +0.24%     
==========================================
  Files         508      508              
  Lines       44778    44778              
  Branches    19929    19929              
==========================================
+ Hits        14139    14242     +103     
+ Misses      16991    16751     -240     
- Partials    13648    13785     +137     
Flag Coverage Δ
unittests 31.81% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commons/timeout-join-handler/src/lib.rs 40.43% <0.00%> (-4.25%) ⬇️
node/src/lib.rs 18.75% <0.00%> (ø)
types/src/peer_info.rs 51.56% <0.00%> (ø)
network/api/src/tests.rs 22.06% <0.00%> (ø)
network-p2p/src/protocol.rs 41.26% <0.00%> (ø)
network-p2p/types/src/lib.rs 34.41% <0.00%> (ø)
miner/src/create_block_template/mod.rs 42.39% <0.00%> (ø)
vm/vm-runtime/src/starcoin_vm.rs 29.29% <0.00%> (+0.14%) ⬆️
...able-jellyfish-merkle/src/jellyfish_merkle_test.rs 19.07% <0.00%> (+0.23%) ⬆️
...etwork-p2p/src/protocol/generic_proto/behaviour.rs 20.74% <0.00%> (+0.27%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913cc81...e3b23c3. Read the comment docs.

@jolestar jolestar merged commit c46ffc8 into starcoinorg:master Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants