Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a node cmd to reset node startup info #2792

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Conversation

nanne007
Copy link
Member

No description provided.

@nanne007 nanne007 requested a review from jolestar August 16, 2021 07:11
@github-actions
Copy link

Benchmark for 89741ed

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.3±0.27ms 2.3±0.30ms 0.00%
block_apply/block_apply_10 425.9±4.36ms 442.3±7.22ms -3.71%
block_apply/block_apply_1000 44.4±0.41s 44.8±0.46s -0.89%
get_with_proof/db_store 38.6±0.34µs 38.5±0.26µs +0.26%
get_with_proof/mem_store 32.0±0.36µs 31.9±1.31µs +0.31%
put_and_commit/db_store/1 1234.4±63.58µs 1373.4±107.03µs -10.12%
put_and_commit/db_store/10 2.4±0.35ms 2.4±0.35ms 0.00%
put_and_commit/db_store/100 9.8±0.91ms 9.7±0.88ms +1.03%
put_and_commit/db_store/5 1933.9±210.36µs 1973.7±157.20µs -2.02%
put_and_commit/db_store/50 5.9±0.61ms 5.8±0.63ms +1.72%
put_and_commit/mem_store/1 63.4±5.62µs 63.1±5.64µs +0.48%
put_and_commit/mem_store/10 586.8±46.40µs 587.8±47.20µs -0.17%
put_and_commit/mem_store/100 5.7±0.34ms 5.8±0.81ms -1.72%
put_and_commit/mem_store/5 298.1±24.16µs 297.7±25.36µs +0.13%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.6±0.14ms 3.6±0.09ms 0.00%
query_block/query_block_in(10)_times(1000) 34.9±0.92ms 35.5±1.26ms -1.69%
query_block/query_block_in(10)_times(10000) 354.7±3.90ms 356.8±6.90ms -0.59%
query_block/query_block_in(1000)_times(100) 916.4±4.00µs 922.0±5.77µs -0.61%
query_block/query_block_in(1000)_times(1000) 9.1±0.06ms 9.2±0.09ms -1.09%
query_block/query_block_in(1000)_times(10000) 91.2±0.31ms 91.5±0.48ms -0.33%
storage_transaction 49.2±3.59ms 49.6±4.18ms -0.81%
vm/transaction_execution/1 351.0±1.17ms 350.2±0.59ms +0.23%
vm/transaction_execution/10 123.9±0.19ms 124.2±1.05ms -0.24%
vm/transaction_execution/20 117.0±0.62ms 117.4±1.54ms -0.34%
vm/transaction_execution/5 147.0±1.26ms 146.9±0.86ms +0.07%
vm/transaction_execution/50 131.6±0.99ms 131.8±1.01ms -0.15%

@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #2792 (d27552d) into master (20b4b0b) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2792      +/-   ##
==========================================
- Coverage   31.78%   31.71%   -0.06%     
==========================================
  Files         509      509              
  Lines       44824    44846      +22     
  Branches    19957    19963       +6     
==========================================
- Hits        14241    14219      -22     
- Misses      16756    16814      +58     
+ Partials    13827    13813      -14     
Flag Coverage Δ
unittests 31.71% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/starcoin/src/lib.rs 100.00% <ø> (ø)
node/api/src/message.rs 0.00% <0.00%> (ø)
node/api/src/node_service.rs 2.57% <0.00%> (-0.29%) ⬇️
node/src/node.rs 12.58% <0.00%> (-0.40%) ⬇️
rpc/api/src/node_manager.rs 0.00% <0.00%> (ø)
rpc/client/src/lib.rs 12.84% <0.00%> (-0.07%) ⬇️
rpc/server/src/module/node_manager_rpc.rs 6.13% <0.00%> (-1.19%) ⬇️
consensus/src/consensus.rs 43.75% <0.00%> (-15.62%) ⬇️
executor/src/readonly_function_call_test.rs 2.99% <0.00%> (-10.44%) ⬇️
commons/service-registry/src/service_ref.rs 65.34% <0.00%> (-4.00%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20b4b0b...d27552d. Read the comment docs.

@nanne007 nanne007 merged commit b543f58 into master Aug 16, 2021
@nanne007 nanne007 deleted the node/reset-node-to-block branch August 16, 2021 08:22
@nanne007 nanne007 added the area:cli Issue about cli. label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:cli Issue about cli.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants