Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a node cmd to delete block #2796

Merged
merged 1 commit into from
Aug 17, 2021
Merged

add a node cmd to delete block #2796

merged 1 commit into from
Aug 17, 2021

Conversation

nanne007
Copy link
Member

No description provided.

@nanne007 nanne007 requested a review from jolestar August 17, 2021 01:40
@github-actions
Copy link

Benchmark for 9a7763a

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.2±0.11ms 2.3±0.14ms -4.35%
block_apply/block_apply_10 419.2±14.65ms 419.7±7.67ms -0.12%
block_apply/block_apply_1000 43.1±0.71s 43.7±0.86s -1.37%
get_with_proof/db_store 38.8±0.50µs 38.2±0.51µs +1.57%
get_with_proof/mem_store 31.6±0.22µs 31.6±0.35µs 0.00%
put_and_commit/db_store/1 1220.2±118.46µs 1229.2±89.09µs -0.73%
put_and_commit/db_store/10 2.3±0.35ms 2.3±0.39ms 0.00%
put_and_commit/db_store/100 9.7±0.98ms 9.8±1.13ms -1.02%
put_and_commit/db_store/5 1888.9±207.19µs 1920.5±161.08µs -1.65%
put_and_commit/db_store/50 5.7±0.71ms 5.8±0.79ms -1.72%
put_and_commit/mem_store/1 63.1±5.58µs 63.4±5.64µs -0.47%
put_and_commit/mem_store/10 585.2±46.73µs 586.8±47.92µs -0.27%
put_and_commit/mem_store/100 5.7±0.82ms 5.8±0.82ms -1.72%
put_and_commit/mem_store/5 296.7±24.19µs 296.7±24.83µs 0.00%
put_and_commit/mem_store/50 2.9±0.19ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.6±0.09ms 3.5±0.08ms +2.86%
query_block/query_block_in(10)_times(1000) 34.8±0.97ms 35.4±0.75ms -1.69%
query_block/query_block_in(10)_times(10000) 354.1±6.04ms 354.3±4.91ms -0.06%
query_block/query_block_in(1000)_times(100) 910.2±8.65µs 913.6±5.74µs -0.37%
query_block/query_block_in(1000)_times(1000) 9.1±0.07ms 9.2±0.07ms -1.09%
query_block/query_block_in(1000)_times(10000) 91.0±1.08ms 91.4±0.63ms -0.44%
storage_transaction 42.1±3.43ms 53.8±4.48ms -21.75%
vm/transaction_execution/1 351.2±0.85ms 350.7±0.69ms +0.14%
vm/transaction_execution/10 124.1±1.09ms 123.7±0.35ms +0.32%
vm/transaction_execution/20 117.4±1.24ms 117.0±1.46ms +0.34%
vm/transaction_execution/5 147.0±0.79ms 146.9±0.91ms +0.07%
vm/transaction_execution/50 131.6±0.54ms 131.6±0.67ms 0.00%

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2796 (172393c) into master (9706885) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2796      +/-   ##
==========================================
- Coverage   31.74%   31.67%   -0.06%     
==========================================
  Files         509      509              
  Lines       44864    44903      +39     
  Branches    19975    19986      +11     
==========================================
- Hits        14236    14219      -17     
- Misses      16807    16843      +36     
- Partials    13821    13841      +20     
Flag Coverage Δ
unittests 31.67% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chain/src/chain.rs 30.77% <0.00%> (+0.12%) ⬆️
cmd/starcoin/src/lib.rs 100.00% <ø> (ø)
node/api/src/message.rs 0.00% <0.00%> (ø)
node/api/src/node_service.rs 2.33% <0.00%> (-0.23%) ⬇️
node/src/node.rs 11.98% <0.00%> (-0.60%) ⬇️
rpc/api/src/node_manager.rs 0.00% <0.00%> (ø)
rpc/client/src/lib.rs 12.60% <0.00%> (-0.07%) ⬇️
rpc/server/src/module/node_manager_rpc.rs 5.27% <0.00%> (-0.85%) ⬇️
storage/src/block/mod.rs 50.00% <0.00%> (-2.75%) ⬇️
storage/src/block_info/mod.rs 100.00% <ø> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9706885...172393c. Read the comment docs.

@github-actions
Copy link

Benchmark for 1863426

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.2±0.14ms 2.2±0.14ms 0.00%
block_apply/block_apply_10 439.1±8.81ms 426.6±4.66ms +2.93%
block_apply/block_apply_1000 43.4±0.72s 42.9±0.67s +1.17%
get_with_proof/db_store 38.7±0.31µs 38.6±0.24µs +0.26%
get_with_proof/mem_store 31.8±0.27µs 31.6±0.26µs +0.63%
put_and_commit/db_store/1 1198.0±92.58µs 1231.9±92.00µs -2.75%
put_and_commit/db_store/10 2.2±0.35ms 2.3±0.34ms -4.35%
put_and_commit/db_store/100 9.8±1.16ms 9.8±0.94ms 0.00%
put_and_commit/db_store/5 1824.8±184.74µs 1875.8±146.54µs -2.72%
put_and_commit/db_store/50 5.7±0.69ms 5.7±0.68ms 0.00%
put_and_commit/mem_store/1 63.2±5.56µs 63.7±5.75µs -0.78%
put_and_commit/mem_store/10 586.1±47.14µs 590.5±47.10µs -0.75%
put_and_commit/mem_store/100 5.7±0.81ms 5.8±0.82ms -1.72%
put_and_commit/mem_store/5 297.1±24.10µs 297.7±24.29µs -0.20%
put_and_commit/mem_store/50 2.9±0.19ms 2.9±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.5±0.09ms 3.6±0.10ms -2.78%
query_block/query_block_in(10)_times(1000) 35.6±1.24ms 35.4±0.52ms +0.56%
query_block/query_block_in(10)_times(10000) 354.2±7.32ms 352.8±8.77ms +0.40%
query_block/query_block_in(1000)_times(100) 910.2±5.33µs 931.5±6.75µs -2.29%
query_block/query_block_in(1000)_times(1000) 9.1±0.07ms 9.3±0.04ms -2.15%
query_block/query_block_in(1000)_times(10000) 91.5±0.28ms 91.8±0.71ms -0.33%
storage_transaction 45.0±4.68ms 43.8±4.42ms +2.74%
vm/transaction_execution/1 355.2±1.23ms 349.8±0.58ms +1.54%
vm/transaction_execution/10 124.9±0.30ms 123.6±0.30ms +1.05%
vm/transaction_execution/20 118.0±1.13ms 116.9±0.26ms +0.94%
vm/transaction_execution/5 148.5±0.77ms 146.7±0.70ms +1.23%
vm/transaction_execution/50 133.0±1.85ms 132.1±1.55ms +0.68%

@nanne007 nanne007 merged commit a5eaca1 into master Aug 17, 2021
@nanne007 nanne007 deleted the cmd/delete-block branch August 17, 2021 03:33
@nanne007 nanne007 added the area:cli Issue about cli. label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:cli Issue about cli.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants