Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vm] Fix batch transfer ScriptFunction builder #2802

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Conversation

jolestar
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #2802 (2b8c0f6) into master (c3d76f5) will increase coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2802      +/-   ##
==========================================
+ Coverage   31.53%   31.67%   +0.15%     
==========================================
  Files         509      509              
  Lines       44903    44909       +6     
  Branches    19986    19985       -1     
==========================================
+ Hits        14154    14221      +67     
+ Misses      17082    16892     -190     
- Partials    13667    13796     +129     
Flag Coverage Δ
unittests 31.67% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/transaction-builder/src/lib.rs 16.07% <0.00%> (-0.25%) ⬇️
commons/service-registry/src/bus/mod.rs 35.30% <0.00%> (-9.80%) ⬇️
sync/src/announcement/mod.rs 10.23% <0.00%> (-6.81%) ⬇️
vm/types/src/time.rs 69.80% <0.00%> (-3.12%) ⬇️
sync/src/verified_rpc_client.rs 14.86% <0.00%> (-2.97%) ⬇️
network-p2p/src/peer_info.rs 44.45% <0.00%> (-2.77%) ⬇️
commons/timeout-join-handler/src/lib.rs 40.43% <0.00%> (-2.12%) ⬇️
network-p2p/src/request_responses.rs 30.96% <0.00%> (-1.91%) ⬇️
state/state-tree/src/state_tree.rs 48.62% <0.00%> (-1.38%) ⬇️
network/src/service_ref.rs 37.34% <0.00%> (-1.33%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d76f5...2b8c0f6. Read the comment docs.

@github-actions
Copy link

Benchmark for ed1827d

Click to view benchmark
Test PR Benchmark Master Benchmark %
accumulator_append 2.9±0.12ms 2.9±0.12ms 0.00%
block_apply/block_apply_10 534.0±5.30ms 553.6±16.99ms -3.54%
block_apply/block_apply_1000 54.8±0.71s 54.8±0.92s 0.00%
get_with_proof/db_store 38.7±0.33µs 38.2±0.41µs +1.31%
get_with_proof/mem_store 31.8±0.25µs 31.6±0.40µs +0.63%
put_and_commit/db_store/1 1931.4±103.47µs 1881.3±99.59µs +2.66%
put_and_commit/db_store/10 3.0±0.41ms 3.0±0.42ms 0.00%
put_and_commit/db_store/100 10.5±1.19ms 10.5±1.24ms 0.00%
put_and_commit/db_store/5 2.5±0.20ms 2.4±0.19ms +4.17%
put_and_commit/db_store/50 6.3±0.83ms 6.2±0.85ms +1.61%
put_and_commit/mem_store/1 63.4±5.60µs 62.9±5.63µs +0.79%
put_and_commit/mem_store/10 587.3±48.70µs 582.9±45.83µs +0.75%
put_and_commit/mem_store/100 5.7±0.82ms 5.7±0.82ms 0.00%
put_and_commit/mem_store/5 295.5±24.35µs 297.6±25.64µs -0.71%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.5±0.12ms 3.6±0.12ms -2.78%
query_block/query_block_in(10)_times(1000) 35.1±1.18ms 35.2±0.68ms -0.28%
query_block/query_block_in(10)_times(10000) 357.4±8.93ms 352.9±8.24ms +1.28%
query_block/query_block_in(1000)_times(100) 910.1±6.39µs 908.7±6.58µs +0.15%
query_block/query_block_in(1000)_times(1000) 9.3±0.04ms 9.1±0.05ms +2.20%
query_block/query_block_in(1000)_times(10000) 93.2±0.58ms 91.8±0.48ms +1.53%
storage_transaction 73.1±3.39ms 73.6±4.05ms -0.68%
vm/transaction_execution/1 351.4±0.83ms 353.6±7.64ms -0.62%
vm/transaction_execution/10 124.2±0.71ms 123.9±0.35ms +0.24%
vm/transaction_execution/20 117.6±1.41ms 116.6±0.44ms +0.86%
vm/transaction_execution/5 146.7±0.31ms 147.1±1.07ms -0.27%
vm/transaction_execution/50 132.3±0.74ms 131.3±0.64ms +0.76%

@nanne007 nanne007 added area:vm Issue about vm bugfix labels Aug 19, 2021
@nanne007 nanne007 merged commit f3fe2f3 into master Aug 19, 2021
@nanne007 nanne007 deleted the fix_batch_transfer branch August 19, 2021 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:vm Issue about vm bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants