Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block relay #2854

Merged
merged 3 commits into from
Sep 6, 2021
Merged

Fix block relay #2854

merged 3 commits into from
Sep 6, 2021

Conversation

sanlee42
Copy link
Member

@sanlee42 sanlee42 commented Sep 6, 2021

No description provided.

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #2854 (f88469b) into master (17787bd) will increase coverage by 0.14%.
The diff coverage is 27.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2854      +/-   ##
==========================================
+ Coverage   31.44%   31.58%   +0.14%     
==========================================
  Files         511      511              
  Lines       45115    45118       +3     
  Branches    20098    20102       +4     
==========================================
+ Hits        14182    14245      +63     
+ Misses      17179    17019     -160     
- Partials    13754    13854     +100     
Flag Coverage Δ
unittests 31.58% <27.28%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
block-relayer/src/block_relayer.rs 23.70% <0.00%> (-0.27%) ⬇️
types/src/cmpact_block.rs 45.17% <60.00%> (-3.22%) ⬇️
executor/src/script_function_test.rs 8.14% <0.00%> (-3.48%) ⬇️
commons/logger/src/lib.rs 26.01% <0.00%> (-0.09%) ⬇️
consensus/src/difficulty.rs 39.54% <0.00%> (ø)
network-p2p/types/src/lib.rs 34.41% <0.00%> (ø)
vm/vm-runtime/src/starcoin_vm.rs 29.10% <0.00%> (+0.14%) ⬆️
sync/src/tasks/mod.rs 26.55% <0.00%> (+0.31%) ⬆️
sync/src/block_connector/write_block_chain.rs 18.97% <0.00%> (+0.44%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17787bd...f88469b. Read the comment docs.

@jolestar jolestar merged commit 06e66d7 into master Sep 6, 2021
@jolestar jolestar deleted the fix_block_relay branch September 6, 2021 15:37
jolestar pushed a commit that referenced this pull request Sep 6, 2021
* [block-relay] Fix expect txn len ensure.

* Fix block relayer

* cargo clippy

Co-authored-by: jolestar <jolestar@gmail.com>
(cherry picked from commit 06e66d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants