Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dime 1.4 #2862

Merged
merged 3 commits into from
Sep 18, 2021
Merged

merge dime 1.4 #2862

merged 3 commits into from
Sep 18, 2021

Conversation

nanne007
Copy link
Member

@nanne007 nanne007 commented Sep 9, 2021

related diem pr starcoinorg/diem#184

changes:

  • vm runtime now support publish bundles
  • abi improvements
  • native functions refactor.
  • adapt to latest compiler api.
  • stdlib now generates v3 bytecodes.

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #2862 (b90a998) into master (2bfc76d) will increase coverage by 0.60%.
The diff coverage is 22.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2862      +/-   ##
==========================================
+ Coverage   31.33%   31.93%   +0.60%     
==========================================
  Files         512      515       +3     
  Lines       45252    45129     -123     
  Branches    20401    20673     +272     
==========================================
+ Hits        14177    14407     +230     
+ Misses      17027    16248     -779     
- Partials    14048    14474     +426     
Flag Coverage Δ
unittests 31.93% <22.83%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
abi/decoder/src/lib.rs 10.24% <0.00%> (ø)
config/src/lib.rs 26.34% <ø> (ø)
...ntrib-contracts/src/eth_state_verifier_test/mod.rs 31.04% <0.00%> (ø)
contrib-contracts/src/genesis_nft_test.rs 33.34% <0.00%> (ø)
contrib-contracts/src/merkle_distributor_test.rs 21.38% <0.00%> (ø)
contrib-contracts/src/starcoin_merkle_test.rs 15.39% <0.00%> (ø)
executor/src/executor.rs 36.37% <ø> (ø)
rpc/api/src/contract_api.rs 17.65% <0.00%> (ø)
rpc/client/src/lib.rs 13.37% <0.00%> (+0.41%) ⬆️
rpc/server/src/module/contract_rpc.rs 7.19% <0.00%> (+0.29%) ⬆️
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bfc76d...b90a998. Read the comment docs.

@nanne007 nanne007 force-pushed the merge-move-1.4 branch 4 times, most recently from 4d85152 to 9e26acc Compare September 10, 2021 02:05
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么 main/barnard 的genesis都变了呢?不应该呀

vm/stdlib/modules/StdlibUpgradeScripts.move Outdated Show resolved Hide resolved
@nanne007
Copy link
Member Author

genesis 变了的问题解决了。 commit 1d734b2

主要原因是 blob -> CompiledModule -> blob 这个过程,会把 v2 的blob 变成 v3 的blob

@nanne007 nanne007 force-pushed the merge-move-1.4 branch 3 times, most recently from f04efd2 to fde2fbc Compare September 15, 2021 02:01
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ABI 相关的接口有变化,测试网测试的时候需要注意一下。

@jolestar jolestar added this to the starcoin-1.7 milestone Sep 18, 2021
@jolestar jolestar added the area:vm Issue about vm label Sep 18, 2021
@nanne007 nanne007 merged commit f5800b7 into master Sep 18, 2021
@nanne007 nanne007 deleted the merge-move-1.4 branch September 18, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:vm Issue about vm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants