Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make vmconfig constants in move code #3019

Merged
merged 3 commits into from
Nov 11, 2021
Merged

make vmconfig constants in move code #3019

merged 3 commits into from
Nov 11, 2021

Conversation

nanne007
Copy link
Member

No description provided.

Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以确认下有没有直接通过 statedb 接口获取 VMConfig 的。

@jolestar jolestar added this to the stdlib-v10 milestone Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #3019 (ae2a240) into master (29e7c5a) will decrease coverage by 0.20%.
The diff coverage is 1.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3019      +/-   ##
==========================================
- Coverage   33.03%   32.84%   -0.19%     
==========================================
  Files         516      516              
  Lines       45795    45823      +28     
  Branches    20875    20891      +16     
==========================================
- Hits        15124    15046      -78     
- Misses      16278    16373      +95     
- Partials    14393    14404      +11     
Flag Coverage Δ
unittests 32.84% <1.97%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/src/genesis_config.rs 53.27% <0.00%> (+0.62%) ⬆️
genesis/src/lib.rs 26.54% <ø> (+0.34%) ⬆️
vm/types/src/on_chain_config/mod.rs 45.21% <ø> (-0.74%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 43.34% <0.00%> (-2.28%) ⬇️
vm/vm-runtime/src/starcoin_vm.rs 33.81% <2.18%> (-3.27%) ⬇️
vm/vm-runtime/src/natives.rs 77.78% <0.00%> (-11.11%) ⬇️
executor/src/block_executor.rs 22.23% <0.00%> (-8.88%) ⬇️
executor/src/executor.rs 50.00% <0.00%> (-8.33%) ⬇️
network-rpc/core/src/lib.rs 23.53% <0.00%> (-5.88%) ⬇️
consensus/src/difficulty.rs 43.03% <0.00%> (-5.81%) ⬇️
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e7c5a...ae2a240. Read the comment docs.

@nanne007 nanne007 merged commit b85acc2 into master Nov 11, 2021
@nanne007 nanne007 deleted the stdlib/vmconfig branch November 11, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants