Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mpm] use integration-tests rather than tests, for avoid conflict with mpm package test #3350

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Apr 18, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

https://github.com/starcoinorg/starcoin-framework/runs/6058959721?check_suite_focus=true

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #3350 (08e1e30) into master (0cab541) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
- Coverage   32.15%   32.00%   -0.14%     
==========================================
  Files         500      500              
  Lines       46810    46810              
  Branches    21299    21299              
==========================================
- Hits        15045    14978      -67     
- Misses      17587    17765     +178     
+ Partials    14178    14067     -111     
Flag Coverage Δ
unittests 32.00% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/move-package-manager/src/lib.rs 50.00% <ø> (ø)
vm/types/src/language_storage_ext.rs 37.50% <0.00%> (-12.50%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 35.00% <0.00%> (-11.66%) ⬇️
consensus/src/dummy.rs 69.57% <0.00%> (-8.69%) ⬇️
...ccount_config/resources/module_upgrade_strategy.rs 34.29% <0.00%> (-8.57%) ⬇️
abi/decoder/src/lib.rs 1.58% <0.00%> (-7.87%) ⬇️
executor/src/block_executor.rs 33.34% <0.00%> (-6.66%) ⬇️
chain/src/verifier/mod.rs 36.72% <0.00%> (-6.25%) ⬇️
state/state-store-api/src/lib.rs 43.75% <0.00%> (-6.25%) ⬇️
rpc/api/src/contract_api.rs 11.77% <0.00%> (-5.88%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cab541...08e1e30. Read the comment docs.

@github-actions
Copy link

Benchmark for 2fae976

Click to view benchmark
Test Base PR %
accumulator_append 589.3±13.27µs 579.6±19.23µs -1.65%
block_apply/block_apply_10 263.0±1.28ms 262.1±1.82ms -0.34%
block_apply/block_apply_1000 26.7±0.02s 26.7±0.02s 0.00%
get_with_proof/db_store 36.3±1.64µs 36.2±0.54µs -0.28%
get_with_proof/mem_store 31.0±0.21µs 31.0±0.23µs 0.00%
put_and_commit/db_store/1 95.1±4.87µs 96.0±5.32µs +0.95%
put_and_commit/db_store/10 856.6±35.09µs 849.6±41.24µs -0.82%
put_and_commit/db_store/100 7.3±0.32ms 7.4±0.31ms +1.37%
put_and_commit/db_store/5 433.0±22.39µs 436.1±22.75µs +0.72%
put_and_commit/db_store/50 3.8±0.18ms 3.8±0.18ms 0.00%
put_and_commit/mem_store/1 61.6±5.65µs 62.1±5.66µs +0.81%
put_and_commit/mem_store/10 573.5±48.63µs 576.4±47.31µs +0.51%
put_and_commit/mem_store/100 5.6±0.81ms 5.7±0.82ms +1.79%
put_and_commit/mem_store/5 292.0±25.36µs 290.9±24.41µs -0.38%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.16ms 3.9±0.14ms 0.00%
query_block/query_block_in(10)_times(1000) 38.5±0.95ms 38.0±1.16ms -1.30%
query_block/query_block_in(10)_times(10000) 381.2±10.90ms 387.8±5.59ms +1.73%
query_block/query_block_in(1000)_times(100) 938.2±9.21µs 954.2±7.08µs +1.71%
query_block/query_block_in(1000)_times(1000) 9.4±0.06ms 9.5±0.08ms +1.06%
query_block/query_block_in(1000)_times(10000) 93.9±0.58ms 95.3±0.92ms +1.49%
storage_transaction 1087.0±332.35µs 1060.4±281.00µs -2.45%
vm/transaction_execution/1 309.9±0.85ms 309.6±0.84ms -0.10%
vm/transaction_execution/10 97.9±0.36ms 98.1±0.73ms +0.20%
vm/transaction_execution/20 91.5±0.62ms 91.5±0.45ms 0.00%
vm/transaction_execution/5 119.3±0.46ms 119.2±0.32ms -0.08%
vm/transaction_execution/50 105.7±0.31ms 105.7±0.43ms 0.00%

@xudon9 xudon9 merged commit 2021a4f into master Apr 19, 2022
@xudon9 xudon9 deleted the mpm_integration_test_fix branch April 19, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants