Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] improve package manager detection mechanism #3412

Merged
merged 1 commit into from
May 19, 2022

Conversation

jiangying000
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • [x ] Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #3410

What is the new behavior?

  • detect by release first

Other information

port from move-language/move#146

improve Package Manager detection on linux in scripts/dev_setup.sh
port from move-language/move#146
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #3412 (f80fe22) into master (062b99d) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3412      +/-   ##
==========================================
+ Coverage   31.83%   31.87%   +0.05%     
==========================================
  Files         500      500              
  Lines       46809    46809              
  Branches    21304    21307       +3     
==========================================
+ Hits        14898    14917      +19     
+ Misses      17774    17693      -81     
- Partials    14137    14199      +62     
Flag Coverage Δ
unittests 31.87% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commons/accumulator/src/tree.rs 48.77% <0.00%> (-7.88%) ⬇️
...s/forkable-jellyfish-merkle/src/mock_tree_store.rs 32.76% <0.00%> (-3.44%) ⬇️
network/src/worker.rs 30.65% <0.00%> (-3.22%) ⬇️
commons/accumulator/src/tree_store/mock.rs 34.29% <0.00%> (-2.85%) ⬇️
vm/types/src/token/token_value.rs 58.34% <0.00%> (-2.77%) ⬇️
storage/src/db_storage/mod.rs 45.54% <0.00%> (-2.12%) ⬇️
account/src/account_storage.rs 51.25% <0.00%> (-1.99%) ⬇️
network-rpc/src/lib.rs 28.34% <0.00%> (-1.66%) ⬇️
vm/types/src/token/stc.rs 64.71% <0.00%> (-1.47%) ⬇️
network-p2p/src/service.rs 29.66% <0.00%> (-1.39%) ⬇️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88d3f51...f80fe22. Read the comment docs.

@jolestar jolestar merged commit e354202 into starcoinorg:master May 19, 2022
Copy link
Collaborator

@yourmoonlight yourmoonlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants