Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] Prepare release v1.12.3 #3692

Merged
merged 1 commit into from
Aug 29, 2022
Merged

[release] Prepare release v1.12.3 #3692

merged 1 commit into from
Aug 29, 2022

Conversation

jolestar
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #3692 (9c2aecf) into master (8719732) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3692      +/-   ##
==========================================
- Coverage   28.34%   28.33%   -0.00%     
==========================================
  Files         588      588              
  Lines       50412    50412              
  Branches    23657    23644      -13     
==========================================
- Hits        14283    14278       -5     
+ Misses      22207    22169      -38     
- Partials    13922    13965      +43     
Flag Coverage Δ
unittests 28.33% <ø> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/transaction-builder/src/lib.rs 16.63% <0.00%> (-7.57%) ⬇️
vm/natives/src/vector.rs 12.50% <0.00%> (-4.16%) ⬇️
storage/src/cache_storage/mod.rs 38.28% <0.00%> (-2.46%) ⬇️
config/src/rpc_config.rs 42.60% <0.00%> (-2.16%) ⬇️
...s/forkable-jellyfish-merkle/src/mock_tree_store.rs 27.59% <0.00%> (-1.72%) ⬇️
vm/types/src/token/stc.rs 63.24% <0.00%> (-1.47%) ⬇️
network-p2p/src/protocol.rs 42.71% <0.00%> (-1.38%) ⬇️
...ns/forkable-jellyfish-merkle/src/tree_cache/mod.rs 70.24% <0.00%> (-1.19%) ⬇️
storage/src/metrics.rs 50.59% <0.00%> (-1.17%) ⬇️
consensus/src/difficulty.rs 41.18% <0.00%> (-1.17%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8719732...9c2aecf. Read the comment docs.

@github-actions
Copy link

Benchmark for 6eb48f9

Click to view benchmark
Test Base PR %
accumulator_append 604.8±16.70µs 601.1±28.47µs -0.61%
block_apply/block_apply_10 629.3±1.50ms 629.7±1.15ms +0.06%
block_apply/block_apply_1000 64.2±0.04s 64.7±0.36s +0.78%
get_with_proof/db_store 36.1±0.62µs 35.9±0.30µs -0.55%
get_with_proof/mem_store 31.4±0.30µs 31.4±0.18µs 0.00%
put_and_commit/db_store/1 94.8±4.55µs 97.2±5.13µs +2.53%
put_and_commit/db_store/10 843.9±38.28µs 851.4±40.37µs +0.89%
put_and_commit/db_store/100 7.3±0.28ms 7.3±0.31ms 0.00%
put_and_commit/db_store/5 435.2±19.83µs 433.8±20.72µs -0.32%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 61.5±5.64µs 61.4±5.63µs -0.16%
put_and_commit/mem_store/10 574.1±46.70µs 575.8±47.25µs +0.30%
put_and_commit/mem_store/100 5.6±0.82ms 5.6±0.82ms 0.00%
put_and_commit/mem_store/5 290.9±25.39µs 292.3±25.50µs +0.48%
put_and_commit/mem_store/50 2.8±0.19ms 2.9±0.20ms +3.57%
query_block/query_block_in(10)_times(100) 5.5±0.30ms 5.4±0.13ms -1.82%
query_block/query_block_in(10)_times(1000) 53.6±2.14ms 54.8±1.49ms +2.24%
query_block/query_block_in(10)_times(10000) 538.6±17.35ms 543.6±13.30ms +0.93%
query_block/query_block_in(1000)_times(100) 992.3±7.14µs 1012.5±9.41µs +2.04%
query_block/query_block_in(1000)_times(1000) 10.0±0.08ms 10.1±0.17ms +1.00%
query_block/query_block_in(1000)_times(10000) 100.0±1.75ms 101.4±1.01ms +1.40%
storage_transaction 1102.8±328.08µs 1090.3±337.32µs -1.13%
vm/transaction_execution/1 706.4±1.10ms 708.2±1.01ms +0.25%
vm/transaction_execution/10 176.1±0.44ms 177.2±1.58ms +0.62%
vm/transaction_execution/20 152.9±2.12ms 152.8±1.11ms -0.07%
vm/transaction_execution/5 232.9±1.01ms 233.5±0.57ms +0.26%
vm/transaction_execution/50 167.5±3.63ms 166.6±0.73ms -0.54%

@jolestar jolestar merged commit 8bd77a6 into master Aug 29, 2022
@jolestar jolestar deleted the release/v1.12.3 branch August 29, 2022 01:01
@jolestar jolestar restored the release/v1.12.3 branch August 30, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants