Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade StarcoinFramework to latest #3718

Closed
wants to merge 3 commits into from
Closed

Conversation

WGB5445
Copy link
Contributor

@WGB5445 WGB5445 commented Sep 6, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Benchmark for 93af2f0

Click to view benchmark
Test Base PR %
accumulator_append 605.6±27.50µs 603.5±28.42µs -0.35%
block_apply/block_apply_10 634.1±1.73ms 718.0±1.13ms +13.23%
block_apply/block_apply_1000 64.7±0.13s 72.8±0.05s +12.52%
get_with_proof/db_store 36.3±0.52µs 36.4±0.30µs +0.28%
get_with_proof/mem_store 31.4±0.40µs 31.5±0.38µs +0.32%
put_and_commit/db_store/1 95.6±4.90µs 95.7±5.09µs +0.10%
put_and_commit/db_store/10 853.8±38.38µs 857.0±39.96µs +0.37%
put_and_commit/db_store/100 7.3±0.31ms 7.3±0.31ms 0.00%
put_and_commit/db_store/5 436.1±20.91µs 439.2±21.77µs +0.71%
put_and_commit/db_store/50 3.8±0.15ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 61.4±5.64µs 61.7±5.65µs +0.49%
put_and_commit/mem_store/10 574.0±46.92µs 574.3±47.14µs +0.05%
put_and_commit/mem_store/100 5.7±0.82ms 5.6±0.34ms -1.75%
put_and_commit/mem_store/5 290.9±24.66µs 290.0±24.44µs -0.31%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 5.5±0.13ms 5.7±0.16ms +3.64%
query_block/query_block_in(10)_times(1000) 54.5±2.10ms 56.0±2.25ms +2.75%
query_block/query_block_in(10)_times(10000) 552.5±22.23ms 570.9±20.74ms +3.33%
query_block/query_block_in(1000)_times(100) 971.8±9.08µs 1010.4±8.81µs +3.97%
query_block/query_block_in(1000)_times(1000) 9.7±0.09ms 10.1±0.08ms +4.12%
query_block/query_block_in(1000)_times(10000) 96.6±1.17ms 101.3±1.26ms +4.87%
storage_transaction 1099.0±337.86µs 1091.7±331.86µs -0.66%
vm/transaction_execution/1 712.0±1.88ms 806.9±1.99ms +13.33%
vm/transaction_execution/10 177.1±0.50ms 198.0±0.70ms +11.80%
vm/transaction_execution/20 152.7±0.99ms 169.3±0.40ms +10.87%
vm/transaction_execution/5 234.1±0.70ms 263.2±0.42ms +12.43%
vm/transaction_execution/50 167.1±0.32ms 183.8±0.33ms +9.99%

@jiangying000 jiangying000 changed the title Upgrade StarcoinFramework to latset Upgrade StarcoinFramework to latest Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #3718 (e63a906) into master (b33372a) will decrease coverage by 0.52%.
The diff coverage is 57.70%.

❗ Current head e63a906 differs from pull request most recent head 2afbcef. Consider uploading reports for the commit 2afbcef to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3718      +/-   ##
==========================================
- Coverage   55.75%   55.23%   -0.51%     
==========================================
  Files         597      597              
  Lines       64424    64442      +18     
==========================================
- Hits        35914    35591     -323     
- Misses      28510    28851     +341     
Flag Coverage Δ
unittests 55.23% <57.70%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/stdlib/src/lib.rs 47.85% <57.70%> (-0.61%) ⬇️
...ccount_config/resources/module_upgrade_strategy.rs 59.10% <0.00%> (-36.36%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 43.48% <0.00%> (-24.63%) ⬇️
vm/dev/src/playground.rs 3.60% <0.00%> (-23.95%) ⬇️
rpc/server/src/module/debug_rpc.rs 22.92% <0.00%> (-18.75%) ⬇️
vm/types/src/language_storage_ext.rs 80.00% <0.00%> (-12.00%) ⬇️
rpc/server/src/module/contract_rpc.rs 7.03% <0.00%> (-11.98%) ⬇️
cmd/starcoin/src/dev/tests.rs 86.02% <0.00%> (-11.88%) ⬇️
vm/resource-viewer/src/lib.rs 0.66% <0.00%> (-11.84%) ⬇️
abi/types/src/lib.rs 29.51% <0.00%> (-8.60%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33372a...2afbcef. Read the comment docs.

@github-actions
Copy link

Benchmark for 7c9f62c

Click to view benchmark
Test Base PR %
accumulator_append 597.9±10.52µs 601.7±29.37µs +0.64%
block_apply/block_apply_10 634.2±3.14ms 727.3±1.72ms +14.68%
block_apply/block_apply_1000 64.4±0.04s 73.4±0.27s +13.98%
get_with_proof/db_store 35.9±0.25µs 36.3±0.38µs +1.11%
get_with_proof/mem_store 31.5±1.28µs 31.5±0.21µs 0.00%
put_and_commit/db_store/1 96.0±5.05µs 96.1±5.04µs +0.10%
put_and_commit/db_store/10 861.1±41.41µs 864.4±41.39µs +0.38%
put_and_commit/db_store/100 7.4±0.30ms 7.5±0.35ms +1.35%
put_and_commit/db_store/5 442.1±22.30µs 447.7±23.82µs +1.27%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 61.4±5.66µs 61.8±5.68µs +0.65%
put_and_commit/mem_store/10 574.8±47.83µs 579.3±47.23µs +0.78%
put_and_commit/mem_store/100 5.6±0.34ms 5.7±0.83ms +1.79%
put_and_commit/mem_store/5 289.4±24.58µs 291.4±24.74µs +0.69%
put_and_commit/mem_store/50 2.8±0.20ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 5.4±0.07ms 5.8±0.22ms +7.41%
query_block/query_block_in(10)_times(1000) 54.1±1.86ms 56.9±1.38ms +5.18%
query_block/query_block_in(10)_times(10000) 542.3±14.87ms 570.8±22.24ms +5.26%
query_block/query_block_in(1000)_times(100) 982.7±10.15µs 967.3±9.14µs -1.57%
query_block/query_block_in(1000)_times(1000) 9.8±0.11ms 9.7±0.15ms -1.02%
query_block/query_block_in(1000)_times(10000) 98.7±1.57ms 97.9±1.65ms -0.81%
storage_transaction 1099.9±278.37µs 1135.1±471.88µs +3.20%
vm/transaction_execution/1 714.2±1.81ms 806.3±1.91ms +12.90%
vm/transaction_execution/10 178.2±1.03ms 197.4±0.57ms +10.77%
vm/transaction_execution/20 153.5±0.91ms 169.2±0.56ms +10.23%
vm/transaction_execution/5 235.0±0.57ms 263.4±1.50ms +12.09%
vm/transaction_execution/50 168.4±0.41ms 183.8±0.59ms +9.14%

@pause125
Copy link
Collaborator

CI 应该会挂,有些基于旧 DAO 的测试用例通不过。

@github-actions
Copy link

Benchmark for cfde40f

Click to view benchmark
Test Base PR %
accumulator_append 607.6±29.18µs 616.1±28.72µs +1.40%
block_apply/block_apply_10 637.4±2.89ms 941.4±1.37ms +47.69%
block_apply/block_apply_1000 64.5±0.05s 95.5±0.29s +48.06%
get_with_proof/db_store 36.8±0.38µs 36.3±0.24µs -1.36%
get_with_proof/mem_store 31.8±0.18µs 31.6±0.32µs -0.63%
put_and_commit/db_store/1 96.5±7.29µs 96.1±4.83µs -0.41%
put_and_commit/db_store/10 858.5±38.56µs 857.4±39.02µs -0.13%
put_and_commit/db_store/100 7.3±0.30ms 7.3±0.28ms 0.00%
put_and_commit/db_store/5 446.4±22.75µs 443.3±23.08µs -0.69%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 61.9±5.65µs 61.8±5.70µs -0.16%
put_and_commit/mem_store/10 576.6±46.51µs 579.3±48.54µs +0.47%
put_and_commit/mem_store/100 5.6±0.33ms 5.7±0.84ms +1.79%
put_and_commit/mem_store/5 291.0±24.21µs 292.2±25.00µs +0.41%
put_and_commit/mem_store/50 2.8±0.18ms 2.9±0.19ms +3.57%
query_block/query_block_in(10)_times(100) 5.5±0.17ms 6.4±0.29ms +16.36%
query_block/query_block_in(10)_times(1000) 53.6±1.40ms 61.9±1.87ms +15.49%
query_block/query_block_in(10)_times(10000) 543.0±14.98ms 636.4±16.70ms +17.20%
query_block/query_block_in(1000)_times(100) 952.1±9.14µs 987.4±7.65µs +3.71%
query_block/query_block_in(1000)_times(1000) 9.6±0.05ms 10.0±0.24ms +4.17%
query_block/query_block_in(1000)_times(10000) 94.7±0.64ms 99.0±1.65ms +4.54%
storage_transaction 1081.5±283.31µs 1079.1±269.53µs -0.22%
vm/transaction_execution/1 714.9±3.71ms 1054.6±3.23ms +47.52%
vm/transaction_execution/10 178.2±1.18ms 245.9±2.49ms +37.99%
vm/transaction_execution/20 154.3±1.03ms 205.9±2.87ms +33.44%
vm/transaction_execution/5 234.9±0.37ms 335.5±8.85ms +42.83%
vm/transaction_execution/50 168.3±0.52ms 220.3±1.35ms +30.90%

@pause125 pause125 mentioned this pull request Sep 18, 2022
7 tasks
@WGB5445
Copy link
Contributor Author

WGB5445 commented Sep 18, 2022

后续由 #3741 继续追踪此 pr 功能

@WGB5445 WGB5445 closed this Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants