Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #4020

Merged
merged 1 commit into from
Apr 3, 2024
Merged

chore: fix typos #4020

merged 1 commit into from
Apr 3, 2024

Conversation

xiaoxianBoy
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): fix some typos

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@xiaoxianBoy xiaoxianBoy requested a review from nkysg as a code owner March 22, 2024 06:13
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.64%. Comparing base (1133f67) to head (24a5022).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4020      +/-   ##
==========================================
- Coverage   54.82%   54.64%   -0.17%     
==========================================
  Files         640      640              
  Lines       70982    70982              
==========================================
- Hits        38908    38782     -126     
- Misses      32074    32200     +126     
Flag Coverage Δ
unittests 54.64% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ons/forkable-jellyfish-merkle/src/node_type/mod.rs 91.99% <ø> (+0.56%) ⬆️
commons/metrics/src/op_counters.rs 0.00% <ø> (ø)
vm/parallel-executor/src/scheduler.rs 98.19% <ø> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216781c...24a5022. Read the comment docs.

Copy link
Collaborator

@simonjiao simonjiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@nkysg nkysg merged commit de5027c into starcoinorg:master Apr 3, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants