Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback for Force deploy on barnard network #4026

Merged
merged 10 commits into from
Apr 17, 2024
Merged

Rollback for Force deploy on barnard network #4026

merged 10 commits into from
Apr 17, 2024

Conversation

welbon
Copy link
Contributor

@welbon welbon commented Apr 16, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

nkysg
nkysg reviewed Apr 16, 2024
View reviewed changes
storage/src/upgrade.rs Outdated Show resolved Hide resolved
@welbon welbon changed the title [force-upgrade] Commit for rollback for barnard Commit for rollback for Force deploy on barnard network Apr 16, 2024
@welbon welbon requested a review from sanlee42 as a code owner April 16, 2024 06:31
@welbon welbon changed the title Commit for rollback for Force deploy on barnard network Rollback for Force deploy on barnard network Apr 16, 2024
@nkysg
Copy link
Collaborator

nkysg commented Apr 17, 2024

LGTM

@nkysg nkysg requested review from simonjiao, jackzhhuang and nkysg and removed request for yourmoonlight April 17, 2024 01:06
@welbon welbon requested a review from jolestar as a code owner April 17, 2024 03:18
@nkysg nkysg removed the request for review from jolestar April 17, 2024 03:19
@nkysg nkysg enabled auto-merge (squash) April 17, 2024 03:36
@nkysg nkysg merged commit 3173f8c into master Apr 17, 2024
4 of 5 checks passed
@nkysg nkysg deleted the barnard_rollback_block_fix_force_upgrade branch April 17, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkysg nkysg nkysg approved these changes

@sanlee42 sanlee42 Awaiting requested review from sanlee42 sanlee42 is a code owner

@simonjiao simonjiao Awaiting requested review from simonjiao

@jackzhhuang jackzhhuang Awaiting requested review from jackzhhuang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@welbon @nkysg @simonjiao