[FlexiDag Sync] optimization for the sync #4046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2, fix test cases
sanlee42
requested changes
Apr 30, 2024
| } | ||
|
|
||
| impl StorageVersion { | ||
| pub fn current_version() -> StorageVersion { | ||
| StorageVersion::V4 | ||
| StorageVersion::V5 |
There was a problem hiding this comment.
如果是针对main network, 是则是v3->v4，是不是放v4里升了？
| if future_covering_set.contains(&new_block) { | ||
| Ok(()) | ||
| } else { | ||
| Err(ReachabilityError::HashesNotOrdered) |
There was a problem hiding this comment.
这里是怎么出现的呢？如果出现了，也就是说会commit失败对吧？能否构造一个复线这个error的case
There was a problem hiding this comment.
多个线程很短时间内重复commit就会失败报HashesNotOrdered，这里增加一个重入的检查，产生这个失败的错误会大大降低，我连续试了10次，也不会再复现了，所以很难再构造这样的error case。
|
前面加上dag相关描述吧 |
sanlee42
approved these changes
May 2, 2024
nkysg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flexidag block synchronization improvements:
1, Optimized synchronization complexity, reduced from O(k*n) to O(n), where k is the number of block parents.
2, Reduced network requests for block synchronization.
3, Fixed reentrancy errors in reachability.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Other information