Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused codes from network and genesis #4135

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

simonjiao
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

* remove LegacyBlock from network rpc api
* remove LegacyStatus
* remove get_blocks_v1
Copy link

Benchmark for b180535

Click to view benchmark
Test Base PR %
accumulator_append 993.2±239.31µs 909.6±213.37µs -8.42%
block_apply/block_apply_10 479.4±88.18ms 427.3±71.70ms -10.87%
block_apply/block_apply_1000 51.1±3.51s 50.3±3.35s -1.57%
get_with_proof/db_store 56.1±13.42µs 56.6±11.53µs +0.89%
get_with_proof/mem_store 47.5±12.44µs 54.4±12.83µs +14.53%
put_and_commit/db_store/1 124.0±9.95µs 160.9±39.81µs +29.76%
put_and_commit/db_store/10 1580.4±350.91µs 1432.9±307.02µs -9.33%
put_and_commit/db_store/100 13.5±2.22ms 14.6±3.45ms +8.15%
put_and_commit/db_store/5 723.5±140.55µs 620.1±125.28µs -14.29%
put_and_commit/db_store/50 5.6±0.62ms 6.7±1.42ms +19.64%
put_and_commit/mem_store/1 81.2±19.18µs 99.4±21.13µs +22.41%
put_and_commit/mem_store/10 851.5±171.40µs 847.1±247.67µs -0.52%
put_and_commit/mem_store/100 9.0±2.00ms 10.4±2.41ms +15.56%
put_and_commit/mem_store/5 496.8±114.64µs 384.2±85.46µs -22.67%
put_and_commit/mem_store/50 4.2±0.97ms 3.4±0.25ms -19.05%
query_block/query_block_in(10)_times(100) 6.4±1.22ms 7.7±1.34ms +20.31%
query_block/query_block_in(10)_times(1000) 64.2±10.55ms 55.5±5.88ms -13.55%
query_block/query_block_in(10)_times(10000) 592.0±60.85ms 508.1±87.00ms -14.17%
query_block/query_block_in(1000)_times(100) 1635.2±309.41µs 1509.9±260.76µs -7.66%
query_block/query_block_in(1000)_times(1000) 13.4±2.04ms 14.0±2.11ms +4.48%
query_block/query_block_in(1000)_times(10000) 139.4±37.48ms 153.9±16.20ms +10.40%
storage_transaction 1116.3±346.21µs 1098.4±433.78µs -1.60%
vm/transaction_execution/1 531.3±99.90ms 506.9±81.33ms -4.59%
vm/transaction_execution/10 153.3±13.81ms 157.9±10.37ms +3.00%
vm/transaction_execution/20 141.9±8.91ms 138.8±12.25ms -2.18%
vm/transaction_execution/5 196.0±18.99ms 192.7±16.28ms -1.68%
vm/transaction_execution/50 175.1±20.50ms 168.0±17.20ms -4.05%

@simonjiao simonjiao merged commit 3fa7ce7 into dag-master Jun 11, 2024
5 checks passed
@simonjiao simonjiao deleted the remove-unused-codes-from-network-and-genesis branch June 11, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants