Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README with contribution section and general cleanup #159

Merged
merged 6 commits into from
Jun 26, 2023
Merged
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
171 changes: 117 additions & 54 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,69 +1,30 @@
# pystardog
[![PyPI version](https://badge.fury.io/py/pystardog.svg)](https://badge.fury.io/py/pystardog)

Python wrapper for communicating with the Stardog HTTP server.
a Python wrapper for communicating with the Stardog HTTP server.

**Docs**: [http://pystardog.readthedocs.io](http://pystardog.readthedocs.io)

**Requirements**: Python 3.8+

## What is it?

This framework wraps all the functionality of a client for the Stardog
This library wraps all the functionality of a client for the Stardog
Knowledge Graph, and provides access to a full set of functions such
as executing SPARQL queries, administrative tasks on Stardog, and the
use of the Reasoning API.
as executing SPARQL queries and many administrative tasks.

The implementation uses the HTTP protocol, since most of Stardog
functionality is available using this protocol. For more information,
go to the Stardog's [HTTP
Programming](http://www.stardog.com/docs/#_network_programming)
documentation.
see [HTTP
Programming](https://docs.stardog.com/developing/http-api)
in Stardog's documentation.

## Installation

pystardog is on PyPI so all you need is: `pip install pystardog`

## Documentation

Documentation is readable at [Read the
Docs](http://pystardog.readthedocs.io) or can be built using Sphinx:

cd docs
pip install -r requirements.txt
make html

## Tests

To run the tests locally, a valid Stardog license is required and placed in the `dockerfiles/stardog-license-key.bin`.
Docker and docker-compose are also required.

1) Bring a stardog instance using docker-compose. For testing about 90% of the pystardog features, just a single node is sufficient,
although we also provide a cluster set up for further testing.
```shell script
# Bring a single node instance plus a bunch of Virtual Graphs for testing (Recommended).
docker-compose -f docker-compose.single-node.yml up -d

# A cluster set up is also provided, if cluster only features are to be implemented and tested.
docker-compose -f docker-compose.cluster.yml up -d
```

Run the test suite. Create a virtual environment with the neccesary dependencies:
```shell script
# Create a virtualenv and activate it
virtualenv -p $(which python3) venv
source venv/bin/activate
pystardog is on [PyPI](https://pypi.org/project/pystardog/). To install:

# Install the dependencies
pip install -r requirements.txt -r test-requirements.txt

# Run the basic test suite (covers most of the pystardog functionalities)
pytest test/test_admin_basic.py test/test_connection.py test/test_utils.py -s
```


## Format
To run a format of all the files
```shell script
virtualenv -p $(which python3) venv
. venv/bin/activate
pip install -r test-requirements.txt
black .
```shell
pip install pystardog
```

## Quick Example
Expand Down Expand Up @@ -91,5 +52,107 @@ with stardog.Admin(**conn_details) as admin:

## Interactive Tutorial

There is a Jupyter notebook and instructions in the `notebooks`
There is a Jupyter notebook and instructions in the [`notebooks`](./notebooks)
directory of this repository.

## Documentation

Documentation is available at [http://pystardog.readthedocs.io](http://pystardog.readthedocs.io)

### Build the Docs Locally

The docs can be built locally using [Sphinx](https://www.sphinx-doc.org/en/master/):

```shell
cd docs
pip install -r requirements.txt
make html
```

## Contributing and Development

Contrbutions are always welcome to pystardog.

To make a contribution:

1. Create a new branch off of `main`. There is no set naming convention for branches but try and keep it descriptive.

```bash
git checkout -b feature/add-support-for-X
```

2. Make your changes. If you are making substantive changes to pystardog, tests should be added to ensure your changes are working as expected. See [Running Tests](#running-tests) for additional information
about running tests.

3. Format your code. All Python code should be formatted using [Black](https://pypi.org/project/black/). See [Formatting Your Code](#formatting-your-code) for additional information.

4. Commit and push your code. Similar to branch names, there is no set structure for commit messages but try and keep your commit messages succinct and on topic.

```bash
git commit -am "feat: adds support for feature X"
git push origin feature/add-support-for-x
```

5. Create a pull request against `main`. All CircleCI checks should be passing in order to merge your PR. CircleCI will run tests against all supported versions of Python, single node and clcluster tests for pystardog, as well as do some static analysis of the code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r/clcluster/cluster


### Running Tests

#### Requirements:

- [Docker](https://docs.docker.com/)
- [Docker Compose](https://docs.docker.com/compose/)
- Valid Stardog License

To run the tests locally, a valid Stardog license is required and placed at `dockerfiles/stardog-license-key.bin`.

1. Bring a stardog instance using docker-compose. For testing about 90% of the pystardog features, just a single node is sufficient,
although we also provide a cluster set up for further testing.

```shell
# Bring a single node instance plus a bunch of Virtual Graphs for testing (Recommended).
docker-compose -f docker-compose.single-node.yml up -d

# A cluster setup is also provided, if cluster only features are to be implemented and tested.
docker-compose -f docker-compose.cluster.yml up -d
```

2. Create a virtual environment with the necessary dependencies:

```shell
# Create a virtualenv and activate it
virtualenv -p $(which python3) venv
source venv/bin/activate

# Install dependencies
pip install -r requirements.txt -r test-requirements.txt
```

3. Run the test suite:

```shell
# Run the basic test suite (covers most of the pystardog functionalities)
pytest test/test_admin_basic.py test/test_connection.py test/test_utils.py -s
```

> **Note**
> Tests can be targeted against a specific Stardog endpoint by specifying an `--endpoint` option to `pytest`. Please note, that the tests will make modifications
> to the Stardog instance like deleting users, roles, databases, etc. By default, the `--endpoint` is set to `http://localhost:5820`,
> which is where the Dockerized Stardog (defined in the Docker compose files) is configured to be available at.
>
> ```bash
> pytest test/test_connection.py -k test_queries -s --endpoint https://my-other-stardog:5820
> ```

### Formatting your code

To format all the Python code:

```shell
# make sure black is install
virtualenv -p $(which python3) venv
. venv/bin/activate
pip install -r test-requirements.txt

# run black formatter
black .
```