reproduce demo bug

stargate · Mar 8, 2023 · 08a3092 · 08a3092
1 parent 7d3b627
commit 08a3092
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 3 deletions.
diff --git a/src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/InsertOperation.java b/src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/InsertOperation.java
@@ -65,9 +65,6 @@ private Uni<Supplier<CommandResult>> insertOrdered(QueryExecutor queryExecutor)
         .collect()
         .in(InsertOperationPage::new, (agg, in) -> agg.aggregate(in, null))
 
-        // use object identity to resolve to Supplier<CommandResult>
-        .map(i -> i)
-
         // in case upstream propagated FailFastInsertException
         // ensure to construct correctly the information about inserted documents
         .onFailure(FailFastInsertException.class)

diff --git a/src/test/java/io/stargate/sgv2/jsonapi/api/v1/InsertIntegrationTest.java b/src/test/java/io/stargate/sgv2/jsonapi/api/v1/InsertIntegrationTest.java
@@ -6,6 +6,7 @@
 import static org.hamcrest.Matchers.blankString;
 import static org.hamcrest.Matchers.contains;
 import static org.hamcrest.Matchers.containsInAnyOrder;
+import static org.hamcrest.Matchers.empty;
 import static org.hamcrest.Matchers.hasSize;
 import static org.hamcrest.Matchers.is;
 import static org.hamcrest.Matchers.not;
@@ -395,6 +396,47 @@ public void orderedDuplicateIds() {
           .body("errors", is(nullValue()));
     }
 
+    @Test
+    public void orderedDuplicateIdsNoNamespace() {
+      String json =
+          """
+          {
+            "insertMany": {
+              "documents": [
+                {
+                  "_id": "doc4",
+                  "username": "user4"
+                },
+                {
+                  "_id": "doc4",
+                  "username": "user4_duplicate"
+                },
+                {
+                  "_id": "doc5",
+                  "username": "user5"
+                }
+              ]
+            }
+          }
+          """;
+
+      given()
+          .header(HttpConstants.AUTHENTICATION_TOKEN_HEADER_NAME, getAuthToken())
+          .contentType(ContentType.JSON)
+          .body(json)
+          .when()
+          .post(CollectionResource.BASE_PATH, "something_else", collectionName)
+          .then()
+          .statusCode(200)
+          .body("status.insertedIds", is(empty()))
+          .body("data", is(nullValue()))
+          .body(
+              "errors[0].message",
+              startsWith(
+                  "Failed to insert document with _id doc4: INVALID_ARGUMENT: keyspace something_else does not exist"))
+          .body("errors[0].exceptionClass", is("StatusRuntimeException"));
+    }
+
     @Test
     public void unordered() {
       String json =