Reduce logging of known+handled cases (#472)

stargate · Jul 26, 2023 · 5364d5b · 5364d5b
1 parent 882d0e2
commit 5364d5b
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/main/java/io/stargate/sgv2/jsonapi/service/processor/CommandProcessor.java b/src/main/java/io/stargate/sgv2/jsonapi/service/processor/CommandProcessor.java
@@ -62,19 +62,21 @@ public <T extends Command> Uni<CommandResult> processCommand(
               return operation.execute(queryExecutor);
             })
 
-        // handler failures here
+        // handle failures here
         .onFailure()
         .recoverWithItem(
             t -> {
-              logger.warn(
-                  "The command {} failed with exception", command.getClass().getSimpleName(), t);
               // DocsException is supplier of the CommandResult
               // so simply return
               if (t instanceof JsonApiException jsonApiException) {
+                // Note: JsonApiException means that JSON API itself handled the situation
+                // (created, or wrapped the exception) -- should not be logged (have already
+                // been logged if necessary)
                 return jsonApiException;
               }
-
-              // otherwise use generic for now
+              // But other exception types are unexpected, so log for now
+              logger.warn(
+                  "Command '{}' failed with exception", command.getClass().getSimpleName(), t);
               return new ThrowableCommandResultSupplier(t);
             })